Patchwork libtool: Add depends on binutils-cross

login
register
mail settings
Submitter Zongchun Yu
Date April 1, 2014, 6:12 a.m.
Message ID <1396332774-31033-1-git-send-email-b40527@freescale.com>
Download mbox | patch
Permalink /patch/69793/
State Rejected
Headers show

Comments

Zongchun Yu - April 1, 2014, 6:12 a.m.
From: Zongchun Yu <Zongchun.Yu@freescale.com>

When use command bitbake -c populate_sdk <target-rootfs> to
generate toolchain. a race issue may occur. in this case need
to add binutils-cross to depends.

Signed-off-by: Zongchun Yu <Zongchun.Yu@freescale.com>
---
 meta/recipes-devtools/libtool/libtool-2.4.2.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Khem Raj - April 1, 2014, 6:15 a.m.
On Mar 31, 2014, at 11:12 PM, <b40527@freescale.com> <b40527@freescale.com> wrote:

> From: Zongchun Yu <Zongchun.Yu@freescale.com>
> 
> When use command bitbake -c populate_sdk <target-rootfs> to
> generate toolchain. a race issue may occur. in this case need
> to add binutils-cross to depends.
> 

can you explain the race a bit here.
Zongchun Yu - April 1, 2014, 6:37 a.m.
>can you explain the race a bit here. 

Sorry to confuse you. Sometimes libtool have been built but the
binutils-cross have't been built yet.
It is required by libtool.
Khem Raj - April 1, 2014, 6:46 a.m.
On Mar 31, 2014, at 11:37 PM, Zongchun YU <b40527@freescale.com> wrote:

> Sorry to confuse you. Sometimes libtool have been built but the
> binutils-cross have't been built yet.
> It is required by libtool.

OK is it cross, native or target recipe which has the problem ?
wouldnt it need to also depend on gcc-cross ?
Zongchun Yu - April 1, 2014, 7:22 a.m.
>OK is it cross, native or target recipe which has the problem ?
>wouldnt it need to also depend on gcc-cross ?

Only cross recipe has the problem. There is no need to gcc-cross.
Richard Purdie - April 1, 2014, 10:52 a.m.
On Tue, 2014-04-01 at 14:12 +0800, b40527@freescale.com wrote:
> From: Zongchun Yu <Zongchun.Yu@freescale.com>
> 
> When use command bitbake -c populate_sdk <target-rootfs> to
> generate toolchain. a race issue may occur. in this case need
> to add binutils-cross to depends.
> 
> Signed-off-by: Zongchun Yu <Zongchun.Yu@freescale.com>
> ---
>  meta/recipes-devtools/libtool/libtool-2.4.2.inc |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-devtools/libtool/libtool-2.4.2.inc b/meta/recipes-devtools/libtool/libtool-2.4.2.inc
> index d26982d..0868dd7 100644
> --- a/meta/recipes-devtools/libtool/libtool-2.4.2.inc
> +++ b/meta/recipes-devtools/libtool/libtool-2.4.2.inc
> @@ -36,7 +36,7 @@ do_compile_prepend () {
>  inherit autotools
>  EXTRA_AUTORECONF = "--exclude=libtoolize"
>  
> -DEPENDS = "libtool-native"
> +DEPENDS = "libtool-native binutils-cross"
>  
>  PACKAGES =+ "libltdl libltdl-dev libltdl-dbg libltdl-staticdev"
>  FILES_${PN} += "${datadir}/aclocal"


You're patching the .inc file here so this dependency is being applied
to multiple different libtools. Can you perhaps explain the problem you
were seeing with a step by step how to reproduce the problem?

I'd like to understand the real problem here, I don't doubt it exists
but I'm not sure this is the correct fix.

Cheers,

Richard

Patch

diff --git a/meta/recipes-devtools/libtool/libtool-2.4.2.inc b/meta/recipes-devtools/libtool/libtool-2.4.2.inc
index d26982d..0868dd7 100644
--- a/meta/recipes-devtools/libtool/libtool-2.4.2.inc
+++ b/meta/recipes-devtools/libtool/libtool-2.4.2.inc
@@ -36,7 +36,7 @@  do_compile_prepend () {
 inherit autotools
 EXTRA_AUTORECONF = "--exclude=libtoolize"
 
-DEPENDS = "libtool-native"
+DEPENDS = "libtool-native binutils-cross"
 
 PACKAGES =+ "libltdl libltdl-dev libltdl-dbg libltdl-staticdev"
 FILES_${PN} += "${datadir}/aclocal"