Patchwork pixbufcache.bbclass: Fix setscene silent failures

login
register
mail settings
Submitter Richard Purdie
Date March 31, 2014, 10:08 p.m.
Message ID <1396303734.14790.87.camel@ted>
Download mbox | patch
Permalink /patch/69761/
State New
Headers show

Comments

Richard Purdie - March 31, 2014, 10:08 p.m.
Unfortunately gdk-pixbuf-query-loaders can issue errors but still return
success. We therefore check for output and error in the case any output
is issued (normal success does not issue any).

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
Ross: I'm open to better patches ;-)
[I wrote this to debug other problems]

Patch

diff --git a/meta/classes/pixbufcache.bbclass b/meta/classes/pixbufcache.bbclass
index 414fd30..88da734 100644
--- a/meta/classes/pixbufcache.bbclass
+++ b/meta/classes/pixbufcache.bbclass
@@ -53,7 +53,11 @@  SSTATEPOSTINSTFUNCS_append_class-native = " pixbufcache_sstate_postinst"
 pixbufcache_sstate_postinst() {
 	if [ "${BB_CURRENTTASK}" = "populate_sysroot" -o "${BB_CURRENTTASK}" = "populate_sysroot_setscene" ]
 	then
-		gdk-pixbuf-query-loaders --update-cache
+		T=`gdk-pixbuf-query-loaders --update-cache 2>&1`
+		if [ -n "$T" ]; then 
+			echo $T
+			exit 1
+		fi
 	fi
 }