Patchwork [3/5] packagegroup-self-hosted: Use packagegroup-core-buildessential

login
register
mail settings
Submitter Cristian Iorga
Date March 28, 2014, 4:48 p.m.
Message ID <969F26A8BAB325438E7EB80D3C3134FB1CE744B2@IRSMSX105.ger.corp.intel.com>
Download mbox | patch
Permalink /patch/69591/
State New
Headers show

Comments

Cristian Iorga - March 28, 2014, 4:48 p.m.
Hello all,

This is an important patch, please make sure that BA still works correctly after this one gets merged (including properly building an image in BA).

Thanks,
Cristian Iorga
YP
Intel Corporation

-----Original Message-----
From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Hongxu Jia
Sent: Friday, March 28, 2014 11:44 AM
To: openembedded-core@lists.openembedded.org
Cc: Wold, Saul
Subject: [OE-core] [PATCH 3/5] packagegroup-self-hosted: Use packagegroup-core-buildessential

From: Mark Hatle <mark.hatle@windriver.com>

Instead of manually specifying build dependencies, use the packagegroup-core-buildessential.  This ensures there is only one place that needs to be modified when toolchain items and dependencies change.

Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
Signed-off-by: Jeff Polk <jeff.polk@windriver.com>
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/recipes-core/packagegroups/packagegroup-self-hosted.bb | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

--
1.8.1.2

--
Hongxu Jia - March 31, 2014, 8:31 a.m.
On 03/29/2014 12:48 AM, Iorga, Cristian wrote:
> Hello all,
>
> This is an important patch, please make sure that BA still works correctly after this one gets merged (including properly building an image in BA).

Hi Cristian,

I have built the build-appliance-image with this one merged,
and everything is ok, but I could not understand what the 'BA'
means, would you please explain that?

Thanks,
//Hongxu

> Thanks,
> Cristian Iorga
> YP
> Intel Corporation
>
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Hongxu Jia
> Sent: Friday, March 28, 2014 11:44 AM
> To: openembedded-core@lists.openembedded.org
> Cc: Wold, Saul
> Subject: [OE-core] [PATCH 3/5] packagegroup-self-hosted: Use packagegroup-core-buildessential
>
> From: Mark Hatle <mark.hatle@windriver.com>
>
> Instead of manually specifying build dependencies, use the packagegroup-core-buildessential.  This ensures there is only one place that needs to be modified when toolchain items and dependencies change.
>
> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
> Signed-off-by: Jeff Polk <jeff.polk@windriver.com>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>   meta/recipes-core/packagegroups/packagegroup-self-hosted.bb | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb b/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb
> index 5581d8e..fe49fb4 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb
> @@ -66,33 +66,23 @@ RRECOMMENDS_packagegroup-self-hosted-host-tools = "\
>   
>   # eglibc-utils: for rpcgen
>   RDEPENDS_packagegroup-self-hosted-sdk = "\
> -    autoconf \
> -    automake \
> -    binutils \
>       ccache \
>       coreutils \
> -    cpp \
>       distcc \
>       eglibc-utils \
>       eglibc-gconv-ibm850 \
>       file \
>       findutils \
> -    g++ \
> -    gcc \
>       intltool \
>       ldd \
>       less \
>       libssp \
>       libssp-dev \
>       libssp-staticdev \
> -    libstdc++ \
> -    libstdc++-dev \
> -    libtool \
> -    make \
>       mktemp \
> +    packagegroup-core-buildessential \
>       perl-module-re \
>       perl-module-text-wrap \
> -    pkgconfig \
>       quilt \
>       sed \
>       "
> --
> 1.8.1.2
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Cristian Iorga - March 31, 2014, 8:52 a.m.
Hello,

BA is short for Build Appliance, and corresponds to build-appliance-image target.
Like I previously said, only building BA is not a proper test.
After the change that you proposed (a fine change, I might say), building images in BA is another test that needs to be performed in order to validate your change.
See details here: https://www.yoctoproject.org/documentation/build-appliance-manual

Regards,
Cristian Iorga
YP
Intel Corporation

-----Original Message-----
From: Hongxu Jia [mailto:hongxu.jia@windriver.com] 
Sent: Monday, March 31, 2014 11:32 AM
To: Iorga, Cristian
Cc: openembedded-core@lists.openembedded.org; Georgescu, Alexandru C
Subject: Re: [OE-core] [PATCH 3/5] packagegroup-self-hosted: Use packagegroup-core-buildessential

On 03/29/2014 12:48 AM, Iorga, Cristian wrote:
> Hello all,
>
> This is an important patch, please make sure that BA still works correctly after this one gets merged (including properly building an image in BA).

Hi Cristian,

I have built the build-appliance-image with this one merged, and everything is ok, but I could not understand what the 'BA'
means, would you please explain that?

Thanks,
//Hongxu

> Thanks,
> Cristian Iorga
> YP
> Intel Corporation
>
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org 
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of 
> Hongxu Jia
> Sent: Friday, March 28, 2014 11:44 AM
> To: openembedded-core@lists.openembedded.org
> Cc: Wold, Saul
> Subject: [OE-core] [PATCH 3/5] packagegroup-self-hosted: Use 
> packagegroup-core-buildessential
>
> From: Mark Hatle <mark.hatle@windriver.com>
>
> Instead of manually specifying build dependencies, use the packagegroup-core-buildessential.  This ensures there is only one place that needs to be modified when toolchain items and dependencies change.
>
> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
> Signed-off-by: Jeff Polk <jeff.polk@windriver.com>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>   meta/recipes-core/packagegroups/packagegroup-self-hosted.bb | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git 
> a/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb 
> b/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb
> index 5581d8e..fe49fb4 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb
> @@ -66,33 +66,23 @@ RRECOMMENDS_packagegroup-self-hosted-host-tools = 
> "\
>   
>   # eglibc-utils: for rpcgen
>   RDEPENDS_packagegroup-self-hosted-sdk = "\
> -    autoconf \
> -    automake \
> -    binutils \
>       ccache \
>       coreutils \
> -    cpp \
>       distcc \
>       eglibc-utils \
>       eglibc-gconv-ibm850 \
>       file \
>       findutils \
> -    g++ \
> -    gcc \
>       intltool \
>       ldd \
>       less \
>       libssp \
>       libssp-dev \
>       libssp-staticdev \
> -    libstdc++ \
> -    libstdc++-dev \
> -    libtool \
> -    make \
>       mktemp \
> +    packagegroup-core-buildessential \
>       perl-module-re \
>       perl-module-text-wrap \
> -    pkgconfig \
>       quilt \
>       sed \
>       "
> --
> 1.8.1.2
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb b/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb
index 5581d8e..fe49fb4 100644
--- a/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb
@@ -66,33 +66,23 @@  RRECOMMENDS_packagegroup-self-hosted-host-tools = "\
 
 # eglibc-utils: for rpcgen
 RDEPENDS_packagegroup-self-hosted-sdk = "\
-    autoconf \
-    automake \
-    binutils \
     ccache \
     coreutils \
-    cpp \
     distcc \
     eglibc-utils \
     eglibc-gconv-ibm850 \
     file \
     findutils \
-    g++ \
-    gcc \
     intltool \
     ldd \
     less \
     libssp \
     libssp-dev \
     libssp-staticdev \
-    libstdc++ \
-    libstdc++-dev \
-    libtool \
-    make \
     mktemp \
+    packagegroup-core-buildessential \
     perl-module-re \
     perl-module-text-wrap \
-    pkgconfig \
     quilt \
     sed \
     "