Patchwork Update gstreamer1.0-plugins-imx to version 0.9.5

login
register
mail settings
Submitter Carlos Rafael Giani
Date March 27, 2014, 10:40 p.m.
Message ID <1395960055-10266-1-git-send-email-dv@pseudoterminal.org>
Download mbox | patch
Permalink /patch/69497/
State Accepted
Delegated to: Otavio Salvador
Headers show

Comments

Carlos Rafael Giani - March 27, 2014, 10:40 p.m.
Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
---
 ...er1.0-plugins-imx_0.9.2.bb => gstreamer1.0-plugins-imx_0.9.5.bb} | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
 rename recipes-multimedia/gstreamer/{gstreamer1.0-plugins-imx_0.9.2.bb => gstreamer1.0-plugins-imx_0.9.5.bb} (86%)
Daiane Angolini - March 28, 2014, 11:31 a.m.
On Thu, Mar 27, 2014 at 7:40 PM, Carlos Rafael Giani
<dv@pseudoterminal.org> wrote:
> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
> ---
>  ...er1.0-plugins-imx_0.9.2.bb => gstreamer1.0-plugins-imx_0.9.5.bb} | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>  rename recipes-multimedia/gstreamer/{gstreamer1.0-plugins-imx_0.9.2.bb => gstreamer1.0-plugins-imx_0.9.5.bb} (86%)
>
> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.2.bb b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.5.bb
> similarity index 86%
> rename from recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.2.bb
> rename to recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.5.bb
> index 2bbd3f9..3b324ba 100644
> --- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.2.bb
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.5.bb
> @@ -6,18 +6,16 @@ DEPENDS = "gstreamer1.0 gstreamer1.0-plugins-base libfslvpuwrap virtual/kernel v
>             virtual/libgles2 ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
>
>  SRCBRANCH ?= "master"
> -SRCREV = "331f268b3bc282351b82c3548e703ea04be72b2c"
> +SRCREV = "579b63426e47ed3d9265c569bbfd38a054eecf38"
>  SRC_URI = "git://github.com/Freescale/gstreamer-imx.git;branch=${SRCBRANCH}"
>
>  S = "${WORKDIR}/git"
>
>  inherit waf
>
> -CFLAGS += "-I${STAGING_KERNEL_DIR}/include"
> -
>  # configure the eglvivsink element to use the appropiate EGL platform code
>  EGLVIVSINK_PLATFORM = "${@base_contains('DISTRO_FEATURES', 'x11', 'x11', 'fb', d)}"
> -EXTRA_OECONF = "--egl-platform=${EGLVIVSINK_PLATFORM}"
> +EXTRA_OECONF = "--egl-platform=${EGLVIVSINK_PLATFORM} --kernel-headers=${STAGING_KERNEL_DIR}/include"

Which kernel it's based for?

Please rework your commit log to include any change you made in recipe.
You added one option on EXTRA_OECONF and removed CFLAGS and hadn't documented.



Daiane
>
>  # LIBV is used by gst-plugins-package.inc to specify the GStreamer version (0.10 vs 1.0)
>  LIBV = "1.0"
> --
> 1.8.3.2
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
Carlos Rafael Giani - March 28, 2014, 11:34 a.m.
On 2014-03-28 12:31, Daiane Angolini wrote:
> On Thu, Mar 27, 2014 at 7:40 PM, Carlos Rafael Giani
> <dv@pseudoterminal.org> wrote:
>> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
>> ---
>>   ...er1.0-plugins-imx_0.9.2.bb => gstreamer1.0-plugins-imx_0.9.5.bb} | 6 ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
>>   rename recipes-multimedia/gstreamer/{gstreamer1.0-plugins-imx_0.9.2.bb => gstreamer1.0-plugins-imx_0.9.5.bb} (86%)
>>
>> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.2.bb b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.5.bb
>> similarity index 86%
>> rename from recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.2.bb
>> rename to recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.5.bb
>> index 2bbd3f9..3b324ba 100644
>> --- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.2.bb
>> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.5.bb
>> @@ -6,18 +6,16 @@ DEPENDS = "gstreamer1.0 gstreamer1.0-plugins-base libfslvpuwrap virtual/kernel v
>>              virtual/libgles2 ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
>>
>>   SRCBRANCH ?= "master"
>> -SRCREV = "331f268b3bc282351b82c3548e703ea04be72b2c"
>> +SRCREV = "579b63426e47ed3d9265c569bbfd38a054eecf38"
>>   SRC_URI = "git://github.com/Freescale/gstreamer-imx.git;branch=${SRCBRANCH}"
>>
>>   S = "${WORKDIR}/git"
>>
>>   inherit waf
>>
>> -CFLAGS += "-I${STAGING_KERNEL_DIR}/include"
>> -
>>   # configure the eglvivsink element to use the appropiate EGL platform code
>>   EGLVIVSINK_PLATFORM = "${@base_contains('DISTRO_FEATURES', 'x11', 'x11', 'fb', d)}"
>> -EXTRA_OECONF = "--egl-platform=${EGLVIVSINK_PLATFORM}"
>> +EXTRA_OECONF = "--egl-platform=${EGLVIVSINK_PLATFORM} --kernel-headers=${STAGING_KERNEL_DIR}/include"
> Which kernel it's based for?
>
> Please rework your commit log to include any change you made in recipe.
> You added one option on EXTRA_OECONF and removed CFLAGS and hadn't documented.



I tested this with the 3.0.35 and the 3.10 kernels. The build script 
autodetects the kernel version and adds the path to the uapi headers if 
necessary.

As for the commit, I thought it is self-explanatory. I just changed the 
way I specify the path to the kernel headers. But okay, I can change it.

Carlos


>
>
>
> Daiane
>>   # LIBV is used by gst-plugins-package.inc to specify the GStreamer version (0.10 vs 1.0)
>>   LIBV = "1.0"
>> --
>> 1.8.3.2
>>
>> --
>> _______________________________________________
>> meta-freescale mailing list
>> meta-freescale@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-freescale
Daiane Angolini - March 28, 2014, 11:56 a.m.
On Fri, Mar 28, 2014 at 8:34 AM, Carlos Rafael Giani
<dv@pseudoterminal.org> wrote:
> On 2014-03-28 12:31, Daiane Angolini wrote:

>
> I tested this with the 3.0.35 and the 3.10 kernels. The build script
> autodetects the kernel version and adds the path to the uapi headers if
> necessary.
>
> As for the commit, I thought it is self-explanatory. I just changed the way
> I specify the path to the kernel headers. But okay, I can change it.

Ops, You're right. I'm sorry.
If this is the only change for v2 you can avoid it ;)


Daiane

Patch

diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.2.bb b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.5.bb
similarity index 86%
rename from recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.2.bb
rename to recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.5.bb
index 2bbd3f9..3b324ba 100644
--- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.2.bb
+++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.5.bb
@@ -6,18 +6,16 @@  DEPENDS = "gstreamer1.0 gstreamer1.0-plugins-base libfslvpuwrap virtual/kernel v
            virtual/libgles2 ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
 
 SRCBRANCH ?= "master"
-SRCREV = "331f268b3bc282351b82c3548e703ea04be72b2c"
+SRCREV = "579b63426e47ed3d9265c569bbfd38a054eecf38"
 SRC_URI = "git://github.com/Freescale/gstreamer-imx.git;branch=${SRCBRANCH}"
 
 S = "${WORKDIR}/git"
 
 inherit waf
 
-CFLAGS += "-I${STAGING_KERNEL_DIR}/include"
-
 # configure the eglvivsink element to use the appropiate EGL platform code
 EGLVIVSINK_PLATFORM = "${@base_contains('DISTRO_FEATURES', 'x11', 'x11', 'fb', d)}"
-EXTRA_OECONF = "--egl-platform=${EGLVIVSINK_PLATFORM}"
+EXTRA_OECONF = "--egl-platform=${EGLVIVSINK_PLATFORM} --kernel-headers=${STAGING_KERNEL_DIR}/include"
 
 # LIBV is used by gst-plugins-package.inc to specify the GStreamer version (0.10 vs 1.0)
 LIBV = "1.0"