Patchwork [2/4] gummiboot: add COMPATIBLE_HOST

login
register
mail settings
Submitter Robert Yang
Date March 27, 2014, 2:48 p.m.
Message ID <53343A32.6070109@windriver.com>
Download mbox | patch
Permalink /patch/69403/
State New
Headers show

Comments

Robert Yang - March 27, 2014, 2:48 p.m.
On 03/27/2014 07:39 PM, Martin Jansa wrote:
> On Thu, Mar 27, 2014 at 04:11:22AM -0400, Robert Yang wrote:
>> The gummiboot depends on gnu-efi which had set:
>>
>> COMPATIBLE_HOST = "(x86_64.*|i.86.*)-linux"
>>
>> We also need set this for gummiboot, otherwise there would be build
>> failures for other non-x86 archs.
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   meta/recipes-bsp/gummiboot/gummiboot_git.bb |    2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/recipes-bsp/gummiboot/gummiboot_git.bb b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
>> index 5868a23..61de58c 100644
>> --- a/meta/recipes-bsp/gummiboot/gummiboot_git.bb
>> +++ b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
>> @@ -13,6 +13,8 @@ PV = "43+git${SRCPV}"
>>   SRCREV = "4062c51075ba054d4949c714fe06123f9ad3097d"
>>   SRC_URI = "git://anongit.freedesktop.org/gummiboot"
>>
>
> It would be good to add comment here saying it's only because of gnu-efi
> dependency (if gummiboot itself can in theory work on other hosts).
>

Sounds reasonable, updated:

   git://git.openembedded.org/openembedded-core-contrib rbt/gummiboot
 
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/gummiboot


// Robert


> People won't notice it in commit message when they are looking at
> recipe.
>
>> +COMPATIBLE_HOST = "(x86_64.*|i.86.*)-linux"
>> +
>>   S = "${WORKDIR}/git"
>>
>>   EXTRA_OECONF = "--disable-manpages --with-efi-includedir=${STAGING_INCDIR} \
>> --
>> 1.7.10.4
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-bsp/gummiboot/gummiboot_git.bb 
b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
index 61de58c..035cec1 100644
--- a/meta/recipes-bsp/gummiboot/gummiboot_git.bb
+++ b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
@@ -13,6 +13,9 @@  PV = "43+git${SRCPV}"
  SRCREV = "4062c51075ba054d4949c714fe06123f9ad3097d"
  SRC_URI = "git://anongit.freedesktop.org/gummiboot"

+# Note: Add COMPATIBLE_HOST here is only because it depends on gnu-efi
+# which has set the COMPATIBLE_HOST, the gummiboot itself may work on
+# more hosts.
  COMPATIBLE_HOST = "(x86_64.*|i.86.*)-linux"

  S = "${WORKDIR}/git"