Patchwork [2/4] gummiboot: add COMPATIBLE_HOST

login
register
mail settings
Submitter Robert Yang
Date March 27, 2014, 8:11 a.m.
Message ID <9bd12f5fca3736b2975ce0249b3428b5b0af194e.1395906475.git.liezhi.yang@windriver.com>
Download mbox | patch
Permalink /patch/69373/
State New
Headers show

Comments

Robert Yang - March 27, 2014, 8:11 a.m.
The gummiboot depends on gnu-efi which had set:

COMPATIBLE_HOST = "(x86_64.*|i.86.*)-linux"

We also need set this for gummiboot, otherwise there would be build
failures for other non-x86 archs.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/recipes-bsp/gummiboot/gummiboot_git.bb |    2 ++
 1 file changed, 2 insertions(+)
Martin Jansa - March 27, 2014, 11:39 a.m.
On Thu, Mar 27, 2014 at 04:11:22AM -0400, Robert Yang wrote:
> The gummiboot depends on gnu-efi which had set:
> 
> COMPATIBLE_HOST = "(x86_64.*|i.86.*)-linux"
> 
> We also need set this for gummiboot, otherwise there would be build
> failures for other non-x86 archs.
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/recipes-bsp/gummiboot/gummiboot_git.bb |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-bsp/gummiboot/gummiboot_git.bb b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
> index 5868a23..61de58c 100644
> --- a/meta/recipes-bsp/gummiboot/gummiboot_git.bb
> +++ b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
> @@ -13,6 +13,8 @@ PV = "43+git${SRCPV}"
>  SRCREV = "4062c51075ba054d4949c714fe06123f9ad3097d"
>  SRC_URI = "git://anongit.freedesktop.org/gummiboot"
>  

It would be good to add comment here saying it's only because of gnu-efi
dependency (if gummiboot itself can in theory work on other hosts).

People won't notice it in commit message when they are looking at
recipe.

> +COMPATIBLE_HOST = "(x86_64.*|i.86.*)-linux"
> +
>  S = "${WORKDIR}/git"
>  
>  EXTRA_OECONF = "--disable-manpages --with-efi-includedir=${STAGING_INCDIR} \
> -- 
> 1.7.10.4
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj - March 27, 2014, 4:08 p.m.
On Thu, Mar 27, 2014 at 1:11 AM, Robert Yang <liezhi.yang@windriver.com> wrote:
> The gummiboot depends on gnu-efi which had set:
>
> COMPATIBLE_HOST = "(x86_64.*|i.86.*)-linux"
>
> We also need set this for gummiboot, otherwise there would be build
> failures for other non-x86 archs.

isn't gnu-efi supported on arm too now ?
Fathi Boudra - March 27, 2014, 8:45 p.m.
On 27 March 2014 18:08, Khem Raj <raj.khem@gmail.com> wrote:
> On Thu, Mar 27, 2014 at 1:11 AM, Robert Yang <liezhi.yang@windriver.com> wrote:
>> The gummiboot depends on gnu-efi which had set:
>>
>> COMPATIBLE_HOST = "(x86_64.*|i.86.*)-linux"
>>
>> We also need set this for gummiboot, otherwise there would be build
>> failures for other non-x86 archs.
>
> isn't gnu-efi supported on arm too now ?

on ARM, Tianocore EDK II is used with GRUB for the boot manager.
I haven't heard about using EDK II with gummiboot... yet.

Patch

diff --git a/meta/recipes-bsp/gummiboot/gummiboot_git.bb b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
index 5868a23..61de58c 100644
--- a/meta/recipes-bsp/gummiboot/gummiboot_git.bb
+++ b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
@@ -13,6 +13,8 @@  PV = "43+git${SRCPV}"
 SRCREV = "4062c51075ba054d4949c714fe06123f9ad3097d"
 SRC_URI = "git://anongit.freedesktop.org/gummiboot"
 
+COMPATIBLE_HOST = "(x86_64.*|i.86.*)-linux"
+
 S = "${WORKDIR}/git"
 
 EXTRA_OECONF = "--disable-manpages --with-efi-includedir=${STAGING_INCDIR} \