Patchwork [01/11] bluez4: Add virtual/bluez as provider

login
register
mail settings
Submitter Lauren Post
Date March 26, 2014, 2:27 p.m.
Message ID <1395844085-9929-2-git-send-email-lauren.post@freescale.com>
Download mbox | patch
Permalink /patch/69291/
State New
Headers show

Comments

Lauren Post - March 26, 2014, 2:27 p.m.
This will make it easier to allow bluez5 support later
Without this change too many components depend directly on bluez4
If these components depend on virtual/bluez then easier to upgrade.

Signed-off-by: Lauren Post <lauren.post@freescale.com>
---
 meta/recipes-connectivity/bluez/bluez4.inc |    4 ++++
 1 file changed, 4 insertions(+)
Ross Burton - March 26, 2014, 5:03 p.m.
Surely there should also be a patch to do the same for bluez5 so the
switch can be compile-tested?

Ross

On 26 March 2014 14:27, Lauren Post <lauren.post@freescale.com> wrote:
> This will make it easier to allow bluez5 support later
> Without this change too many components depend directly on bluez4
> If these components depend on virtual/bluez then easier to upgrade.
>
> Signed-off-by: Lauren Post <lauren.post@freescale.com>
> ---
>  meta/recipes-connectivity/bluez/bluez4.inc |    4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc
> index 0827005..dce9642 100644
> --- a/meta/recipes-connectivity/bluez/bluez4.inc
> +++ b/meta/recipes-connectivity/bluez/bluez4.inc
> @@ -7,9 +7,13 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
>                      file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
>                      file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \
>                      file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191"
> +
>  DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck readline libsndfile1"
>  RDEPENDS_${PN}-dev = "bluez-hcidump"
>
> +PROVIDES += "virtual/bluez"
> +RPROVIDES_${PN} += "virtual/bluez"
> +
>  PACKAGECONFIG ??= "\
>      ${@base_contains('DISTRO_FEATURES', 'alsa', 'alsa', '', d)}\
>      ${@base_contains('DISTRO_FEATURES', 'pie', 'pie', '', d)}\
> --
> 1.7.9.5
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Lauren Post - March 26, 2014, 5:26 p.m.
Yes, I am working on it with all the feedback for other patches.  I missed it on last batch but before I send it going to add all the other changes in v2 version.

I'll review with Otavio before I resubmit and test with both bluez4 and bluez5.

Lauren

-----Original Message-----
From: Burton, Ross [mailto:ross.burton@intel.com] 
Sent: Wednesday, March 26, 2014 12:04 PM
To: Post Lauren-RAA013
Cc: OE-core
Subject: Re: [OE-core] [PATCH 01/11] bluez4: Add virtual/bluez as provider

Surely there should also be a patch to do the same for bluez5 so the switch can be compile-tested?

Ross

Patch

diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc
index 0827005..dce9642 100644
--- a/meta/recipes-connectivity/bluez/bluez4.inc
+++ b/meta/recipes-connectivity/bluez/bluez4.inc
@@ -7,9 +7,13 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
                     file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
                     file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \
                     file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191"
+
 DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck readline libsndfile1"
 RDEPENDS_${PN}-dev = "bluez-hcidump"
 
+PROVIDES += "virtual/bluez"
+RPROVIDES_${PN} += "virtual/bluez"
+
 PACKAGECONFIG ??= "\
     ${@base_contains('DISTRO_FEATURES', 'alsa', 'alsa', '', d)}\
     ${@base_contains('DISTRO_FEATURES', 'pie', 'pie', '', d)}\