Patchwork [v2,2/2] ppp-2.4.5: remove `DP = "-1"`

login
register
mail settings
Submitter Steffen Sledz
Date July 4, 2011, 8:31 a.m.
Message ID <1309768279-4797-2-git-send-email-sledz@dresearch-fe.de>
Download mbox | patch
Permalink /patch/6929/
State Accepted
Headers show

Comments

Steffen Sledz - July 4, 2011, 8:31 a.m.
Oe-core is using 2.4.5 and it works OK there.

Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
---
 recipes/ppp/ppp_2.4.5.bb |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
Paul Menzel - July 4, 2011, 8:54 a.m.
Am Montag, den 04.07.2011, 10:31 +0200 schrieb Steffen Sledz:
> Oe-core is using 2.4.5 and it works OK there.
> 
> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
> ---
>  recipes/ppp/ppp_2.4.5.bb |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb
> index 883b695..faab816 100644
> --- a/recipes/ppp/ppp_2.4.5.bb
> +++ b/recipes/ppp/ppp_2.4.5.bb
> @@ -3,9 +3,7 @@ DESCRIPTION = "Point-to-Point Protocol (PPP) daemon"
>  HOMEPAGE = "http://samba.org/ppp/"
>  DEPENDS = "libpcap"
>  LICENSE = "BSD GPLv2"
> -PR = "r2"
> -# Not well tested
> -DEFAULT_PREFERENCE = "-1"
> +PR = "r3"

Is a bump of `PR` needed? The package content does not change, does it?
 
>  PARALLEL_MAKE = ""

Is the build still failing when doing a parallel build?

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul
Steffen Sledz - July 4, 2011, 9:09 a.m.
On 04.07.2011 10:54, Paul Menzel wrote:
> Am Montag, den 04.07.2011, 10:31 +0200 schrieb Steffen Sledz:
>> Oe-core is using 2.4.5 and it works OK there.
>> 
>> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de> --- recipes/ppp/ppp_2.4.5.bb |    4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
>> 
>> diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb index 883b695..faab816 100644 --- a/recipes/ppp/ppp_2.4.5.bb +++ b/recipes/ppp/ppp_2.4.5.bb @@ -3,9 +3,7 @@ DESCRIPTION = "Point-to-Point Protocol (PPP) daemon" HOMEPAGE = "http://samba.org/ppp/" DEPENDS = "libpcap" LICENSE = "BSD GPLv2" -PR = "r2" -# Not well tested -DEFAULT_PREFERENCE = "-1" +PR = "r3"
> 
> Is a bump of `PR` needed? The package content does not change, does it?

Not really. I'll revert that before pushing.

>> PARALLEL_MAKE = ""
> 
> Is the build still failing when doing a parallel build?

No idea. And not enough time to check it. Sorry.

Steffen
Steffen Sledz - July 4, 2011, 10:58 a.m.
On 04.07.2011 11:09, Steffen Sledz wrote:
> On 04.07.2011 10:54, Paul Menzel wrote:
>> Am Montag, den 04.07.2011, 10:31 +0200 schrieb Steffen Sledz:
>>> Oe-core is using 2.4.5 and it works OK there.
>>>
>>> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de> --- recipes/ppp/ppp_2.4.5.bb |    4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb index 883b695..faab816 100644 --- a/recipes/ppp/ppp_2.4.5.bb +++ b/recipes/ppp/ppp_2.4.5.bb @@ -3,9 +3,7 @@ DESCRIPTION = "Point-to-Point Protocol (PPP) daemon" HOMEPAGE = "http://samba.org/ppp/" DEPENDS = "libpcap" LICENSE = "BSD GPLv2" -PR = "r2" -# Not well tested -DEFAULT_PREFERENCE = "-1" +PR = "r3"
>>
>> Is a bump of `PR` needed? The package content does not change, does it?
> 
> Not really. I'll revert that before pushing.

pushed

Patch

diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb
index 883b695..faab816 100644
--- a/recipes/ppp/ppp_2.4.5.bb
+++ b/recipes/ppp/ppp_2.4.5.bb
@@ -3,9 +3,7 @@  DESCRIPTION = "Point-to-Point Protocol (PPP) daemon"
 HOMEPAGE = "http://samba.org/ppp/"
 DEPENDS = "libpcap"
 LICENSE = "BSD GPLv2"
-PR = "r2"
-# Not well tested
-DEFAULT_PREFERENCE = "-1"
+PR = "r3"
 
 PARALLEL_MAKE = ""