Patchwork [1/1] libsoup-2.4: upgrade to 2.45.92

login
register
mail settings
Submitter Hongxu Jia
Date March 24, 2014, 7:40 a.m.
Message ID <9c06686dc4ccc2576bd8a171ed685ab00eecf84c.1395646642.git.hongxu.jia@windriver.com>
Download mbox | patch
Permalink /patch/69041/
State New
Headers show

Comments

Hongxu Jia - March 24, 2014, 7:40 a.m.
There was a error about mips-gcc optimization while building
libsoup-2.4 2.45.3 with DEBUG_OPTIMIZATION enabled, the 2.45.92
have fixed this issue.

[YOCTO #5512]
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 .../libsoup/{libsoup-2.4_2.45.3.bb => libsoup-2.4_2.45.92.bb}         | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
 rename meta/recipes-support/libsoup/{libsoup-2.4_2.45.3.bb => libsoup-2.4_2.45.92.bb} (85%)
Hongxu Jia - March 24, 2014, 7:57 a.m.
On 03/24/2014 03:40 PM, Hongxu Jia wrote:
> There was a error about mips-gcc optimization while building
> libsoup-2.4 2.45.3 with DEBUG_OPTIMIZATION enabled, the 2.45.92
> have fixed this issue.

Update the comments to make a clarity.

libsoup-2.4: upgrade to 2.45.92

There was an error about mips-gcc optimization while compiling
libsoup-2.4 2.45.3 with DEBUG_OPTIMIZATION enabled.

The test code of libsoup-2.4 2.45.3 triggered gcc assert which located
in gcc/dwarf2out.c:20810:
...
20806       gcc_assert (prev
20807                   && (CALL_P (prev)
20808                       || (NONJUMP_INSN_P (prev)
20809                           && GET_CODE (PATTERN (prev)) == SEQUENCE
20810                           && CALL_P (XVECEXP (PATTERN (prev), 0, 
0)))));
...

The issue test code is the C function 'do_qvalue_tests' located in
tests/header-parsing.c.

The 2.45.92 have refactored the test code and this issue has been fixed.

[YOCTO #5512]

//Hongxu
> [YOCTO #5512]
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>   .../libsoup/{libsoup-2.4_2.45.3.bb => libsoup-2.4_2.45.92.bb}         | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>   rename meta/recipes-support/libsoup/{libsoup-2.4_2.45.3.bb => libsoup-2.4_2.45.92.bb} (85%)
>
> diff --git a/meta/recipes-support/libsoup/libsoup-2.4_2.45.3.bb b/meta/recipes-support/libsoup/libsoup-2.4_2.45.92.bb
> similarity index 85%
> rename from meta/recipes-support/libsoup/libsoup-2.4_2.45.3.bb
> rename to meta/recipes-support/libsoup/libsoup-2.4_2.45.92.bb
> index b1199d8..f3a2617 100644
> --- a/meta/recipes-support/libsoup/libsoup-2.4_2.45.3.bb
> +++ b/meta/recipes-support/libsoup/libsoup-2.4_2.45.92.bb
> @@ -17,8 +17,8 @@ PACKAGECONFIG[gnome] = "--with-gnome,--without-gnome"
>   SHRT_VER = "${@bb.data.getVar('PV',d,1).split('.')[0]}.${@bb.data.getVar('PV',d,1).split('.')[1]}"
>   SRC_URI = "${GNOME_MIRROR}/libsoup/${SHRT_VER}/libsoup-${PV}.tar.xz"
>   
> -SRC_URI[md5sum] = "fe7ec04784c6b97c5f8ea963c8542f59"
> -SRC_URI[sha256sum] = "6ac317b931efd2cff9cdea7122987acb3ecb0c32564a9441ba72e5cce021aa12"
> +SRC_URI[md5sum] = "d72623f2baac7f58d1295c0b6ae7cd35"
> +SRC_URI[sha256sum] = "d34f4b41eec99ecf082783f842a29e712e7a78e83f4cd2a060b9de64377d21d8"
>   
>   S = "${WORKDIR}/libsoup-${PV}"
>
Ross Burton - March 24, 2014, 8:09 a.m.
On 24 March 2014 07:40, Hongxu Jia <hongxu.jia@windriver.com> wrote:
> There was a error about mips-gcc optimization while building
> libsoup-2.4 2.45.3 with DEBUG_OPTIMIZATION enabled, the 2.45.92
> have fixed this issue.

.92 means "beta release" in GNOME versioning, so not only is this a
new upstream release (when we've frozen) but it's also not a stable
release.  Please backport the patch instead of upgrading.

Ross
Hongxu Jia - March 24, 2014, 8:15 a.m.
On 03/24/2014 04:09 PM, Burton, Ross wrote:
> On 24 March 2014 07:40, Hongxu Jia <hongxu.jia@windriver.com> wrote:
>> There was a error about mips-gcc optimization while building
>> libsoup-2.4 2.45.3 with DEBUG_OPTIMIZATION enabled, the 2.45.92
>> have fixed this issue.
> .92 means "beta release" in GNOME versioning, so not only is this a
> new upstream release (when we've frozen) but it's also not a stable
> release.  Please backport the patch instead of upgrading.

OK, I will backport to 2.45.3

//Hongxu

>
> Ross
Ross Burton - March 24, 2014, 9:06 a.m.
On 24 March 2014 07:57, Hongxu Jia <hongxu.jia@windriver.com> wrote:
> There was an error about mips-gcc optimization while compiling
> libsoup-2.4 2.45.3 with DEBUG_OPTIMIZATION enabled.
>
> The test code of libsoup-2.4 2.45.3 triggered gcc assert which located
> in gcc/dwarf2out.c:20810:
> ...
> 20806       gcc_assert (prev
> 20807                   && (CALL_P (prev)
> 20808                       || (NONJUMP_INSN_P (prev)
> 20809                           && GET_CODE (PATTERN (prev)) == SEQUENCE
> 20810                           && CALL_P (XVECEXP (PATTERN (prev), 0,
> 0)))));
> ...

So you've a bug in gcc and a well defined way of replicating it,
presumably you've reported this to gcc as that's the proper fix here?

Ross
Hongxu Jia - March 25, 2014, 4:12 a.m.
On 03/24/2014 05:06 PM, Burton, Ross wrote:
> On 24 March 2014 07:57, Hongxu Jia <hongxu.jia@windriver.com> wrote:
>> There was an error about mips-gcc optimization while compiling
>> libsoup-2.4 2.45.3 with DEBUG_OPTIMIZATION enabled.
>>
>> The test code of libsoup-2.4 2.45.3 triggered gcc assert which located
>> in gcc/dwarf2out.c:20810:
>> ...
>> 20806       gcc_assert (prev
>> 20807                   && (CALL_P (prev)
>> 20808                       || (NONJUMP_INSN_P (prev)
>> 20809                           && GET_CODE (PATTERN (prev)) == SEQUENCE
>> 20810                           && CALL_P (XVECEXP (PATTERN (prev), 0,
>> 0)))));
>> ...
> So you've a bug in gcc and a well defined way of replicating it,
> presumably you've reported this to gcc as that's the proper fix here?

Yes, file a bug in gcc:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=6034

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60643

//Hongxu

> Ross

Patch

diff --git a/meta/recipes-support/libsoup/libsoup-2.4_2.45.3.bb b/meta/recipes-support/libsoup/libsoup-2.4_2.45.92.bb
similarity index 85%
rename from meta/recipes-support/libsoup/libsoup-2.4_2.45.3.bb
rename to meta/recipes-support/libsoup/libsoup-2.4_2.45.92.bb
index b1199d8..f3a2617 100644
--- a/meta/recipes-support/libsoup/libsoup-2.4_2.45.3.bb
+++ b/meta/recipes-support/libsoup/libsoup-2.4_2.45.92.bb
@@ -17,8 +17,8 @@  PACKAGECONFIG[gnome] = "--with-gnome,--without-gnome"
 SHRT_VER = "${@bb.data.getVar('PV',d,1).split('.')[0]}.${@bb.data.getVar('PV',d,1).split('.')[1]}"
 SRC_URI = "${GNOME_MIRROR}/libsoup/${SHRT_VER}/libsoup-${PV}.tar.xz"
 
-SRC_URI[md5sum] = "fe7ec04784c6b97c5f8ea963c8542f59"
-SRC_URI[sha256sum] = "6ac317b931efd2cff9cdea7122987acb3ecb0c32564a9441ba72e5cce021aa12"
+SRC_URI[md5sum] = "d72623f2baac7f58d1295c0b6ae7cd35"
+SRC_URI[sha256sum] = "d34f4b41eec99ecf082783f842a29e712e7a78e83f4cd2a060b9de64377d21d8"
 
 S = "${WORKDIR}/libsoup-${PV}"