Patchwork [2/2] gtk-engines: move engine schemas to a dedicated package

login
register
mail settings
Submitter Ross Burton
Date March 21, 2014, 6:21 p.m.
Message ID <1395426119-3011-2-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/69017/
State New
Headers show

Comments

Ross Burton - March 21, 2014, 6:21 p.m.
The GTK+ engine schemas are not insignicant in size but also mostly useless.
Put them in a sub-package instead of PN so they only get installed when
explicitly required.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-gnome/gtk-engines/gtk-engines_2.20.2.bb |    3 +++
 1 file changed, 3 insertions(+)
Otavio Salvador - March 25, 2014, 12:27 p.m.
On Fri, Mar 21, 2014 at 3:21 PM, Ross Burton <ross.burton@intel.com> wrote:
> The GTK+ engine schemas are not insignicant in size but also mostly useless.
> Put them in a sub-package instead of PN so they only get installed when
> explicitly required.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>

Isn't it breaking runtime update? People with a running system which
updates it using package feeds are going to get it removed. Am I
missing something?
Ross Burton - March 25, 2014, 12:59 p.m.
On 25 March 2014 12:27, Otavio Salvador <otavio@ossystems.com.br> wrote:
> On Fri, Mar 21, 2014 at 3:21 PM, Ross Burton <ross.burton@intel.com> wrote:
>> The GTK+ engine schemas are not insignicant in size but also mostly useless.
>> Put them in a sub-package instead of PN so they only get installed when
>> explicitly required.
>>
>> Signed-off-by: Ross Burton <ross.burton@intel.com>
>
> Isn't it breaking runtime update? People with a running system which
> updates it using package feeds are going to get it removed. Am I
> missing something?

There is the possibility of a migration path but honestly, nothing is
using those files and I'd be surprised if they were installed by
anyone.

I guess there should be a replaces/conflicts to ensure that PN-schemas
doesn't clash with PN in upgrades.

Ross

Patch

diff --git a/meta/recipes-gnome/gtk-engines/gtk-engines_2.20.2.bb b/meta/recipes-gnome/gtk-engines/gtk-engines_2.20.2.bb
index 5255f00..33b6afe 100644
--- a/meta/recipes-gnome/gtk-engines/gtk-engines_2.20.2.bb
+++ b/meta/recipes-gnome/gtk-engines/gtk-engines_2.20.2.bb
@@ -10,6 +10,7 @@  DEPENDS = "intltool-native gtk+"
 
 PR = "r3"
 
+PACKAGES += "${PN}-schemas"
 PACKAGES_DYNAMIC += "^gtk-engine-.* ^gtk-theme-.*"
 
 RDEPENDS_gtk-theme-redmond = "gtk-engine-redmond95"
@@ -21,8 +22,10 @@  RDEPENDS_gtk-theme-thinice = "gtk-engine-thinice"
 RDEPENDS_gtk-theme-industrial = "gtk-engine-industrial"
 RDEPENDS_gtk-theme-clearlooks = "gtk-engine-clearlooks"
 
+FILES_${PN} = ""
 FILES_${PN}-dev += "${libdir}/gtk-2.0/*/engines/*.la"
 FILES_${PN}-dbg += "${libdir}/gtk-2.0/*/engines/.debug"
+FILES_${PN}-schemas = "${datadir}/gtk-engines/*.xml"
 
 CFLAGS_prepend = "-DHAVE_ANIMATION "