Patchwork [meta-filesystems] Add fusermount to fuse by default

login
register
mail settings
Submitter George Nita
Date March 21, 2014, 7:23 a.m.
Message ID <1395386596-56931-1-git-send-email-george.nita@enea.com>
Download mbox | patch
Permalink /patch/68995/
State New, archived
Headers show

Comments

George Nita - March 21, 2014, 7:23 a.m.
Without fusermount the '/etc/init.d/fuse status' command exits with error.
Added fusermount to PACKAGES list and ensured it gets installed.

Signed-off-by: George Nita <george.nita@enea.com>
---
 meta-filesystems/recipes-support/fuse/fuse_2.9.3.bb |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Koen Kooi - March 21, 2014, 9:07 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

George Nita schreef op 21-03-14 08:23:
> Without fusermount the '/etc/init.d/fuse status' command exits with
> error. Added fusermount to PACKAGES list and ensured it gets installed.

How are you ensuring it gets installed? You only added a new packages, you
haven't updated any R* variable to take the new package into account.

> 
> Signed-off-by: George Nita <george.nita@enea.com> --- 
> meta-filesystems/recipes-support/fuse/fuse_2.9.3.bb |    5 ++++- 1 file
> changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-filesystems/recipes-support/fuse/fuse_2.9.3.bb
> b/meta-filesystems/recipes-support/fuse/fuse_2.9.3.bb index
> a761932..1e8f958 100644 ---
> a/meta-filesystems/recipes-support/fuse/fuse_2.9.3.bb +++
> b/meta-filesystems/recipes-support/fuse/fuse_2.9.3.bb @@ -21,7 +21,8 @@
> inherit autotools pkgconfig
> 
> EXTRA_OECONF = "--disable-kernel-module"
> 
> -PACKAGES =+ "fuse-utils-dbg fuse-utils libulockmgr libulockmgr-dev
> libulockmgr-dbg" +PACKAGES =+ "fuse-utils-dbg fuse-utils libulockmgr
> libulockmgr-dev \ +             libulockmgr-dbg fusermount"
> 
> RRECOMMENDS_${PN} = "kernel-module-fuse"
> 
> @@ -40,4 +41,6 @@ DEBIAN_NOAUTONAME_fuse-utils-dbg = "1"
> 
> do_install_append() { rm -rf ${D}${base_prefix}/dev +    install -d
> ${D}${base_bindir} +    install -m 0755 ${B}/util/fusermount -t
> ${D}${base_bindir} }
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFTLAFsMkyGM64RGpERAj7iAJ9imAv8fVGxLzkGfEY1M3iyyGbnHwCeKtaa
GyHWWpd05haNOE69NMQQLaA=
=XU/E
-----END PGP SIGNATURE-----
George Nita - March 21, 2014, 9:38 a.m.
On 03/21/2014 11:07 AM, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> George Nita schreef op 21-03-14 08:23:
>> Without fusermount the '/etc/init.d/fuse status' command exits with
>> error. Added fusermount to PACKAGES list and ensured it gets installed.
>
> How are you ensuring it gets installed? You only added a new packages, you
> haven't updated any R* variable to take the new package into account.
>
By installing fusermount into ${base_bindir}
>>
>> Signed-off-by: George Nita <george.nita@enea.com> ---
>> meta-filesystems/recipes-support/fuse/fuse_2.9.3.bb |    5 ++++- 1 file
>> changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-filesystems/recipes-support/fuse/fuse_2.9.3.bb
>> b/meta-filesystems/recipes-support/fuse/fuse_2.9.3.bb index
>> a761932..1e8f958 100644 ---
>> a/meta-filesystems/recipes-support/fuse/fuse_2.9.3.bb +++
>> b/meta-filesystems/recipes-support/fuse/fuse_2.9.3.bb @@ -21,7 +21,8 @@
>> inherit autotools pkgconfig
>>
>> EXTRA_OECONF = "--disable-kernel-module"
>>
>> -PACKAGES =+ "fuse-utils-dbg fuse-utils libulockmgr libulockmgr-dev
>> libulockmgr-dbg" +PACKAGES =+ "fuse-utils-dbg fuse-utils libulockmgr
>> libulockmgr-dev \ +             libulockmgr-dbg fusermount"
>>
>> RRECOMMENDS_${PN} = "kernel-module-fuse"
>>
>> @@ -40,4 +41,6 @@ DEBIAN_NOAUTONAME_fuse-utils-dbg = "1"
>>
>> do_install_append() { rm -rf ${D}${base_prefix}/dev +    install -d
>> ${D}${base_bindir} +    install -m 0755 ${B}/util/fusermount -t
>> ${D}${base_bindir} }
>>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> Comment: GPGTools - http://gpgtools.org
>
> iD8DBQFTLAFsMkyGM64RGpERAj7iAJ9imAv8fVGxLzkGfEY1M3iyyGbnHwCeKtaa
> GyHWWpd05haNOE69NMQQLaA=
> =XU/E
> -----END PGP SIGNATURE-----
>
Koen Kooi - March 21, 2014, 11:15 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

George Nita schreef op 21-03-14 10:38:
> On 03/21/2014 11:07 AM, Koen Kooi wrote: George Nita schreef op 21-03-14
> 08:23:
>>>> Without fusermount the '/etc/init.d/fuse status' command exits
>>>> with error. Added fusermount to PACKAGES list and ensured it gets
>>>> installed.
> 
> How are you ensuring it gets installed? You only added a new packages,
> you haven't updated any R* variable to take the new package into
> account.
> 
>> By installing fusermount into ${base_bindir}

So what you're saying is that /bin/fusermount ends up in 'fuse-utils' and
you're just adding 'fusermount' to PACKAGES because it looks cool? I get
that you want to have /bin/fusermount installed on your system, but I don't
get what your patch is doing.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFTLB9GMkyGM64RGpERAn6/AJ4oqRW3F4Y+bXvOuAg9sUQEZGIGJgCcCeSj
BDhkv5mcw4UZjB56C5zJmso=
=a1Ip
-----END PGP SIGNATURE-----
George Nita - March 21, 2014, 4:49 p.m.
On 03/21/2014 01:15 PM, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> George Nita schreef op 21-03-14 10:38:
>> On 03/21/2014 11:07 AM, Koen Kooi wrote: George Nita schreef op 21-03-14
>> 08:23:
>>>>> Without fusermount the '/etc/init.d/fuse status' command exits
>>>>> with error. Added fusermount to PACKAGES list and ensured it gets
>>>>> installed.
>>
>> How are you ensuring it gets installed? You only added a new packages,
>> you haven't updated any R* variable to take the new package into
>> account.
>>
>>> By installing fusermount into ${base_bindir}
>
> So what you're saying is that /bin/fusermount ends up in 'fuse-utils' and
> you're just adding 'fusermount' to PACKAGES because it looks cool? I get
> that you want to have /bin/fusermount installed on your system, but I don't
> get what your patch is doing.
You're right, no need to add 'fusermount' to PACKAGES.
However, in order to get fusermount in the image root file system:
- add installation lines in code as in my patch or similar
- delete the 2 lines that assign to FILES_fuse-utils and 
FILES_fuse-utils-dbg
- something else (what ?)

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> Comment: GPGTools - http://gpgtools.org
>
> iD8DBQFTLB9GMkyGM64RGpERAn6/AJ4oqRW3F4Y+bXvOuAg9sUQEZGIGJgCcCeSj
> BDhkv5mcw4UZjB56C5zJmso=
> =a1Ip
> -----END PGP SIGNATURE-----
>

Patch

diff --git a/meta-filesystems/recipes-support/fuse/fuse_2.9.3.bb b/meta-filesystems/recipes-support/fuse/fuse_2.9.3.bb
index a761932..1e8f958 100644
--- a/meta-filesystems/recipes-support/fuse/fuse_2.9.3.bb
+++ b/meta-filesystems/recipes-support/fuse/fuse_2.9.3.bb
@@ -21,7 +21,8 @@  inherit autotools pkgconfig
 
 EXTRA_OECONF = "--disable-kernel-module"
 
-PACKAGES =+ "fuse-utils-dbg fuse-utils libulockmgr libulockmgr-dev libulockmgr-dbg"
+PACKAGES =+ "fuse-utils-dbg fuse-utils libulockmgr libulockmgr-dev \
+             libulockmgr-dbg fusermount"
 
 RRECOMMENDS_${PN} = "kernel-module-fuse"
 
@@ -40,4 +41,6 @@  DEBIAN_NOAUTONAME_fuse-utils-dbg = "1"
 
 do_install_append() {
     rm -rf ${D}${base_prefix}/dev
+    install -d ${D}${base_bindir}
+    install -m 0755 ${B}/util/fusermount -t ${D}${base_bindir}
 }