Patchwork [oe-commits] Cristian Iorga : musicpd: upgrade to 0.18.9

login
register
mail settings
Submitter Cristian Iorga
Date March 20, 2014, 6:59 a.m.
Message ID <969F26A8BAB325438E7EB80D3C3134FB16D65A80@IRSMSX105.ger.corp.intel.com>
Download mbox | patch
Permalink /patch/68917/
State Not Applicable, archived
Headers show

Comments

Cristian Iorga - March 20, 2014, 6:59 a.m.
Hi Martin,

Errr, what exactly is going on here?
I have submitted this patch in a different form, with more content and more comments.
That's one thing.
Another thing would be that even if you signed my patch in a modified form, 5 minutes later, you signed another musicpd patch, going backwards from my version.
Quote:
" Module: meta-openembedded.git
Branch: master-next
Commit: dde222cef9bb8ef20d139ab58760b27c4d45c93a
URL:    http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=dde222cef9bb8ef20d139ab58760b27c4d45c93a

Author: Stephen Arnold <stephen.arnold42@gmail.com>
Date:   Sun Mar 16 17:52:47 2014 -0700

musicpd/mpd: bump to current upstream stable

Bump music player daemon to the latest upstream stable release.
Same as previous 0.18.4 recipe with trivial updates.

Signed-off-by: Stephen Arnold <stephen.arnold42@gmail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>"

The only thing, let's say improved, from my patch to Stephen's patch  would be the site URL.

So which one is it?
Still, yet, no patch got into the master, while I am stuck with a bug that I have not caused and, still, seems that I am responsible for it.

Also, mpd v0.18.8 will still not fix the crash with libvorbis upgrade..

I must say that from my point of view this is getting counterproductive...

Regards,
Cristian Iorga
YP
Intel Corporation


-----Original Message-----
From: openembedded-commits-bounces@lists.openembedded.org [mailto:openembedded-commits-bounces@lists.openembedded.org] On Behalf Of git@git.openembedded.org
Sent: Tuesday, March 18, 2014 9:17 PM
To: openembedded-commits@lists.openembedded.org
Subject: [oe-commits] Cristian Iorga : musicpd: upgrade to 0.18.9

Module: meta-openembedded.git
Branch: master-next
Commit: 2e1305783023e6b0869e8ea12db25c53b803f545
URL:    http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=2e1305783023e6b0869e8ea12db25c53b803f545

Author: Cristian Iorga <cristian.iorga@intel.com>
Date:   Mon Mar 17 11:05:17 2014 +0200

musicpd: upgrade to 0.18.9

* Upgrade fixes a crash with libvorbis 1.3.4;

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>

---

 .../recipes-multimedia/musicpd/{mpd_0.18.8.bb => mpd_0.18.9.bb}       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Martin Jansa - March 20, 2014, 10:55 a.m.
On Thu, Mar 20, 2014 at 06:59:13AM +0000, Iorga, Cristian wrote:
> Hi Martin,
> 
> Errr, what exactly is going on here?
> I have submitted this patch in a different form, with more content and more comments.

Stephen submitted upgrade from 0.18.4 to 0.18.8 before you and it was applied first.

So what was left from your patch after rebase was upgrade from 0.18.8 to
0.18.9.

If you don't agree I will merge just Stephen's patch and you can send
new one after rebasing it yourself.

Thanks

> That's one thing.
> Another thing would be that even if you signed my patch in a modified form, 5 minutes later, you signed another musicpd patch, going backwards from my version.
> Quote:
> " Module: meta-openembedded.git
> Branch: master-next
> Commit: dde222cef9bb8ef20d139ab58760b27c4d45c93a
> URL:    http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=dde222cef9bb8ef20d139ab58760b27c4d45c93a
> 
> Author: Stephen Arnold <stephen.arnold42@gmail.com>
> Date:   Sun Mar 16 17:52:47 2014 -0700
> 
> musicpd/mpd: bump to current upstream stable
> 
> Bump music player daemon to the latest upstream stable release.
> Same as previous 0.18.4 recipe with trivial updates.
> 
> Signed-off-by: Stephen Arnold <stephen.arnold42@gmail.com>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>"
> 
> The only thing, let's say improved, from my patch to Stephen's patch  would be the site URL.
> 
> So which one is it?
> Still, yet, no patch got into the master, while I am stuck with a bug that I have not caused and, still, seems that I am responsible for it.
> 
> Also, mpd v0.18.8 will still not fix the crash with libvorbis upgrade..
> 
> I must say that from my point of view this is getting counterproductive...
> 
> Regards,
> Cristian Iorga
> YP
> Intel Corporation
> 
> 
> -----Original Message-----
> From: openembedded-commits-bounces@lists.openembedded.org [mailto:openembedded-commits-bounces@lists.openembedded.org] On Behalf Of git@git.openembedded.org
> Sent: Tuesday, March 18, 2014 9:17 PM
> To: openembedded-commits@lists.openembedded.org
> Subject: [oe-commits] Cristian Iorga : musicpd: upgrade to 0.18.9
> 
> Module: meta-openembedded.git
> Branch: master-next
> Commit: 2e1305783023e6b0869e8ea12db25c53b803f545
> URL:    http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=2e1305783023e6b0869e8ea12db25c53b803f545
> 
> Author: Cristian Iorga <cristian.iorga@intel.com>
> Date:   Mon Mar 17 11:05:17 2014 +0200
> 
> musicpd: upgrade to 0.18.9
> 
> * Upgrade fixes a crash with libvorbis 1.3.4;
> 
> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> 
> ---
> 
>  .../recipes-multimedia/musicpd/{mpd_0.18.8.bb => mpd_0.18.9.bb}       | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.8.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.9.bb
> similarity index 93%
> rename from meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.8.bb
> rename to meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.9.bb
> index b6882af..c3bb581 100644
> --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.8.bb
> +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.9.bb
> @@ -10,8 +10,8 @@ SRC_URI = " \
>      file://mpd.conf.in \
>  "
>  
> -SRC_URI[md5sum] = "7bbe1caf5abe404dc985ca4f44984b1f"
> -SRC_URI[sha256sum] = "5366378e548fb77996cc33b0e15165ddd84f1e496bdd04616bd593aecdc26450"
> +SRC_URI[md5sum] = "0e5156a831d4302d2032998bcfd5c36f"
> +SRC_URI[sha256sum] = "0d4d3e6977cb607419abbb14c63d1e2b982acb84cd2be5346f19de5f699a68de"
>  
>  inherit autotools useradd systemd
>  
> 
> -- 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Cristian Iorga - March 20, 2014, 11:27 a.m.
It's ok in that case.

-----Original Message-----
From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Martin Jansa
Sent: Thursday, March 20, 2014 12:55 PM
To: openembedded-devel@lists.openembedded.org
Cc: openembedded-commits@lists.openembedded.org
Subject: Re: [oe] [oe-commits] Cristian Iorga : musicpd: upgrade to 0.18.9

On Thu, Mar 20, 2014 at 06:59:13AM +0000, Iorga, Cristian wrote:
> Hi Martin,
> 
> Errr, what exactly is going on here?
> I have submitted this patch in a different form, with more content and more comments.

Stephen submitted upgrade from 0.18.4 to 0.18.8 before you and it was applied first.

So what was left from your patch after rebase was upgrade from 0.18.8 to 0.18.9.

If you don't agree I will merge just Stephen's patch and you can send new one after rebasing it yourself.

Thanks

> That's one thing.
> Another thing would be that even if you signed my patch in a modified form, 5 minutes later, you signed another musicpd patch, going backwards from my version.
> Quote:
> " Module: meta-openembedded.git
> Branch: master-next
> Commit: dde222cef9bb8ef20d139ab58760b27c4d45c93a
> URL:    http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=dde222cef9bb8ef20d139ab58760b27c4d45c93a
> 
> Author: Stephen Arnold <stephen.arnold42@gmail.com>
> Date:   Sun Mar 16 17:52:47 2014 -0700
> 
> musicpd/mpd: bump to current upstream stable
> 
> Bump music player daemon to the latest upstream stable release.
> Same as previous 0.18.4 recipe with trivial updates.
> 
> Signed-off-by: Stephen Arnold <stephen.arnold42@gmail.com>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>"
> 
> The only thing, let's say improved, from my patch to Stephen's patch  would be the site URL.
> 
> So which one is it?
> Still, yet, no patch got into the master, while I am stuck with a bug that I have not caused and, still, seems that I am responsible for it.
> 
> Also, mpd v0.18.8 will still not fix the crash with libvorbis upgrade..
> 
> I must say that from my point of view this is getting counterproductive...
> 
> Regards,
> Cristian Iorga
> YP
> Intel Corporation
> 
> 
> -----Original Message-----
> From: openembedded-commits-bounces@lists.openembedded.org 
> [mailto:openembedded-commits-bounces@lists.openembedded.org] On Behalf 
> Of git@git.openembedded.org
> Sent: Tuesday, March 18, 2014 9:17 PM
> To: openembedded-commits@lists.openembedded.org
> Subject: [oe-commits] Cristian Iorga : musicpd: upgrade to 0.18.9
> 
> Module: meta-openembedded.git
> Branch: master-next
> Commit: 2e1305783023e6b0869e8ea12db25c53b803f545
> URL:    http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=2e1305783023e6b0869e8ea12db25c53b803f545
> 
> Author: Cristian Iorga <cristian.iorga@intel.com>
> Date:   Mon Mar 17 11:05:17 2014 +0200
> 
> musicpd: upgrade to 0.18.9
> 
> * Upgrade fixes a crash with libvorbis 1.3.4;
> 
> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> 
> ---
> 
>  .../recipes-multimedia/musicpd/{mpd_0.18.8.bb => mpd_0.18.9.bb}       | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.8.bb 
> b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.9.bb
> similarity index 93%
> rename from meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.8.bb
> rename to meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.9.bb
> index b6882af..c3bb581 100644
> --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.8.bb
> +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.9.bb
> @@ -10,8 +10,8 @@ SRC_URI = " \
>      file://mpd.conf.in \
>  "
>  
> -SRC_URI[md5sum] = "7bbe1caf5abe404dc985ca4f44984b1f"
> -SRC_URI[sha256sum] = "5366378e548fb77996cc33b0e15165ddd84f1e496bdd04616bd593aecdc26450"
> +SRC_URI[md5sum] = "0e5156a831d4302d2032998bcfd5c36f"
> +SRC_URI[sha256sum] = "0d4d3e6977cb607419abbb14c63d1e2b982acb84cd2be5346f19de5f699a68de"
>  
>  inherit autotools useradd systemd
>  
> 
> --
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
stephen.arnold42 - March 21, 2014, 2:42 p.m.
I had that patch in my local tree for a few weeks and didn't check (again)
upstream for another release.  Just good timing on my part, I guess...

Steve


On Thu, Mar 20, 2014 at 4:27 AM, Iorga, Cristian
<cristian.iorga@intel.com>wrote:

> It's ok in that case.
>
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:
> openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Martin
> Jansa
> Sent: Thursday, March 20, 2014 12:55 PM
> To: openembedded-devel@lists.openembedded.org
> Cc: openembedded-commits@lists.openembedded.org
> Subject: Re: [oe] [oe-commits] Cristian Iorga : musicpd: upgrade to 0.18.9
>
> On Thu, Mar 20, 2014 at 06:59:13AM +0000, Iorga, Cristian wrote:
> > Hi Martin,
> >
> > Errr, what exactly is going on here?
> > I have submitted this patch in a different form, with more content and
> more comments.
>
> Stephen submitted upgrade from 0.18.4 to 0.18.8 before you and it was
> applied first.
>
> So what was left from your patch after rebase was upgrade from 0.18.8 to
> 0.18.9.
>
> If you don't agree I will merge just Stephen's patch and you can send new
> one after rebasing it yourself.
>
> Thanks
>
> > That's one thing.
> > Another thing would be that even if you signed my patch in a modified
> form, 5 minutes later, you signed another musicpd patch, going backwards
> from my version.
> > Quote:
> > " Module: meta-openembedded.git
> > Branch: master-next
> > Commit: dde222cef9bb8ef20d139ab58760b27c4d45c93a
> > URL:
> http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=dde222cef9bb8ef20d139ab58760b27c4d45c93a
> >
> > Author: Stephen Arnold <stephen.arnold42@gmail.com>
> > Date:   Sun Mar 16 17:52:47 2014 -0700
> >
> > musicpd/mpd: bump to current upstream stable
> >
> > Bump music player daemon to the latest upstream stable release.
> > Same as previous 0.18.4 recipe with trivial updates.
> >
> > Signed-off-by: Stephen Arnold <stephen.arnold42@gmail.com>
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>"
> >
> > The only thing, let's say improved, from my patch to Stephen's patch
>  would be the site URL.
> >
> > So which one is it?
> > Still, yet, no patch got into the master, while I am stuck with a bug
> that I have not caused and, still, seems that I am responsible for it.
> >
> > Also, mpd v0.18.8 will still not fix the crash with libvorbis upgrade..
> >
> > I must say that from my point of view this is getting
> counterproductive...
> >
> > Regards,
> > Cristian Iorga
> > YP
> > Intel Corporation
> >
> >
> > -----Original Message-----
> > From: openembedded-commits-bounces@lists.openembedded.org
> > [mailto:openembedded-commits-bounces@lists.openembedded.org] On Behalf
> > Of git@git.openembedded.org
> > Sent: Tuesday, March 18, 2014 9:17 PM
> > To: openembedded-commits@lists.openembedded.org
> > Subject: [oe-commits] Cristian Iorga : musicpd: upgrade to 0.18.9
> >
> > Module: meta-openembedded.git
> > Branch: master-next
> > Commit: 2e1305783023e6b0869e8ea12db25c53b803f545
> > URL:
> http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=2e1305783023e6b0869e8ea12db25c53b803f545
> >
> > Author: Cristian Iorga <cristian.iorga@intel.com>
> > Date:   Mon Mar 17 11:05:17 2014 +0200
> >
> > musicpd: upgrade to 0.18.9
> >
> > * Upgrade fixes a crash with libvorbis 1.3.4;
> >
> > Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> >
> > ---
> >
> >  .../recipes-multimedia/musicpd/{mpd_0.18.8.bb => mpd_0.18.9.bb}
> | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.8.bb
> > b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.9.bb
> > similarity index 93%
> > rename from meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.8.bb
> > rename to meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.9.bb
> > index b6882af..c3bb581 100644
> > --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.8.bb
> > +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.9.bb
> > @@ -10,8 +10,8 @@ SRC_URI = " \
> >      file://mpd.conf.in \
> >  "
> >
> > -SRC_URI[md5sum] = "7bbe1caf5abe404dc985ca4f44984b1f"
> > -SRC_URI[sha256sum] =
> "5366378e548fb77996cc33b0e15165ddd84f1e496bdd04616bd593aecdc26450"
> > +SRC_URI[md5sum] = "0e5156a831d4302d2032998bcfd5c36f"
> > +SRC_URI[sha256sum] =
> "0d4d3e6977cb607419abbb14c63d1e2b982acb84cd2be5346f19de5f699a68de"
> >
> >  inherit autotools useradd systemd
> >
> >
> > --
> > _______________________________________________
> > Openembedded-commits mailing list
> > Openembedded-commits@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-commits
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Patch

diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.8.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.9.bb
similarity index 93%
rename from meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.8.bb
rename to meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.9.bb
index b6882af..c3bb581 100644
--- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.8.bb
+++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.18.9.bb
@@ -10,8 +10,8 @@  SRC_URI = " \
     file://mpd.conf.in \
 "
 
-SRC_URI[md5sum] = "7bbe1caf5abe404dc985ca4f44984b1f"
-SRC_URI[sha256sum] = "5366378e548fb77996cc33b0e15165ddd84f1e496bdd04616bd593aecdc26450"
+SRC_URI[md5sum] = "0e5156a831d4302d2032998bcfd5c36f"
+SRC_URI[sha256sum] = "0d4d3e6977cb607419abbb14c63d1e2b982acb84cd2be5346f19de5f699a68de"
 
 inherit autotools useradd systemd