Patchwork [V3,1/1] dbus: fix a hard dependency about dbus-ptest

login
register
mail settings
Submitter Chong.Lu@windriver.com
Date March 19, 2014, 2 a.m.
Message ID <3e91ee5bf0390d700dd57ed89b1dba1434e3f17c.1395194072.git.Chong.Lu@windriver.com>
Download mbox | patch
Permalink /patch/68863/
State New
Headers show

Comments

Chong.Lu@windriver.com - March 19, 2014, 2 a.m.
If image contains dbus and ptest is in DISTRO_FEATURES, dbus-ptest package
is installed, regardless of whether ptest-pkgs is in IMAGE_FEATURES. This
issue will increase size for most small images.
This patch fixes this problem.

[YOCTO #5702]

Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
---
 meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} | 0
 meta/recipes-core/dbus/dbus.inc                                      | 4 +++-
 2 files changed, 3 insertions(+), 1 deletion(-)
 rename meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} (100%)
Ross Burton - March 19, 2014, 11:59 a.m.
On 19 March 2014 02:00, Chong Lu <Chong.Lu@windriver.com> wrote:
> If image contains dbus and ptest is in DISTRO_FEATURES, dbus-ptest package
> is installed, regardless of whether ptest-pkgs is in IMAGE_FEATURES. This
> issue will increase size for most small images.
> This patch fixes this problem.

Reviewed-by: Ross Burton <ross.burton@intel.com>

Ross
Chong.Lu@windriver.com - April 1, 2014, 1:20 a.m.
Ping

On 03/19/2014 07:59 PM, Burton, Ross wrote:
> On 19 March 2014 02:00, Chong Lu <Chong.Lu@windriver.com> wrote:
>> If image contains dbus and ptest is in DISTRO_FEATURES, dbus-ptest package
>> is installed, regardless of whether ptest-pkgs is in IMAGE_FEATURES. This
>> issue will increase size for most small images.
>> This patch fixes this problem.
> Reviewed-by: Ross Burton <ross.burton@intel.com>
>
> Ross
>
Saul Wold - April 3, 2014, 8:31 p.m.
On 03/18/2014 07:00 PM, Chong Lu wrote:
> If image contains dbus and ptest is in DISTRO_FEATURES, dbus-ptest package
> is installed, regardless of whether ptest-pkgs is in IMAGE_FEATURES. This
> issue will increase size for most small images.
> This patch fixes this problem.
>
> [YOCTO #5702]
>
> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> ---
>   meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} | 0
>   meta/recipes-core/dbus/dbus.inc                                      | 4 +++-
>   2 files changed, 3 insertions(+), 1 deletion(-)
>   rename meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => dbus-test_1.6.18.bb} (100%)
>
> diff --git a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb b/meta/recipes-core/dbus/dbus-test_1.6.18.bb
> similarity index 100%
> rename from meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
> rename to meta/recipes-core/dbus/dbus-test_1.6.18.bb
> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
> index 677ff78..6059e7c 100644
> --- a/meta/recipes-core/dbus/dbus.inc
> +++ b/meta/recipes-core/dbus/dbus.inc
> @@ -6,9 +6,11 @@ LICENSE = "AFL-2 | GPLv2+"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
>                       file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a974538bb3c"
>   DEPENDS = "expat virtual/libintl"
> -RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest-ptest', '', d)}"
>   RDEPENDS_dbus_class-native = ""
>   RDEPENDS_dbus_class-nativesdk = ""
> +PACKAGES += "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
> +ALLOW_EMPTY_dbus-ptest = "1"
> +RDEPENDS_dbus-ptest = "dbus-test-ptest"

Seems like this is still causing some issues

> ERROR: Nothing RPROVIDES 'nativesdk-dbus-test-ptest' (but virtual:nativesdk:/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-intel-gpl/build/meta/recipes-core/dbus/dbus_1.6.18.bb RDEPENDS on or otherwise requires it)
> NOTE: Runtime target 'nativesdk-dbus-test-ptest' is unbuildable, removing...
> Missing or unbuildable dependency chain was: ['nativesdk-dbus-test-ptest']
> ERROR: Required build target 'nativesdk-qt4-tools' has no buildable providers.
> Missing or unbuildable dependency chain was: ['nativesdk-qt4-tools', 'nativesdk-dbus', 'nativesdk-dbus-test-ptest']


As seen in this AB Failure: 
http://autobuilder.yoctoproject.org/main/builders/nightly-intel-gpl/builds/30/steps/BuildImages/logs/stdio

Sau!





>
>   SRC_URI = "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
>              file://tmpdir.patch \
>
Chong.Lu@windriver.com - April 4, 2014, 6:09 a.m.
On 04/04/2014 04:31 AM, Saul Wold wrote:
> On 03/18/2014 07:00 PM, Chong Lu wrote:
>> If image contains dbus and ptest is in DISTRO_FEATURES, dbus-ptest 
>> package
>> is installed, regardless of whether ptest-pkgs is in IMAGE_FEATURES. 
>> This
>> issue will increase size for most small images.
>> This patch fixes this problem.
>>
>> [YOCTO #5702]
>>
>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
>> ---
>>   meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => 
>> dbus-test_1.6.18.bb} | 0
>> meta/recipes-core/dbus/dbus.inc | 4 +++-
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>>   rename meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb => 
>> dbus-test_1.6.18.bb} (100%)
>>
>> diff --git a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb 
>> b/meta/recipes-core/dbus/dbus-test_1.6.18.bb
>> similarity index 100%
>> rename from meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
>> rename to meta/recipes-core/dbus/dbus-test_1.6.18.bb
>> diff --git a/meta/recipes-core/dbus/dbus.inc 
>> b/meta/recipes-core/dbus/dbus.inc
>> index 677ff78..6059e7c 100644
>> --- a/meta/recipes-core/dbus/dbus.inc
>> +++ b/meta/recipes-core/dbus/dbus.inc
>> @@ -6,9 +6,11 @@ LICENSE = "AFL-2 | GPLv2+"
>>   LIC_FILES_CHKSUM = 
>> "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
>> file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a974538bb3c"
>>   DEPENDS = "expat virtual/libintl"
>> -RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 
>> 'dbus-ptest-ptest', '', d)}"
>>   RDEPENDS_dbus_class-native = ""
>>   RDEPENDS_dbus_class-nativesdk = ""
>> +PACKAGES += "${@base_contains('DISTRO_FEATURES', 'ptest', 
>> 'dbus-ptest', '', d)}"
>> +ALLOW_EMPTY_dbus-ptest = "1"
>> +RDEPENDS_dbus-ptest = "dbus-test-ptest"
>
> Seems like this is still causing some issues
>
>> ERROR: Nothing RPROVIDES 'nativesdk-dbus-test-ptest' (but 
>> virtual:nativesdk:/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-intel-gpl/build/meta/recipes-core/dbus/dbus_1.6.18.bb 
>> RDEPENDS on or otherwise requires it)
>> NOTE: Runtime target 'nativesdk-dbus-test-ptest' is unbuildable, 
>> removing...
>> Missing or unbuildable dependency chain was: 
>> ['nativesdk-dbus-test-ptest']
>> ERROR: Required build target 'nativesdk-qt4-tools' has no buildable 
>> providers.
>> Missing or unbuildable dependency chain was: ['nativesdk-qt4-tools', 
>> 'nativesdk-dbus', 'nativesdk-dbus-test-ptest']
>
>
> As seen in this AB Failure: 
> http://autobuilder.yoctoproject.org/main/builders/nightly-intel-gpl/builds/30/steps/BuildImages/logs/stdio
>
> Sau!
>
>
Hi Saul,

I built core-image-sato-sdk after applied my patch. I didn't see error.
Can you tell me how to reproduce your building errors?

Best Regards
Chong
>
>
>
>>
>>   SRC_URI = 
>> "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
>>              file://tmpdir.patch \
>>
>
>
Paul Eggleton - April 4, 2014, 10:43 a.m.
On Friday 04 April 2014 14:09:09 Chong Lu wrote:
> On 04/04/2014 04:31 AM, Saul Wold wrote:
> > On 03/18/2014 07:00 PM, Chong Lu wrote:
> >> If image contains dbus and ptest is in DISTRO_FEATURES, dbus-ptest
> >> package
> >> is installed, regardless of whether ptest-pkgs is in IMAGE_FEATURES.
> >> This
> >> issue will increase size for most small images.
> >> This patch fixes this problem.
> >> 
> >> [YOCTO #5702]
> >> 
> >> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> >> ---
> >> 
> >>   meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb =>
> >> 
> >> dbus-test_1.6.18.bb} | 0
> >> meta/recipes-core/dbus/dbus.inc | 4 +++-
> >> 
> >>   2 files changed, 3 insertions(+), 1 deletion(-)
> >>   rename meta/recipes-core/dbus/{dbus-ptest_1.6.18.bb =>
> >> 
> >> dbus-test_1.6.18.bb} (100%)
> >> 
> >> diff --git a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
> >> b/meta/recipes-core/dbus/dbus-test_1.6.18.bb
> >> similarity index 100%
> >> rename from meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
> >> rename to meta/recipes-core/dbus/dbus-test_1.6.18.bb
> >> diff --git a/meta/recipes-core/dbus/dbus.inc
> >> b/meta/recipes-core/dbus/dbus.inc
> >> index 677ff78..6059e7c 100644
> >> --- a/meta/recipes-core/dbus/dbus.inc
> >> +++ b/meta/recipes-core/dbus/dbus.inc
> >> @@ -6,9 +6,11 @@ LICENSE = "AFL-2 | GPLv2+"
> >> 
> >>   LIC_FILES_CHKSUM =
> >> 
> >> "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
> >> file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a97453
> >> 8bb3c">> 
> >>   DEPENDS = "expat virtual/libintl"
> >> 
> >> -RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest',
> >> 'dbus-ptest-ptest', '', d)}"
> >> 
> >>   RDEPENDS_dbus_class-native = ""
> >>   RDEPENDS_dbus_class-nativesdk = ""
> >> 
> >> +PACKAGES += "${@base_contains('DISTRO_FEATURES', 'ptest',
> >> 'dbus-ptest', '', d)}"
> >> +ALLOW_EMPTY_dbus-ptest = "1"
> >> +RDEPENDS_dbus-ptest = "dbus-test-ptest"
> > 
> > Seems like this is still causing some issues
> > 
> >> ERROR: Nothing RPROVIDES 'nativesdk-dbus-test-ptest' (but
> >> virtual:nativesdk:/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-i
> >> ntel-gpl/build/meta/recipes-core/dbus/dbus_1.6.18.bb RDEPENDS on or
> >> otherwise requires it)
> >> NOTE: Runtime target 'nativesdk-dbus-test-ptest' is unbuildable,
> >> removing...
> >> Missing or unbuildable dependency chain was:
> >> ['nativesdk-dbus-test-ptest']
> >> ERROR: Required build target 'nativesdk-qt4-tools' has no buildable
> >> providers.
> >> Missing or unbuildable dependency chain was: ['nativesdk-qt4-tools',
> >> 'nativesdk-dbus', 'nativesdk-dbus-test-ptest']
> > 
> > As seen in this AB Failure:
> > http://autobuilder.yoctoproject.org/main/builders/nightly-intel-gpl/builds
> > /30/steps/BuildImages/logs/stdio
> 
> I built core-image-sato-sdk after applied my patch. I didn't see error.
> Can you tell me how to reproduce your building errors?

You'd need to try to build nativesdk-dbus - "bitbake nativesdk-dbus" should be 
able to reproduce this.

Cheers,
Paul

Patch

diff --git a/meta/recipes-core/dbus/dbus-ptest_1.6.18.bb b/meta/recipes-core/dbus/dbus-test_1.6.18.bb
similarity index 100%
rename from meta/recipes-core/dbus/dbus-ptest_1.6.18.bb
rename to meta/recipes-core/dbus/dbus-test_1.6.18.bb
diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
index 677ff78..6059e7c 100644
--- a/meta/recipes-core/dbus/dbus.inc
+++ b/meta/recipes-core/dbus/dbus.inc
@@ -6,9 +6,11 @@  LICENSE = "AFL-2 | GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=10dded3b58148f3f1fd804b26354af3e \
                     file://dbus/dbus.h;beginline=6;endline=20;md5=7755c9d7abccd5dbd25a6a974538bb3c"
 DEPENDS = "expat virtual/libintl"
-RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest-ptest', '', d)}"
 RDEPENDS_dbus_class-native = ""
 RDEPENDS_dbus_class-nativesdk = ""
+PACKAGES += "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
+ALLOW_EMPTY_dbus-ptest = "1"
+RDEPENDS_dbus-ptest = "dbus-test-ptest"
 
 SRC_URI = "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
            file://tmpdir.patch \