Patchwork [meta-fsl-arm-extra,3/3] quartz: Add machine config

login
register
mail settings
Submitter Tony Felice
Date March 18, 2014, 4:15 p.m.
Message ID <1395159350-28155-4-git-send-email-tony.felice@timesys.com>
Download mbox | patch
Permalink /patch/68843/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Tony Felice - March 18, 2014, 4:15 p.m.
This commit adds a machine configuration for the Device Solutions Quartz Vybrid
board.

Signed-off-by: Anthony Felice <tony.felice@timesys.com>
---
 conf/machine/quartz.conf | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 conf/machine/quartz.conf
Daiane Angolini - March 18, 2014, 4:27 p.m.
> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Anthony Felice
> Sent: Tuesday, March 18, 2014 1:16 PM
> To: meta-freescale@yoctoproject.org
> Subject: [meta-freescale] [meta-fsl-arm-extra][PATCH 3/3] quartz: Add
> machine config
> 
> This commit adds a machine configuration for the Device Solutions Quartz
> Vybrid board.
> 
> Signed-off-by: Anthony Felice <tony.felice@timesys.com>
> ---
>  conf/machine/quartz.conf | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 conf/machine/quartz.conf
> 
> diff --git a/conf/machine/quartz.conf b/conf/machine/quartz.conf new file
> mode 100644 index 0000000..0843b76
> --- /dev/null
> +++ b/conf/machine/quartz.conf
> @@ -0,0 +1,22 @@
> +#@TYPE: Machine
> +#@NAME: Device Solutions Quartz Vybrid Development Kit
> +#@SOC: vf60
> +#@DESCRIPTION: Machine configuration for Device Solutions Quartz Vybrid
> +Development Kit
> +#@MAINTAINER: Anthony Felice <tony.felice@timesys.com>
> +
> +include conf/machine/include/imx-base.inc include
> +conf/machine/include/tune-cortexa5.inc
> +
> +SOC_FAMILY = "vf60"
> +
> +PREFERRED_PROVIDER_virtual/kernel = "linux-timesys"
> +PREFERRED_PROVIDER_u-boot = "u-boot-timesys"
> +
> +UBOOT_MACHINE = "quartz_nand_config"

I was expecting to have something using UBOOT_CONFIG with 2 options (sdcard and nand)
from your u-boot patch.

Something like 
http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/tree/conf/machine/imx6qsabresd.conf#n13

Would you mind to double check it?

I don´t have any other comment on this patchset ;-)

Daiane
> +
> +SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
> +IMAGE_FSTYPES ?= "tar.bz2 ext3 sdcard"
> +
> +SERIAL_CONSOLE = "115200 ttymxc0"
> +
> +MACHINE_FEATURES = "apm usbgadget usbhost vfat alsa touchscreen"
> --
> 1.9.0
> 
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
>
Tony Felice - March 18, 2014, 5:05 p.m.
Hi Daiane,

I forgot to mention this, but the quartz_nand_config u-boot config
target supports both SD card boot and NAND boot. I can change the quartz
machine config to specify separate SD and NAND u-boot config targets, or
better document that the quartz_nand_config target supports both SD and
NAND. Let me know which you would prefer.

Thanks,

Tony

On Tue, 2014-03-18 at 12:27 -0400, Daiane.Angolini@freescale.com wrote:
> 
> > -----Original Message-----
> > From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> > bounces@yoctoproject.org] On Behalf Of Anthony Felice
> > Sent: Tuesday, March 18, 2014 1:16 PM
> > To: meta-freescale@yoctoproject.org
> > Subject: [meta-freescale] [meta-fsl-arm-extra][PATCH 3/3] quartz: Add
> > machine config
> > 
> > This commit adds a machine configuration for the Device Solutions Quartz
> > Vybrid board.
> > 
> > Signed-off-by: Anthony Felice <tony.felice@timesys.com>
> > ---
> >  conf/machine/quartz.conf | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> >  create mode 100644 conf/machine/quartz.conf
> > 
> > diff --git a/conf/machine/quartz.conf b/conf/machine/quartz.conf new file
> > mode 100644 index 0000000..0843b76
> > --- /dev/null
> > +++ b/conf/machine/quartz.conf
> > @@ -0,0 +1,22 @@
> > +#@TYPE: Machine
> > +#@NAME: Device Solutions Quartz Vybrid Development Kit
> > +#@SOC: vf60
> > +#@DESCRIPTION: Machine configuration for Device Solutions Quartz Vybrid
> > +Development Kit
> > +#@MAINTAINER: Anthony Felice <tony.felice@timesys.com>
> > +
> > +include conf/machine/include/imx-base.inc include
> > +conf/machine/include/tune-cortexa5.inc
> > +
> > +SOC_FAMILY = "vf60"
> > +
> > +PREFERRED_PROVIDER_virtual/kernel = "linux-timesys"
> > +PREFERRED_PROVIDER_u-boot = "u-boot-timesys"
> > +
> > +UBOOT_MACHINE = "quartz_nand_config"
> 
> I was expecting to have something using UBOOT_CONFIG with 2 options (sdcard and nand)
> from your u-boot patch.
> 
> Something like 
> http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/tree/conf/machine/imx6qsabresd.conf#n13
> 
> Would you mind to double check it?
> 
> I don´t have any other comment on this patchset ;-)
> 
> Daiane
> > +
> > +SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
> > +IMAGE_FSTYPES ?= "tar.bz2 ext3 sdcard"
> > +
> > +SERIAL_CONSOLE = "115200 ttymxc0"
> > +
> > +MACHINE_FEATURES = "apm usbgadget usbhost vfat alsa touchscreen"
> > --
> > 1.9.0
> > 
> > --
> > _______________________________________________
> > meta-freescale mailing list
> > meta-freescale@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-freescale
> > 
>
Daiane Angolini - March 18, 2014, 5:07 p.m.
> -----Original Message-----

> From: Tony Felice [mailto:tony.felice@timesys.com]

> Sent: Tuesday, March 18, 2014 2:06 PM

> To: Angolini Daiane-B19406

> Cc: meta-freescale@yoctoproject.org

> Subject: RE: [meta-freescale] [meta-fsl-arm-extra][PATCH 3/3] quartz: Add

> machine config

> 

> Hi Daiane,

> 

> I forgot to mention this, but the quartz_nand_config u-boot config target

> supports both SD card boot and NAND boot. I can change the quartz machine

> config to specify separate SD and NAND u-boot config targets, or better

> document that the quartz_nand_config target supports both SD and NAND. Let

> me know which you would prefer.


I prefer the documentation. I would add a comment in machine conf file.


Daiane
> 

> Thanks,

> 

> Tony

> 

> On Tue, 2014-03-18 at 12:27 -0400, Daiane.Angolini@freescale.com wrote:

> >

> > > -----Original Message-----

> > > From: meta-freescale-bounces@yoctoproject.org

> > > [mailto:meta-freescale- bounces@yoctoproject.org] On Behalf Of

> > > Anthony Felice

> > > Sent: Tuesday, March 18, 2014 1:16 PM

> > > To: meta-freescale@yoctoproject.org

> > > Subject: [meta-freescale] [meta-fsl-arm-extra][PATCH 3/3] quartz:

> > > Add machine config

> > >

> > > This commit adds a machine configuration for the Device Solutions

> > > Quartz Vybrid board.

> > >

> > > Signed-off-by: Anthony Felice <tony.felice@timesys.com>

> > > ---

> > >  conf/machine/quartz.conf | 22 ++++++++++++++++++++++

> > >  1 file changed, 22 insertions(+)

> > >  create mode 100644 conf/machine/quartz.conf

> > >

> > > diff --git a/conf/machine/quartz.conf b/conf/machine/quartz.conf new

> > > file mode 100644 index 0000000..0843b76

> > > --- /dev/null

> > > +++ b/conf/machine/quartz.conf

> > > @@ -0,0 +1,22 @@

> > > +#@TYPE: Machine

> > > +#@NAME: Device Solutions Quartz Vybrid Development Kit

> > > +#@SOC: vf60

> > > +#@DESCRIPTION: Machine configuration for Device Solutions Quartz

> > > +Vybrid Development Kit

> > > +#@MAINTAINER: Anthony Felice <tony.felice@timesys.com>

> > > +

> > > +include conf/machine/include/imx-base.inc include

> > > +conf/machine/include/tune-cortexa5.inc

> > > +

> > > +SOC_FAMILY = "vf60"

> > > +

> > > +PREFERRED_PROVIDER_virtual/kernel = "linux-timesys"

> > > +PREFERRED_PROVIDER_u-boot = "u-boot-timesys"

> > > +

> > > +UBOOT_MACHINE = "quartz_nand_config"

> >

> > I was expecting to have something using UBOOT_CONFIG with 2 options

> > (sdcard and nand) from your u-boot patch.

> >

> > Something like

> > http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/tree/conf/machi

> > ne/imx6qsabresd.conf#n13

> >

> > Would you mind to double check it?

> >

> > I don´t have any other comment on this patchset ;-)

> >

> > Daiane

> > > +

> > > +SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"

> > > +IMAGE_FSTYPES ?= "tar.bz2 ext3 sdcard"

> > > +

> > > +SERIAL_CONSOLE = "115200 ttymxc0"

> > > +

> > > +MACHINE_FEATURES = "apm usbgadget usbhost vfat alsa touchscreen"

> > > --

> > > 1.9.0

> > >

> > > --

> > > _______________________________________________

> > > meta-freescale mailing list

> > > meta-freescale@yoctoproject.org

> > > https://lists.yoctoproject.org/listinfo/meta-freescale

> > >

> >

> 

> --

> Tony Felice

> Vybrid Technical Lead

> Timesys Corporation

> 

>

Patch

diff --git a/conf/machine/quartz.conf b/conf/machine/quartz.conf
new file mode 100644
index 0000000..0843b76
--- /dev/null
+++ b/conf/machine/quartz.conf
@@ -0,0 +1,22 @@ 
+#@TYPE: Machine
+#@NAME: Device Solutions Quartz Vybrid Development Kit
+#@SOC: vf60
+#@DESCRIPTION: Machine configuration for Device Solutions Quartz Vybrid Development Kit
+#@MAINTAINER: Anthony Felice <tony.felice@timesys.com>
+
+include conf/machine/include/imx-base.inc
+include conf/machine/include/tune-cortexa5.inc
+
+SOC_FAMILY = "vf60"
+
+PREFERRED_PROVIDER_virtual/kernel = "linux-timesys"
+PREFERRED_PROVIDER_u-boot = "u-boot-timesys"
+
+UBOOT_MACHINE = "quartz_nand_config"
+
+SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
+IMAGE_FSTYPES ?= "tar.bz2 ext3 sdcard"
+
+SERIAL_CONSOLE = "115200 ttymxc0"
+
+MACHINE_FEATURES = "apm usbgadget usbhost vfat alsa touchscreen"