Patchwork [meta-fsl-arm,5/5] xf86-video-imxfb-vivanter: Use 'autotools-brokensep' as out of tree build is not supported

login
register
mail settings
Submitter Otavio Salvador
Date March 17, 2014, 5:23 p.m.
Message ID <1395077012-8590-5-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/68759/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - March 17, 2014, 5:23 p.m.
The out of tree build is not currently supported so disabale it for now.

Reported-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

Change-Id: I89103b39bba524403be5bb1916ea5d99bb1662b4
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_3.10.17-1.0.0.bb | 2 ++
 1 file changed, 2 insertions(+)
Daiane Angolini - March 17, 2014, 5:49 p.m.
> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Otavio Salvador
> Sent: Monday, March 17, 2014 2:24 PM
> To: meta-freescale Mailing List
> Cc: Otavio Salvador
> Subject: [meta-freescale] [meta-fsl-arm][PATCH 5/5] xf86-video-imxfb-
> vivanter: Use 'autotools-brokensep' as out of tree build is not supported
> 
> The out of tree build is not currently supported so disabale it for now.


s/disabale/disable

Would you mind to elaborate the commit log?

What do you mean by "out of tree build"?
And, when is it supposed to have a fix to replace this workaround?

 
> Reported-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> 
> Change-Id: I89103b39bba524403be5bb1916ea5d99bb1662b4
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

There are 2 signed-off-by lines. Please remove one.
Daiane

> ---
>  recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_3.10.17-1.0.0.bb | 2
> ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_3.10.17-
> 1.0.0.bb b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_3.10.17-
> 1.0.0.bb
> index 4887d26..b4734bd 100644
> --- a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_3.10.17-
> 1.0.0.bb
> +++ b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_3.10.17-
> 1.0.0.bb
> @@ -6,6 +6,8 @@ require recipes-graphics/xorg-driver/xorg-driver-video.inc
> 
>  PE = "3"
> 
> +inherit autotools-brokensep
> +
>  DEPENDS += "virtual/xserver virtual/libx11 virtual/libgal-x11 gpu-viv-bin-
> mx6q pixman"
> 
>  LIC_FILES_CHKSUM =
> "file://EXA/src/vivante_fbdev/vivante.h;endline=19;md5=641ac6e6d013833e3629
> 0797f4d7089c"
> --
> 1.9.0
> 
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
>
Otavio Salvador - March 17, 2014, 7:43 p.m.
On Mon, Mar 17, 2014 at 2:49 PM, Daiane.Angolini@freescale.com
<Daiane.Angolini@freescale.com> wrote:
>
>
>> -----Original Message-----
>> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
>> bounces@yoctoproject.org] On Behalf Of Otavio Salvador
>> Sent: Monday, March 17, 2014 2:24 PM
>> To: meta-freescale Mailing List
>> Cc: Otavio Salvador
>> Subject: [meta-freescale] [meta-fsl-arm][PATCH 5/5] xf86-video-imxfb-
>> vivanter: Use 'autotools-brokensep' as out of tree build is not supported
>>
>> The out of tree build is not currently supported so disabale it for now.
>
>
> s/disabale/disable
>
> Would you mind to elaborate the commit log?

Fixed locally:

    xf86-video-imxfb-vivanter: Use 'autotools-brokensep' as out of
tree build is not supported

    The out of tree build is not currently supported so disable it for
    now; this change is need to allow autotools to default to out of tree
    builds in future.

    Change-Id: I89103b39bba524403be5bb1916ea5d99bb1662b4
    Reported-by: Richard Purdie <richard.purdie@linuxfoundation.org>
    Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>


> What do you mean by "out of tree build"?

That is, generated files such as object files and executables are
created in a tree outside the project source code. This approach can
be useful when building multiple versions of a project with different
options.

This is well supported for CMake based projects and some Autotools
ones too. But sometimes developers get it wrong as this is not
commonly used by users.

> And, when is it supposed to have a fix to replace this workaround?

When FSL fixes the build system in the driver. We can later work in a
patch for it but now I want to 'workaround' it so autotools class can
default to out of tree builds.

Patch

diff --git a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_3.10.17-1.0.0.bb b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_3.10.17-1.0.0.bb
index 4887d26..b4734bd 100644
--- a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_3.10.17-1.0.0.bb
+++ b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_3.10.17-1.0.0.bb
@@ -6,6 +6,8 @@  require recipes-graphics/xorg-driver/xorg-driver-video.inc
 
 PE = "3"
 
+inherit autotools-brokensep
+
 DEPENDS += "virtual/xserver virtual/libx11 virtual/libgal-x11 gpu-viv-bin-mx6q pixman"
 
 LIC_FILES_CHKSUM = "file://EXA/src/vivante_fbdev/vivante.h;endline=19;md5=641ac6e6d013833e36290797f4d7089c"