Patchwork [0/7] systemd-211 upgrade and uclibc fixes

login
register
mail settings
Submitter Khem Raj
Date March 16, 2014, 5:42 a.m.
Message ID <cover.1394948105.git.raj.khem@gmail.com>
Download mbox
Permalink /patch/68695/
State New
Headers show

Pull-request

git://git.openembedded.org/openembedded-core-contrib kraj/systemd-211

Comments

Khem Raj - March 16, 2014, 5:42 a.m.
Finally, managed to get systemd 211 to boot on uclibc and eglibc
on all supported qemu machines, this should fix bug #5940

Additional functionality in uclibc is needed to support this
systemd

gnutls, glib-2.0, intltool fixes are uclibc specific and are needed
to get uclibc images going

util-linux fix is moulded to support uclibc

I have been testing this fix on the qemuarm/qemuppc/qemumips/qemux86/qemux86-64
on both uclibc/eglibc images and its been working good.

The following changes since commit 58aae40bbf8edd9c5ca70b2094eeb724391f1993:

  eglibc: Update SRC_URI to point to final download location (2014-03-13 20:44:48 -0700)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib kraj/systemd-211
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/systemd-211

Khem Raj (7):
  uclibc: Implement clock_adjtime()
  uclibc: Remove iconv.h
  gnutls: Link in pthread explicitly for uclibc
  glib-2.0: Fix localedir expectations for uclibc
  util-linux: scanf_cv_alloc_modifier changed from 'as' -> 'ms'
  intltool: Define DATADIRNAME=share for uclibc based systems
  Upgrade to systemd 211+

 meta/recipes-core/glib-2.0/glib-2.0/uclibc.patch   |  20 ++
 meta/recipes-core/glib-2.0/glib-2.0_2.38.2.bb      |   1 +
 ...1-uClibc-doesn-t-implement-pwritev-preadv.patch |  15 +-
 .../systemd-pam-configure-check-uclibc.patch       |  25 +-
 .../systemd/systemd/systemd-pam-fix-execvpe.patch  |  22 +-
 .../systemd/systemd-pam-fix-fallocate.patch        |  16 +-
 .../systemd/systemd-pam-fix-getty-unit.patch       |  20 +-
 .../systemd/systemd/systemd-pam-fix-mkostemp.patch | 166 +---------
 .../systemd/systemd/systemd-pam-fix-msformat.patch | 348 ---------------------
 .../systemd/systemd/uclibc-get-physmem.patch       |  37 +++
 .../systemd/systemd/uclibc-sysinfo_h.patch         |  19 ++
 .../systemd/{systemd_208.bb => systemd_211.bb}     |  31 +-
 meta/recipes-core/uclibc/uclibc-git.inc            |   3 +-
 .../0004-Add-clock_adjtime-syscall.patch           |  73 +++++
 meta/recipes-core/uclibc/uclibc.inc                |   3 +-
 meta/recipes-core/util-linux/util-linux_2.24.1.bb  |   3 +-
 .../intltool/intltool-0.50.2/uclibc.patch          |  19 ++
 meta/recipes-devtools/intltool/intltool_0.50.2.bb  |   1 +
 meta/recipes-support/gnutls/gnutls.inc             |   2 +
 19 files changed, 258 insertions(+), 566 deletions(-)
 create mode 100644 meta/recipes-core/glib-2.0/glib-2.0/uclibc.patch
 delete mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-msformat.patch
 create mode 100644 meta/recipes-core/systemd/systemd/uclibc-get-physmem.patch
 create mode 100644 meta/recipes-core/systemd/systemd/uclibc-sysinfo_h.patch
 rename meta/recipes-core/systemd/{systemd_208.bb => systemd_211.bb} (93%)
 create mode 100644 meta/recipes-core/uclibc/uclibc-git/0004-Add-clock_adjtime-syscall.patch
 create mode 100644 meta/recipes-devtools/intltool/intltool-0.50.2/uclibc.patch
Richard Purdie - March 17, 2014, 11:31 a.m.
On Sat, 2014-03-15 at 22:42 -0700, Khem Raj wrote:
> Finally, managed to get systemd 211 to boot on uclibc and eglibc
> on all supported qemu machines, this should fix bug #5940
> 
> Additional functionality in uclibc is needed to support this
> systemd
> 
> gnutls, glib-2.0, intltool fixes are uclibc specific and are needed
> to get uclibc images going
> 
> util-linux fix is moulded to support uclibc
> 
> I have been testing this fix on the qemuarm/qemuppc/qemumips/qemux86/qemux86-64
> on both uclibc/eglibc images and its been working good.
> 
> The following changes since commit 58aae40bbf8edd9c5ca70b2094eeb724391f1993:
> 
>   eglibc: Update SRC_URI to point to final download location (2014-03-13 20:44:48 -0700)
> 
> are available in the git repository at:
> 
>   git://git.openembedded.org/openembedded-core-contrib kraj/systemd-211
>   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/systemd-211
> 
> Khem Raj (7):
>   uclibc: Implement clock_adjtime()
>   uclibc: Remove iconv.h
>   gnutls: Link in pthread explicitly for uclibc
>   glib-2.0: Fix localedir expectations for uclibc
>   util-linux: scanf_cv_alloc_modifier changed from 'as' -> 'ms'
>   intltool: Define DATADIRNAME=share for uclibc based systems
>   Upgrade to systemd 211+

I tried this on the autobuilder, with and without the pulseaudio 4->5
upgrade. The result was:

http://autobuilder.yoctoproject.org/main/builders/nightly-qa-systemd/builds/111
http://autobuilder.yoctoproject.org/main/builders/nightly-qa-systemd/builds/112

so I'm afraid I can't take the systemd part of this series. Its getting
late in the cycle for a pulseaudio 4->5 upgrade too :/

Does anyone have any strong opinions on this?

Cheers,

Richard
Martin Jansa - March 17, 2014, 11:41 a.m.
On Mon, Mar 17, 2014 at 11:31:16AM +0000, Richard Purdie wrote:
> On Sat, 2014-03-15 at 22:42 -0700, Khem Raj wrote:
> > Finally, managed to get systemd 211 to boot on uclibc and eglibc
> > on all supported qemu machines, this should fix bug #5940
> > 
> > Additional functionality in uclibc is needed to support this
> > systemd
> > 
> > gnutls, glib-2.0, intltool fixes are uclibc specific and are needed
> > to get uclibc images going
> > 
> > util-linux fix is moulded to support uclibc
> > 
> > I have been testing this fix on the qemuarm/qemuppc/qemumips/qemux86/qemux86-64
> > on both uclibc/eglibc images and its been working good.
> > 
> > The following changes since commit 58aae40bbf8edd9c5ca70b2094eeb724391f1993:
> > 
> >   eglibc: Update SRC_URI to point to final download location (2014-03-13 20:44:48 -0700)
> > 
> > are available in the git repository at:
> > 
> >   git://git.openembedded.org/openembedded-core-contrib kraj/systemd-211
> >   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/systemd-211
> > 
> > Khem Raj (7):
> >   uclibc: Implement clock_adjtime()
> >   uclibc: Remove iconv.h
> >   gnutls: Link in pthread explicitly for uclibc
> >   glib-2.0: Fix localedir expectations for uclibc
> >   util-linux: scanf_cv_alloc_modifier changed from 'as' -> 'ms'
> >   intltool: Define DATADIRNAME=share for uclibc based systems
> >   Upgrade to systemd 211+
> 
> I tried this on the autobuilder, with and without the pulseaudio 4->5
> upgrade. The result was:
> 
> http://autobuilder.yoctoproject.org/main/builders/nightly-qa-systemd/builds/111
> http://autobuilder.yoctoproject.org/main/builders/nightly-qa-systemd/builds/112

Both links show pulseaudio/4.0 in error log and 4.0 needs something
like:
http://lists.openembedded.org/pipermail/openembedded-core/2014-February/089796.html

> so I'm afraid I can't take the systemd part of this series. Its getting
> late in the cycle for a pulseaudio 4->5 upgrade too :/
> 
> Does anyone have any strong opinions on this?
> 
> Cheers,
> 
> Richard
> 
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Richard Purdie - March 17, 2014, 12:29 p.m.
On Mon, 2014-03-17 at 12:41 +0100, Martin Jansa wrote:
> On Mon, Mar 17, 2014 at 11:31:16AM +0000, Richard Purdie wrote:
> > On Sat, 2014-03-15 at 22:42 -0700, Khem Raj wrote:
> > > Finally, managed to get systemd 211 to boot on uclibc and eglibc
> > > on all supported qemu machines, this should fix bug #5940
> > > 
> > > Additional functionality in uclibc is needed to support this
> > > systemd
> > > 
> > > gnutls, glib-2.0, intltool fixes are uclibc specific and are needed
> > > to get uclibc images going
> > > 
> > > util-linux fix is moulded to support uclibc
> > > 
> > > I have been testing this fix on the qemuarm/qemuppc/qemumips/qemux86/qemux86-64
> > > on both uclibc/eglibc images and its been working good.
> > > 
> > > The following changes since commit 58aae40bbf8edd9c5ca70b2094eeb724391f1993:
> > > 
> > >   eglibc: Update SRC_URI to point to final download location (2014-03-13 20:44:48 -0700)
> > > 
> > > are available in the git repository at:
> > > 
> > >   git://git.openembedded.org/openembedded-core-contrib kraj/systemd-211
> > >   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/systemd-211
> > > 
> > > Khem Raj (7):
> > >   uclibc: Implement clock_adjtime()
> > >   uclibc: Remove iconv.h
> > >   gnutls: Link in pthread explicitly for uclibc
> > >   glib-2.0: Fix localedir expectations for uclibc
> > >   util-linux: scanf_cv_alloc_modifier changed from 'as' -> 'ms'
> > >   intltool: Define DATADIRNAME=share for uclibc based systems
> > >   Upgrade to systemd 211+
> > 
> > I tried this on the autobuilder, with and without the pulseaudio 4->5
> > upgrade. The result was:
> > 
> > http://autobuilder.yoctoproject.org/main/builders/nightly-qa-systemd/builds/111
> > http://autobuilder.yoctoproject.org/main/builders/nightly-qa-systemd/builds/112

Sorry, pa-5 is:

http://autobuilder.yoctoproject.org/main/builders/nightly-qa-systemd/builds/110/

> Both links show pulseaudio/4.0 in error log and 4.0 needs something
> like:
> http://lists.openembedded.org/pipermail/openembedded-core/2014-February/089796.html

Thanks, will take a look at that.

Cheers,

Richard
Khem Raj - March 17, 2014, 4:06 p.m.
On Mon, Mar 17, 2014 at 4:31 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Sat, 2014-03-15 at 22:42 -0700, Khem Raj wrote:
>> Finally, managed to get systemd 211 to boot on uclibc and eglibc
>> on all supported qemu machines, this should fix bug #5940
>>
>> Additional functionality in uclibc is needed to support this
>> systemd
>>
>> gnutls, glib-2.0, intltool fixes are uclibc specific and are needed
>> to get uclibc images going
>>
>> util-linux fix is moulded to support uclibc
>>
>> I have been testing this fix on the qemuarm/qemuppc/qemumips/qemux86/qemux86-64
>> on both uclibc/eglibc images and its been working good.
>>
>> The following changes since commit 58aae40bbf8edd9c5ca70b2094eeb724391f1993:
>>
>>   eglibc: Update SRC_URI to point to final download location (2014-03-13 20:44:48 -0700)
>>
>> are available in the git repository at:
>>
>>   git://git.openembedded.org/openembedded-core-contrib kraj/systemd-211
>>   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/systemd-211
>>
>> Khem Raj (7):
>>   uclibc: Implement clock_adjtime()
>>   uclibc: Remove iconv.h
>>   gnutls: Link in pthread explicitly for uclibc
>>   glib-2.0: Fix localedir expectations for uclibc
>>   util-linux: scanf_cv_alloc_modifier changed from 'as' -> 'ms'
>>   intltool: Define DATADIRNAME=share for uclibc based systems
>>   Upgrade to systemd 211+
>
> I tried this on the autobuilder, with and without the pulseaudio 4->5
> upgrade. The result was:
>
> http://autobuilder.yoctoproject.org/main/builders/nightly-qa-systemd/builds/111
> http://autobuilder.yoctoproject.org/main/builders/nightly-qa-systemd/builds/112
>
> so I'm afraid I can't take the systemd part of this series. Its getting
> late in the cycle for a pulseaudio 4->5 upgrade too :/

I was fighting with runtime issues than the build time so I was
building minimal images for quick debug/test cycles.
my bad since I kept pulseaudio out of this pull request the systemd
patch that Martin had
was also left out.


>
> Does anyone have any strong opinions on this?

Give it a shot, if you can otherwise it can wait, 208 still shows
issues with journald where journal
sometimes misses chunks of logs of chatty daemons for an interval of
time after few hours of running, I haven't seen this issue with 211
yet so this is an improvement.
however 208 will keep getting fixes it probably isnt a bad choice to
stick with for this release.

>
> Cheers,
>
> Richard
>
>
Richard Purdie - March 17, 2014, 9:52 p.m.
On Mon, 2014-03-17 at 09:06 -0700, Khem Raj wrote:
> On Mon, Mar 17, 2014 at 4:31 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Sat, 2014-03-15 at 22:42 -0700, Khem Raj wrote:
> >> Finally, managed to get systemd 211 to boot on uclibc and eglibc
> >> on all supported qemu machines, this should fix bug #5940
> >>
> >> Additional functionality in uclibc is needed to support this
> >> systemd
> >>
> >> gnutls, glib-2.0, intltool fixes are uclibc specific and are needed
> >> to get uclibc images going
> >>
> >> util-linux fix is moulded to support uclibc
> >>
> >> I have been testing this fix on the qemuarm/qemuppc/qemumips/qemux86/qemux86-64
> >> on both uclibc/eglibc images and its been working good.
> >>
> >> The following changes since commit 58aae40bbf8edd9c5ca70b2094eeb724391f1993:
> >>
> >>   eglibc: Update SRC_URI to point to final download location (2014-03-13 20:44:48 -0700)
> >>
> >> are available in the git repository at:
> >>
> >>   git://git.openembedded.org/openembedded-core-contrib kraj/systemd-211
> >>   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/systemd-211
> >>
> >> Khem Raj (7):
> >>   uclibc: Implement clock_adjtime()
> >>   uclibc: Remove iconv.h
> >>   gnutls: Link in pthread explicitly for uclibc
> >>   glib-2.0: Fix localedir expectations for uclibc
> >>   util-linux: scanf_cv_alloc_modifier changed from 'as' -> 'ms'
> >>   intltool: Define DATADIRNAME=share for uclibc based systems
> >>   Upgrade to systemd 211+
> >
> > I tried this on the autobuilder, with and without the pulseaudio 4->5
> > upgrade. The result was:
> >
> > http://autobuilder.yoctoproject.org/main/builders/nightly-qa-systemd/builds/111
> > http://autobuilder.yoctoproject.org/main/builders/nightly-qa-systemd/builds/112
> >
> > so I'm afraid I can't take the systemd part of this series. Its getting
> > late in the cycle for a pulseaudio 4->5 upgrade too :/
> 
> I was fighting with runtime issues than the build time so I was
> building minimal images for quick debug/test cycles.
> my bad since I kept pulseaudio out of this pull request the systemd
> patch that Martin had
> was also left out.
> 
> 
> >
> > Does anyone have any strong opinions on this?
> 
> Give it a shot, if you can otherwise it can wait, 208 still shows
> issues with journald where journal
> sometimes misses chunks of logs of chatty daemons for an interval of
> time after few hours of running, I haven't seen this issue with 211
> yet so this is an improvement.
> however 208 will keep getting fixes it probably isnt a bad choice to
> stick with for this release.

FWIW Martin's patch showed a green build. I'm therefore more widely
testing that combination.

Cheers,

Richard
Martin Jansa - March 17, 2014, 10:05 p.m.
On Mon, Mar 17, 2014 at 09:52:55PM +0000, Richard Purdie wrote:
> On Mon, 2014-03-17 at 09:06 -0700, Khem Raj wrote:
> > On Mon, Mar 17, 2014 at 4:31 AM, Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> > > On Sat, 2014-03-15 at 22:42 -0700, Khem Raj wrote:
> > >> Finally, managed to get systemd 211 to boot on uclibc and eglibc
> > >> on all supported qemu machines, this should fix bug #5940
> > >>
> > >> Additional functionality in uclibc is needed to support this
> > >> systemd
> > >>
> > >> gnutls, glib-2.0, intltool fixes are uclibc specific and are needed
> > >> to get uclibc images going
> > >>
> > >> util-linux fix is moulded to support uclibc
> > >>
> > >> I have been testing this fix on the qemuarm/qemuppc/qemumips/qemux86/qemux86-64
> > >> on both uclibc/eglibc images and its been working good.
> > >>
> > >> The following changes since commit 58aae40bbf8edd9c5ca70b2094eeb724391f1993:
> > >>
> > >>   eglibc: Update SRC_URI to point to final download location (2014-03-13 20:44:48 -0700)
> > >>
> > >> are available in the git repository at:
> > >>
> > >>   git://git.openembedded.org/openembedded-core-contrib kraj/systemd-211
> > >>   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/systemd-211
> > >>
> > >> Khem Raj (7):
> > >>   uclibc: Implement clock_adjtime()
> > >>   uclibc: Remove iconv.h
> > >>   gnutls: Link in pthread explicitly for uclibc
> > >>   glib-2.0: Fix localedir expectations for uclibc
> > >>   util-linux: scanf_cv_alloc_modifier changed from 'as' -> 'ms'
> > >>   intltool: Define DATADIRNAME=share for uclibc based systems
> > >>   Upgrade to systemd 211+
> > >
> > > I tried this on the autobuilder, with and without the pulseaudio 4->5
> > > upgrade. The result was:
> > >
> > > http://autobuilder.yoctoproject.org/main/builders/nightly-qa-systemd/builds/111
> > > http://autobuilder.yoctoproject.org/main/builders/nightly-qa-systemd/builds/112
> > >
> > > so I'm afraid I can't take the systemd part of this series. Its getting
> > > late in the cycle for a pulseaudio 4->5 upgrade too :/
> > 
> > I was fighting with runtime issues than the build time so I was
> > building minimal images for quick debug/test cycles.
> > my bad since I kept pulseaudio out of this pull request the systemd
> > patch that Martin had
> > was also left out.
> > 
> > 
> > >
> > > Does anyone have any strong opinions on this?
> > 
> > Give it a shot, if you can otherwise it can wait, 208 still shows
> > issues with journald where journal
> > sometimes misses chunks of logs of chatty daemons for an interval of
> > time after few hours of running, I haven't seen this issue with 211
> > yet so this is an improvement.
> > however 208 will keep getting fixes it probably isnt a bad choice to
> > stick with for this release.
> 
> FWIW Martin's patch showed a green build. I'm therefore more widely
> testing that combination.

I should say that my pulseaudio change was also motivated mostly to get
green build and to allow me to flash new image on my MACHINEs, and test systemd
in runtime, but then I don't use pulseaudio in runtime, so it wasn't properly
tested there.
Khem Raj - March 17, 2014, 10:42 p.m.
On Mon, Mar 17, 2014 at 3:05 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Mon, Mar 17, 2014 at 09:52:55PM +0000, Richard Purdie wrote:
>> On Mon, 2014-03-17 at 09:06 -0700, Khem Raj wrote:
>> > On Mon, Mar 17, 2014 at 4:31 AM, Richard Purdie
>> > <richard.purdie@linuxfoundation.org> wrote:
>> > > On Sat, 2014-03-15 at 22:42 -0700, Khem Raj wrote:
>> > >> Finally, managed to get systemd 211 to boot on uclibc and eglibc
>> > >> on all supported qemu machines, this should fix bug #5940
>> > >>
>> > >> Additional functionality in uclibc is needed to support this
>> > >> systemd
>> > >>
>> > >> gnutls, glib-2.0, intltool fixes are uclibc specific and are needed
>> > >> to get uclibc images going
>> > >>
>> > >> util-linux fix is moulded to support uclibc
>> > >>
>> > >> I have been testing this fix on the qemuarm/qemuppc/qemumips/qemux86/qemux86-64
>> > >> on both uclibc/eglibc images and its been working good.
>> > >>
>> > >> The following changes since commit 58aae40bbf8edd9c5ca70b2094eeb724391f1993:
>> > >>
>> > >>   eglibc: Update SRC_URI to point to final download location (2014-03-13 20:44:48 -0700)
>> > >>
>> > >> are available in the git repository at:
>> > >>
>> > >>   git://git.openembedded.org/openembedded-core-contrib kraj/systemd-211
>> > >>   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/systemd-211
>> > >>
>> > >> Khem Raj (7):
>> > >>   uclibc: Implement clock_adjtime()
>> > >>   uclibc: Remove iconv.h
>> > >>   gnutls: Link in pthread explicitly for uclibc
>> > >>   glib-2.0: Fix localedir expectations for uclibc
>> > >>   util-linux: scanf_cv_alloc_modifier changed from 'as' -> 'ms'
>> > >>   intltool: Define DATADIRNAME=share for uclibc based systems
>> > >>   Upgrade to systemd 211+
>> > >
>> > > I tried this on the autobuilder, with and without the pulseaudio 4->5
>> > > upgrade. The result was:
>> > >
>> > > http://autobuilder.yoctoproject.org/main/builders/nightly-qa-systemd/builds/111
>> > > http://autobuilder.yoctoproject.org/main/builders/nightly-qa-systemd/builds/112
>> > >
>> > > so I'm afraid I can't take the systemd part of this series. Its getting
>> > > late in the cycle for a pulseaudio 4->5 upgrade too :/
>> >
>> > I was fighting with runtime issues than the build time so I was
>> > building minimal images for quick debug/test cycles.
>> > my bad since I kept pulseaudio out of this pull request the systemd
>> > patch that Martin had
>> > was also left out.
>> >
>> >
>> > >
>> > > Does anyone have any strong opinions on this?
>> >
>> > Give it a shot, if you can otherwise it can wait, 208 still shows
>> > issues with journald where journal
>> > sometimes misses chunks of logs of chatty daemons for an interval of
>> > time after few hours of running, I haven't seen this issue with 211
>> > yet so this is an improvement.
>> > however 208 will keep getting fixes it probably isnt a bad choice to
>> > stick with for this release.
>>
>> FWIW Martin's patch showed a green build. I'm therefore more widely
>> testing that combination.
>
> I should say that my pulseaudio change was also motivated mostly to get
> green build and to allow me to flash new image on my MACHINEs, and test systemd
> in runtime, but then I don't use pulseaudio in runtime, so it wasn't properly
> tested there.

I think, this change should be done a bit differently where it looks
for both libraries and then it will become
worthy of submitting to pulseaudio upstream. There might be couple  of
other packages that integrate with systemd
APIs which will need this kind of fix.