Patchwork [5/6] beecrypt: Fix up packaging QA warnings

login
mail settings
Submitter Richard Purdie
Date July 1, 2011, 3:17 p.m.
Message ID <469c48cf5611c9e984d8114a48e834d03c44d099.1309533254.git.richard.purdie@linuxfoundation.org>
Download mbox | patch
Permalink /patch/6859/
State New, archived
Headers show

Comments

Richard Purdie - July 1, 2011, 3:17 p.m.
From: Richard  Purdie <richard.purdie@linuxfoundation.org>

Signed-off-by: Richard  Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-support/beecrypt/beecrypt_4.2.1.bb |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Phil Blundell - July 1, 2011, 3:19 p.m.
On Fri, 2011-07-01 at 16:17 +0100, Richard Purdie wrote:
> +FILES_${PN} = "${sysconfdir} ${libdir}/*.so.* ${libdir}/${BPN}/*.so.*"

You can use ${SOLIBS} there...

> +FILES_${PN}-dev += "${libdir}/${BPN}/*.so ${libdir}/${BPN}/*.la

... and ${SOLIBSDEV} there.

p.
Richard Purdie - July 1, 2011, 10:12 p.m.
On Fri, 2011-07-01 at 16:19 +0100, Phil Blundell wrote:
> On Fri, 2011-07-01 at 16:17 +0100, Richard Purdie wrote:
> > +FILES_${PN} = "${sysconfdir} ${libdir}/*.so.* ${libdir}/${BPN}/*.so.*"
> 
> You can use ${SOLIBS} there...
> 
> > +FILES_${PN}-dev += "${libdir}/${BPN}/*.so ${libdir}/${BPN}/*.la
> 
> ... and ${SOLIBSDEV} there.

I'm in two minds on these. On the one hand they do make sense and have
allowed us to build darwin targets in the past (and would extend to
windows too). On the other hand nobody is using them outside the core
metadata.

I think a global search and replace would likely be the best move if we
decide they're a good thing...

Cheers,

Richard
Koen Kooi - July 2, 2011, 7:40 a.m.
Op 2 jul 2011, om 00:12 heeft Richard Purdie het volgende geschreven:

> On Fri, 2011-07-01 at 16:19 +0100, Phil Blundell wrote:
>> On Fri, 2011-07-01 at 16:17 +0100, Richard Purdie wrote:
>>> +FILES_${PN} = "${sysconfdir} ${libdir}/*.so.* ${libdir}/${BPN}/ 
>>> *.so.*"
>>
>> You can use ${SOLIBS} there...
>>
>>> +FILES_${PN}-dev += "${libdir}/${BPN}/*.so ${libdir}/${BPN}/*.la
>>
>> ... and ${SOLIBSDEV} there.
>
> I'm in two minds on these. On the one hand they do make sense and have
> allowed us to build darwin targets in the past (and would extend to
> windows too). On the other hand nobody is using them outside the core
> metadata.

They would also be usefull for uclinux builds
Phil Blundell - July 5, 2011, 10:20 a.m.
On Fri, 2011-07-01 at 23:12 +0100, Richard Purdie wrote:
> On Fri, 2011-07-01 at 16:19 +0100, Phil Blundell wrote:
> > On Fri, 2011-07-01 at 16:17 +0100, Richard Purdie wrote:
> > > +FILES_${PN} = "${sysconfdir} ${libdir}/*.so.* ${libdir}/${BPN}/*.so.*"
> > 
> > You can use ${SOLIBS} there...
> > 
> > > +FILES_${PN}-dev += "${libdir}/${BPN}/*.so ${libdir}/${BPN}/*.la
> > 
> > ... and ${SOLIBSDEV} there.
> 
> I'm in two minds on these. On the one hand they do make sense and have
> allowed us to build darwin targets in the past (and would extend to
> windows too). On the other hand nobody is using them outside the core
> metadata.

I'm not quite sure I understand what you mean by the "core metadata" in
this context.  There are a handful of uses (though admittedly not many)
in meta-oe for example, so it is not quite true to say that their usage
is restricted solely to oe-core.

Regardless, I don't think the fact that these are seldom used at present
is a reason to not use them more in future.  Aside from the
darwin/windows/other OS issue, using the variables rather than writing
out ".so.*" by hand is more robust in that it avoids the risk of typos
causing packaging errors.  We've had several instances in the past, for
example, of people accidentally omitting the second dot and writing
".so*".

p.

Patch

diff --git a/meta/recipes-support/beecrypt/beecrypt_4.2.1.bb b/meta/recipes-support/beecrypt/beecrypt_4.2.1.bb
index d4c7972..f660641 100644
--- a/meta/recipes-support/beecrypt/beecrypt_4.2.1.bb
+++ b/meta/recipes-support/beecrypt/beecrypt_4.2.1.bb
@@ -24,4 +24,8 @@  acpaths=""
 
 EXTRA_OECONF="--without-python --enable-shared --enable-static --disable-openmp"
 
+FILES_${PN} = "${sysconfdir} ${libdir}/*.so.* ${libdir}/${BPN}/*.so.*"
+FILES_${PN}-dev += "${libdir}/${BPN}/*.so ${libdir}/${BPN}/*.la"
+FILES_${PN}-staticdev += "${libdir}/${BPN}/*.a"
+
 BBCLASSEXTEND = "native"