Patchwork Set ac_cv_sizeof_ssize_t

login
register
mail settings
Submitter Valentin Popa
Date March 13, 2014, 11:28 a.m.
Message ID <1394710133-18659-1-git-send-email-valentin.popa@intel.com>
Download mbox | patch
Permalink /patch/68589/
State New
Headers show

Comments

Valentin Popa - March 13, 2014, 11:28 a.m.
Set ac_cv_sizeof_ssize_t for mips64;
mips-common will not overwrite it.

[YOCTO #5935]

Signed-off-by: Valentin Popa <valentin.popa@intel.com>
---
 meta/site/mips64-linux | 1 +
 1 file changed, 1 insertion(+)
Saul Wold - March 14, 2014, 7:40 a.m.
On 03/13/2014 04:28 AM, Valentin Popa wrote:
> Set ac_cv_sizeof_ssize_t for mips64;
> mips-common will not overwrite it.
>

This really needed a little more about "why" this change is needed.

Sau!

> [YOCTO #5935]
>
> Signed-off-by: Valentin Popa <valentin.popa@intel.com>
> ---
>   meta/site/mips64-linux | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/meta/site/mips64-linux b/meta/site/mips64-linux
> index 4449c96..ed0fbbe 100644
> --- a/meta/site/mips64-linux
> +++ b/meta/site/mips64-linux
> @@ -35,6 +35,7 @@ glib_cv_use_pid_surrogate=${glib_cv_use_pid_surrogate=yes}
>   ac_cv_alignof_guint32=4
>   ac_cv_alignof_guint64=8
>   ac_cv_alignof_unsigned_long=8
> +ac_cv_sizeof_ssize_t=8
>
>   # libpcap
>   ac_cv_linux_vers=${ac_cv_linux_vers=2}
>
Gary Thomas - March 14, 2014, 9:11 a.m.
On 2014-03-14 01:40, Saul Wold wrote:
> On 03/13/2014 04:28 AM, Valentin Popa wrote:
>> Set ac_cv_sizeof_ssize_t for mips64;
>> mips-common will not overwrite it.
>>
> 
> This really needed a little more about "why" this change is needed.

Also, the email subject is missing the 'mips64-linux: ' prefix which is the
preferred form.

>> [YOCTO #5935]
>>
>> Signed-off-by: Valentin Popa <valentin.popa@intel.com>
>> ---
>>   meta/site/mips64-linux | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/site/mips64-linux b/meta/site/mips64-linux
>> index 4449c96..ed0fbbe 100644
>> --- a/meta/site/mips64-linux
>> +++ b/meta/site/mips64-linux
>> @@ -35,6 +35,7 @@ glib_cv_use_pid_surrogate=${glib_cv_use_pid_surrogate=yes}
>>   ac_cv_alignof_guint32=4
>>   ac_cv_alignof_guint64=8
>>   ac_cv_alignof_unsigned_long=8
>> +ac_cv_sizeof_ssize_t=8
>>
>>   # libpcap
>>   ac_cv_linux_vers=${ac_cv_linux_vers=2}
>>
Khem Raj - March 14, 2014, 10:10 a.m.
On Fri, Mar 14, 2014 at 12:40 AM, Saul Wold <sgw@linux.intel.com> wrote:
> On 03/13/2014 04:28 AM, Valentin Popa wrote:
>>
>> Set ac_cv_sizeof_ssize_t for mips64;
>> mips-common will not overwrite it.
>>
>
> This really needed a little more about "why" this change is needed.
>

ssize_t is a posix define which is architecture specific whose value
is signed size_t, glibc/uclibc for mips64/n64 linux platform defines
it to be equivalent of 'long' and long here is 8bytes because
mips64/n64 follows LP64 model. In OpenEmbedded our default ABI for
mips64 platforms is N64, having said that autoconf decides to poke at
the platform for finding these kind of sizes which fails when you are
doing cross compiling hence we have to cache it.

> Sau!
>
>
>> [YOCTO #5935]
>>
>> Signed-off-by: Valentin Popa <valentin.popa@intel.com>
>> ---
>>   meta/site/mips64-linux | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/site/mips64-linux b/meta/site/mips64-linux
>> index 4449c96..ed0fbbe 100644
>> --- a/meta/site/mips64-linux
>> +++ b/meta/site/mips64-linux
>> @@ -35,6 +35,7 @@
>> glib_cv_use_pid_surrogate=${glib_cv_use_pid_surrogate=yes}
>>   ac_cv_alignof_guint32=4
>>   ac_cv_alignof_guint64=8
>>   ac_cv_alignof_unsigned_long=8
>> +ac_cv_sizeof_ssize_t=8
>>
>>   # libpcap
>>   ac_cv_linux_vers=${ac_cv_linux_vers=2}
>>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Valentin Popa - March 14, 2014, 10:57 a.m.
On 03/14/2014 12:10 PM, Khem Raj wrote:
> On Fri, Mar 14, 2014 at 12:40 AM, Saul Wold <sgw@linux.intel.com> wrote:
>> On 03/13/2014 04:28 AM, Valentin Popa wrote:
>>> Set ac_cv_sizeof_ssize_t for mips64;
>>> mips-common will not overwrite it.
>>>
>> This really needed a little more about "why" this change is needed.
>>
> ssize_t is a posix define which is architecture specific whose value
> is signed size_t, glibc/uclibc for mips64/n64 linux platform defines
> it to be equivalent of 'long' and long here is 8bytes because
> mips64/n64 follows LP64 model. In OpenEmbedded our default ABI for
> mips64 platforms is N64, having said that autoconf decides to poke at
> the platform for finding these kind of sizes which fails when you are
> doing cross compiling hence we have to cache it.
     Thanks for the explanation Khem!
>
>> Sau!
>>
>>
>>> [YOCTO #5935]
>>>
>>> Signed-off-by: Valentin Popa <valentin.popa@intel.com>
>>> ---
>>>    meta/site/mips64-linux | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/meta/site/mips64-linux b/meta/site/mips64-linux
>>> index 4449c96..ed0fbbe 100644
>>> --- a/meta/site/mips64-linux
>>> +++ b/meta/site/mips64-linux
>>> @@ -35,6 +35,7 @@
>>> glib_cv_use_pid_surrogate=${glib_cv_use_pid_surrogate=yes}
>>>    ac_cv_alignof_guint32=4
>>>    ac_cv_alignof_guint64=8
>>>    ac_cv_alignof_unsigned_long=8
>>> +ac_cv_sizeof_ssize_t=8
>>>
>>>    # libpcap
>>>    ac_cv_linux_vers=${ac_cv_linux_vers=2}
>>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/site/mips64-linux b/meta/site/mips64-linux
index 4449c96..ed0fbbe 100644
--- a/meta/site/mips64-linux
+++ b/meta/site/mips64-linux
@@ -35,6 +35,7 @@  glib_cv_use_pid_surrogate=${glib_cv_use_pid_surrogate=yes}
 ac_cv_alignof_guint32=4
 ac_cv_alignof_guint64=8
 ac_cv_alignof_unsigned_long=8
+ac_cv_sizeof_ssize_t=8
 
 # libpcap
 ac_cv_linux_vers=${ac_cv_linux_vers=2}