Patchwork [1/2] packagegroup-core-tools-testapp: added 3G tools

login
register
mail settings
Submitter Cristian Iorga
Date March 13, 2014, 9:45 a.m.
Message ID <fcd2f5c2d7d8063a6084de454c0847cba830480d.1394703743.git.cristian.iorga@intel.com>
Download mbox | patch
Permalink /patch/68575/
State New
Headers show

Comments

Cristian Iorga - March 13, 2014, 9:45 a.m.
Added ofono tests package.

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
---
 .../recipes-core/packagegroups/packagegroup-core-tools-testapps.bb | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Ross Burton - March 13, 2014, 10:09 a.m.
On 13 March 2014 09:45, Cristian Iorga <cristian.iorga@intel.com> wrote:
> -PR = "r2"
> +PR = "r3"

No need to bump PR.

Ross
Cristian Iorga - March 13, 2014, 10:20 a.m.
But in this case, can be removed?
/Cristian

-----Original Message-----
From: Burton, Ross [mailto:ross.burton@intel.com] 
Sent: Thursday, March 13, 2014 12:10 PM
To: Iorga, Cristian
Cc: OE-core
Subject: Re: [OE-core] [PATCH 1/2] packagegroup-core-tools-testapp: added 3G tools

On 13 March 2014 09:45, Cristian Iorga <cristian.iorga@intel.com> wrote:
> -PR = "r2"
> +PR = "r3"

No need to bump PR.

Ross
Ross Burton - March 13, 2014, 10:32 a.m.
On 13 March 2014 10:20, Iorga, Cristian <cristian.iorga@intel.com> wrote:
> But in this case, can be removed?

Nope, then it would go back to r0.  It will have to stay forever.

Ross
Paul Eggleton - March 13, 2014, 10:33 a.m.
On Thursday 13 March 2014 10:20:09 Iorga, Cristian wrote:
> > No need to bump PR.
>
> But in this case, can be removed?

Not if PV is staying the same, no.

Cheers,
Paul
Cristian Iorga - March 13, 2014, 10:37 a.m.
OK, thanks for the explanation, will resend.
/Cristian

-----Original Message-----
From: Paul Eggleton [mailto:paul.eggleton@linux.intel.com] 
Sent: Thursday, March 13, 2014 12:33 PM
To: Iorga, Cristian
Cc: Burton, Ross; openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 1/2] packagegroup-core-tools-testapp: added 3G tools

On Thursday 13 March 2014 10:20:09 Iorga, Cristian wrote:
> > No need to bump PR.
>
> But in this case, can be removed?

Not if PV is staying the same, no.

Cheers,
Paul

Patch

diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-testapps.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-testapps.bb
index 4b8f99b..5a55591 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-tools-testapps.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-testapps.bb
@@ -5,7 +5,7 @@ 
 SUMMARY = "Testing tools/applications"
 LICENSE = "MIT"
 
-PR = "r2"
+PR = "r3"
 
 inherit packagegroup
 
@@ -29,6 +29,10 @@  GLTOOLS = "\
     piglit \
     "
 
+3GTOOLS = "\
+    ofono-tests \
+    "
+
 X11TOOLS = "\
     fstests \
     owl-video \
@@ -53,4 +57,5 @@  RDEPENDS_${PN} = "\
     connman-client \
     ${@base_contains('DISTRO_FEATURES', 'x11', "${X11TOOLS}", "", d)} \
     ${@base_contains('DISTRO_FEATURES', 'opengl', "${GLTOOLS}", "", d)} \
+    ${@base_contains('DISTRO_FEATURES', '3g', "${3GTOOLS}", "", d)} \
     "