Patchwork lsbtest: fix comparison bashism

login
register
mail settings
Submitter Stanacar, StefanX
Date March 11, 2014, 3:40 p.m.
Message ID <1394552409-7544-1-git-send-email-stefanx.stanacar@intel.com>
Download mbox | patch
Permalink /patch/68397/
State New
Headers show

Comments

Stanacar, StefanX - March 11, 2014, 3:40 p.m.
== is a bashism use = instead.

Signed-off-by: Stefan Stanacar <stefanx.stanacar@intel.com>
---
 meta/recipes-extended/lsb/lsbtest/LSB_Test.sh | 4 ++--
 meta/recipes-extended/lsb/lsbtest_1.0.bb      | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)
Trevor Woerner - March 30, 2014, 10:55 p.m.
On 03/11/14 11:40, Stefan Stanacar wrote:
> == is a bashism use = instead.

But the first line of this script is:
#/bin/bash

Shouldn't a bash script be allowed to have bash-isms??!
Stanacar, StefanX - March 31, 2014, 7:55 a.m.
On Sun, 2014-03-30 at 18:55 -0400, Trevor Woerner wrote:
> On 03/11/14 11:40, Stefan Stanacar wrote:
> > == is a bashism use = instead.
> 
> But the first line of this script is:
> #/bin/bash
> 
> Shouldn't a bash script be allowed to have bash-isms??!

I was referring to the recipe which shouldn't have bash-isms.
Yes, the recipe installs a script which has /bin/bash, but I didn't saw
any harm in fixing that too.


Cheers,
Stefan

Patch

diff --git a/meta/recipes-extended/lsb/lsbtest/LSB_Test.sh b/meta/recipes-extended/lsb/lsbtest/LSB_Test.sh
index 12f0054..ab79985 100644
--- a/meta/recipes-extended/lsb/lsbtest/LSB_Test.sh
+++ b/meta/recipes-extended/lsb/lsbtest/LSB_Test.sh
@@ -272,12 +272,12 @@  then
 fi
 
 if ! `grep -F -q "noarch-suse" ${PLATFORM_FILE}`; then
-	if [ ${ARCH} == i686 ];then
+	if [ ${ARCH} = i686 ];then
 		echo "i486-suse" >> ${PLATFORM_FILE}
 		echo "i486-noarch" >> ${PLATFORM_FILE}
 		echo "i486-pc" >> ${PLATFORM_FILE}
 		echo "noarch-suse" >> ${PLATFORM_FILE}
-	elif [ ${ARCH} == x86_64 ]; then
+	elif [ ${ARCH} = x86_64 ]; then
 		echo "i486-suse" >> ${PLATFORM_FILE}
 		echo "i486-noarch" >> ${PLATFORM_FILE}
 		echo "i486-pc" >> ${PLATFORM_FILE}
diff --git a/meta/recipes-extended/lsb/lsbtest_1.0.bb b/meta/recipes-extended/lsb/lsbtest_1.0.bb
index a877beb..f61251e 100644
--- a/meta/recipes-extended/lsb/lsbtest_1.0.bb
+++ b/meta/recipes-extended/lsb/lsbtest_1.0.bb
@@ -19,15 +19,15 @@  do_install() {
 	install -d  ${D}/opt/lsb-test
 	install -m 0644 ${S}/packages_list ${D}/opt/lsb-test/packages_list
 	install -m 0644 ${S}/session ${D}/opt/lsb-test/session
-	if [ "${TARGET_ARCH}" == "i586" ];then
+	if [ "${TARGET_ARCH}" = "i586" ];then
 		sed -i -e 's/lsbarch/ia32/g' -e 's/targetarch/i486/g' ${D}/opt/lsb-test/packages_list
 		sed -i -e 's/targetarch/x86/g' ${D}/opt/lsb-test/session
 	fi
-	if [ "${TARGET_ARCH}" == "x86_64" ];then
+	if [ "${TARGET_ARCH}" = "x86_64" ];then
 		sed -i -e 's/lsbarch/amd64/g' -e 's/targetarch/x86_64/g' ${D}/opt/lsb-test/packages_list
 		sed -i -e 's/targetarch/x86-64/g' ${D}/opt/lsb-test/session
 	fi
-	if [ "${TARGET_ARCH}" == "powerpc" ];then
+	if [ "${TARGET_ARCH}" = "powerpc" ];then
 		sed -i -e 's/lsbarch/ppc32/g' -e 's/targetarch/ppc/g' ${D}/opt/lsb-test/packages_list
 		sed -i -e 's/targetarch/PPC32/g' ${D}/opt/lsb-test/session
 	fi
@@ -37,7 +37,7 @@  do_install() {
 	# in the package_list when MLIB=lib64 is being used.
 	# Otherwise, by default, the ppc32 LSB packages
 	# will be downloaded by LSB_Test.sh
-	if [ "${TARGET_ARCH}" == "powerpc64" ];then
+	if [ "${TARGET_ARCH}" = "powerpc64" ];then
 		if [ "${PN}" != "${BPN}" ];then
 			sed -i -e 's/lsbarch/ppc64/g' -e 's/targetarch/ppc64/g' ${D}/opt/lsb-test/packages_list
 			sed -i -e 's/targetarch/PPC64/g' ${D}/opt/lsb-test/session