Patchwork Create gstreamer-1.0 package groups

login
register
mail settings
Submitter Richard Purdie
Date March 7, 2014, 1:34 p.m.
Message ID <1394199246.12327.37.camel@ted>
Download mbox | patch
Permalink /patch/68251/
State New
Headers show

Comments

Richard Purdie - March 7, 2014, 1:34 p.m.
On Fri, 2014-03-07 at 14:24 +0100, Sébastien Mennetrier wrote:
> Hi,
> 
> 
> This patch was written in dora branch. I will try to adapt it for
> master branch and I will send a new patch ASAP.
> 
> Sorry for my mistake.
> 
I think it needs:

in future can you please say which branch it was tested on if its not master.

Cheers,

Richard
Sébastien Mennetrier - March 7, 2014, 1:36 p.m.
Ok, I will test my patch with this change on master branch.

Thanks for your help and your tips.


Regards,
Sébastien


2014-03-07 14:34 GMT+01:00 Richard Purdie <
richard.purdie@linuxfoundation.org>:

> On Fri, 2014-03-07 at 14:24 +0100, Sébastien Mennetrier wrote:
> > Hi,
> >
> >
> > This patch was written in dora branch. I will try to adapt it for
> > master branch and I will send a new patch ASAP.
> >
> > Sorry for my mistake.
> >
> I think it needs:
>
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-meta-base.bbb/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-meta-base.bb
> index 3b797f0..a73b04c 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-meta-base.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-meta-base.bb
> @@ -1,7 +1,7 @@
> DESCRIPTION = "Gstreamer1.0 package groups"
> LICENSE = "MIT"
> DEPENDS = "gstreamer1.0 gstreamer1.0-plugins-base
> gstreamer1.0-plugins-good gstreamer1.0-plugins-bad"
> -LIC_FILES_CHKSUM =
> "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> +LIC_FILES_CHKSUM =
> "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d690 \
> file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> PACKAGES = "\
>
> in future can you please say which branch it was tested on if its not
> master.
>
> Cheers,
>
> Richard
>
>
>
>
Paul Eggleton - March 7, 2014, 3:36 p.m.
On Friday 07 March 2014 14:36:59 Sébastien Mennetrier wrote:
> Ok, I will test my patch with this change on master branch.
> 
> Thanks for your help and your tips.

BTW, if this recipe inherited packagegroup (as I think it should, since that's 
what it claims to be creating) then LIC_FILES_CHKSUM isn't necessary. As a 
bonus a number of behaviours desirable for packagegroups are enabled by the 
class.

Cheers,
Paul

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-meta-base.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-meta-base.bb
index 3b797f0..a73b04c 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-meta-base.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-meta-base.bb
@@ -1,7 +1,7 @@ 
DESCRIPTION = "Gstreamer1.0 package groups"
LICENSE = "MIT"
DEPENDS = "gstreamer1.0 gstreamer1.0-plugins-base gstreamer1.0-plugins-good gstreamer1.0-plugins-bad"
-LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d690 \
file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
PACKAGES = "\