| Submitter | Dexuan Cui |
|---|---|
| Date | July 1, 2011, 9:53 a.m. |
| Message ID | <1aa106d547c9e10d025a011922335cc3ea1bbb69.1309513694.git.dexuan.cui@intel.com> |
| Download | mbox | patch |
| Permalink | /patch/6823/ |
| State | New, archived |
| Headers | show |
Comments
On Fri, 2011-07-01 at 17:53 +0800, Dexuan Cui wrote: > In the previous commit we enable largefile setting in > meta-yocto/conf/distro/poky.conf, so we need to re-build busybox to > actually enable it. I guess this would be a good case for using something like OE .dev's DISTRO_PR. It would be a bit sad if we end up having to bump PRs all over the place in oe-core whenever some random layer changes its DISTRO_FEATURES or whatever. Also, just on a stylistic issue, it's a bit confusing to talk about "the previous commit" if the commit in question was to a different file and in a different repo. If you want to refer to a specific commit it's best to mention the actual hash and, if necessary, the repo where it can be found. p.
Phil Blundell wrote: > On Fri, 2011-07-01 at 17:53 +0800, Dexuan Cui wrote: >> In the previous commit we enable largefile setting in >> meta-yocto/conf/distro/poky.conf, so we need to re-build busybox to >> actually enable it. > > I guess this would be a good case for using something like OE .dev's > DISTRO_PR. It would be a bit sad if we end up having to bump PRs all > over the place in oe-core whenever some random layer changes its > DISTRO_FEATURES or whatever. Thanks for the info! I didn't know OE.dev's DISTRO_PR before. I'm going to look at that. > Also, just on a stylistic issue, it's a bit confusing to talk about > "the previous commit" if the commit in question was to a different > file and in a different repo. If you want to refer to a specific > commit it's best to mention the actual hash and, if necessary, the > repo where it can be found. Thanks for the suggestion! I'll pay special attention to this and avoid confusion in future. Thanks, -- Dexuan
Patch
diff --git a/meta/recipes-core/busybox/busybox_1.18.4.bb b/meta/recipes-core/busybox/busybox_1.18.4.bb index cb41ac6..5883cc6 100644 --- a/meta/recipes-core/busybox/busybox_1.18.4.bb +++ b/meta/recipes-core/busybox/busybox_1.18.4.bb @@ -1,5 +1,5 @@ require busybox.inc -PR = "r4" +PR = "r5" SRC_URI = "http://www.busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \ file://udhcpscript.patch \
[YOCTO #1205 ] In the previous commit we enable largefile setting in meta-yocto/conf/distro/poky.conf, so we need to re-build busybox to actually enable it. Signed-off-by: Dexuan Cui <dexuan.cui@intel.com> --- meta/recipes-core/busybox/busybox_1.18.4.bb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)