Patchwork [4/6] lttng-modules: Exclude arm

login
register
mail settings
Submitter tom.zanussi@linux.intel.com
Date March 6, 2014, 5:09 p.m.
Message ID <a0c82119ec77c1ad5c8b6a7dc941a96eaeba3fe7.1394124934.git.tom.zanussi@linux.intel.com>
Download mbox | patch
Permalink /patch/68155/
State New
Headers show

Comments

tom.zanussi@linux.intel.com - March 6, 2014, 5:09 p.m.
From: Tom Zanussi <tom.zanussi@intel.com>

lttng-modules and gcc-4.8 don't mix, according to the lttng ML
'current_thread_info() not respecting program order with gcc 4.8.x',
so remove it from arm builds.

Without lttng-modules, lttng-tools etc don't make sense either so
exclude them as well.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb | 4 ++++
 meta/recipes-kernel/lttng/lttng-modules_2.4.0.bb                   | 4 ++++
 2 files changed, 8 insertions(+)
Phil Blundell - March 6, 2014, 5:56 p.m.
On Thu, 2014-03-06 at 11:09 -0600, Tom Zanussi wrote:
> Without lttng-modules, lttng-tools etc don't make sense either so
> exclude them as well.

This isn't entirely true; one can quite happily use the ust tracers
without the modules.  I've no idea why ust is disabled on aarch64
either.

p.
Phil Blundell - March 6, 2014, 6:04 p.m.
On Thu, 2014-03-06 at 11:09 -0600, Tom Zanussi wrote:
> +# lttng currently blacklists arm with gcc-4.8
> +COMPATIBLE_HOST = '(x86_64|i.86|powerpc|aarch64|mips).*-linux'

If the issue at hand here is GCC PR 58854 (which the lttng mailing list
thread seems to suggest it is), can't we just apply the patch for it
rather than disabling lttng-modules altogether?

p.
tom.zanussi@linux.intel.com - March 6, 2014, 6:36 p.m.
On Thu, 2014-03-06 at 17:56 +0000, Phil Blundell wrote:
> On Thu, 2014-03-06 at 11:09 -0600, Tom Zanussi wrote:
> > Without lttng-modules, lttng-tools etc don't make sense either so
> > exclude them as well.
> 
> This isn't entirely true; one can quite happily use the ust tracers
> without the modules.  I've no idea why ust is disabled on aarch64
> either.
> 

OK, I can remove the lttng-removal..

Tom

> p.
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
tom.zanussi@linux.intel.com - March 6, 2014, 6:45 p.m.
On Thu, 2014-03-06 at 18:04 +0000, Phil Blundell wrote:
> On Thu, 2014-03-06 at 11:09 -0600, Tom Zanussi wrote:
> > +# lttng currently blacklists arm with gcc-4.8
> > +COMPATIBLE_HOST = '(x86_64|i.86|powerpc|aarch64|mips).*-linux'
> 
> If the issue at hand here is GCC PR 58854 (which the lttng mailing list
> thread seems to suggest it is), can't we just apply the patch for it
> rather than disabling lttng-modules altogether?
> 

Well, I think it's more than that - there's apparently an unbalanced
preempt_disable in lttng somewhere that's the real root of the problem:

http://gcc.gnu.org/ml/gcc/2013-11/msg00393.html

So lttng is still broken, and the blacklist is still in place in the
lttng code.

Tom

> p.
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
index 4a97c24..8771dbe 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
@@ -52,15 +52,19 @@  SYSTEMTAP_aarch64 = ""
 LTTNGUST = "lttng-ust"
 LTTNGUST_libc-uclibc = ""
 LTTNGUST_aarch64 = ""
+LTTNGUST_arm = ""
 
 LTTNGTOOLS = "lttng-tools"
 LTTNGTOOLS_aarch64 = ""
+LTTNGTOOLS_arm = ""
 
 LTTNGMODULES = "lttng-modules"
 LTTNGMODULES_aarch64 = ""
+LTTNGMODULES_arm = ""
 
 BABELTRACE = "babeltrace"
 BABELTRACE_aarch64 = ""
+BABELTRACE_arm = ""
 
 # valgrind does not work on mips
 
diff --git a/meta/recipes-kernel/lttng/lttng-modules_2.4.0.bb b/meta/recipes-kernel/lttng/lttng-modules_2.4.0.bb
index 0b7d5e8..79d9382 100644
--- a/meta/recipes-kernel/lttng/lttng-modules_2.4.0.bb
+++ b/meta/recipes-kernel/lttng/lttng-modules_2.4.0.bb
@@ -13,6 +13,9 @@  inherit module
 SRCREV = "fb2c37799306d16fb590aebee6fad8be431264b7"
 PV = "2.4.0"
 
+# lttng currently blacklists arm with gcc-4.8
+COMPATIBLE_HOST = '(x86_64|i.86|powerpc|aarch64|mips).*-linux'
+
 SRC_URI = "git://git.lttng.org/lttng-modules.git;branch=stable-2.4 \
            file://lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch"
 
@@ -20,6 +23,7 @@  export INSTALL_MOD_DIR="kernel/lttng-modules"
 export KERNEL_SRC="${STAGING_KERNEL_DIR}"
 
 
+
 S = "${WORKDIR}/git"
 
 do_install_append() {