Patchwork [meta-oe] bash-completion: remove allarch

login
register
mail settings
Submitter Martin Jansa
Date March 6, 2014, 5:04 p.m.
Message ID <1394125490-2945-1-git-send-email-Martin.Jansa@gmail.com>
Download mbox | patch
Permalink /patch/68147/
State Accepted, archived
Headers show

Comments

Martin Jansa - March 6, 2014, 5:04 p.m.
* it has runtime dependency on TUNE_PKGARCH bash, so it cannot be allarch

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta-oe/recipes-support/bash-completion/bash-completion_2.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Paul Eggleton - March 6, 2014, 5:59 p.m.
On Thursday 06 March 2014 18:04:50 Martin Jansa wrote:
> * it has runtime dependency on TUNE_PKGARCH bash, so it cannot be allarch

As we've already discussed this is not universally true. There are other ways 
to solve this.

Cheers,
Paul
Martin Jansa - March 6, 2014, 7:21 p.m.
On Thu, Mar 06, 2014 at 05:59:29PM +0000, Paul Eggleton wrote:
> On Thursday 06 March 2014 18:04:50 Martin Jansa wrote:
> > * it has runtime dependency on TUNE_PKGARCH bash, so it cannot be allarch
> 
> As we've already discussed this is not universally true. There are other ways 
> to solve this.

Like making it special case like packagegroups? That is still making me
headaches when some library (for some reason) included in packagegroup
is renamed thanks to debian.bbclass and packagegroup isn't rebuilt, so
it breaks do_rootfs..

I would rather build bash-completion only once per architecture than
rebuilding it as "allarch" every time I'm building for MACHINE with
different TUNE_PKGARCH.

Patch

diff --git a/meta-oe/recipes-support/bash-completion/bash-completion_2.0.bb b/meta-oe/recipes-support/bash-completion/bash-completion_2.0.bb
index ad7fd28..155fe90 100644
--- a/meta-oe/recipes-support/bash-completion/bash-completion_2.0.bb
+++ b/meta-oe/recipes-support/bash-completion/bash-completion_2.0.bb
@@ -16,7 +16,7 @@  SRC_URI[sha256sum] = "e5a490a4301dfb228361bdca2ffca597958e47dd6056005ef9393a5852
 
 PARALLEL_MAKE = ""
 
-inherit allarch autotools
+inherit autotools
 
 do_install_append() {
 	install -d ${D}${sysconfdir}/bash_completion.d/