Patchwork base.bbclass: Deprecate the PRINC logic

login
register
mail settings
Submitter Richard Purdie
Date March 5, 2014, 2:20 p.m.
Message ID <1394029227.31845.119.camel@ted>
Download mbox | patch
Permalink /patch/68061/
State New
Headers show

Comments

Richard Purdie - March 5, 2014, 2:20 p.m.
The PRINC logic is now deprecated, the PR server should be used to handle
the automatic incrementing of the PR (package release) field.  Add a warning 
message to alert users to the change. The functionality will be removed
in the next release cycle.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
Otavio Salvador - March 5, 2014, 3:32 p.m.
On Wed, Mar 5, 2014 at 11:20 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> The PRINC logic is now deprecated, the PR server should be used to handle
> the automatic incrementing of the PR (package release) field.  Add a warning
> message to alert users to the change. The functionality will be removed
> in the next release cycle.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Acked-by: Otavio Salvador <otavio@ossystems.com.br>

Patch

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 3e9051c..27b5f53 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -456,8 +456,12 @@  python () {
             appendVar('EXTRA_OECONF', extraconf)
 
     # If PRINC is set, try and increase the PR value by the amount specified
+    # The PR server is now the preferred way to handle PR changes based on
+    # the checksum of the recipe (including bbappend).  The PRINC is now
+    # obsolete.  Return a warning to the user.
     princ = d.getVar('PRINC', True)
     if princ and princ != "0":
+        bb.warn("Use of PRINC was detected in the recipe %s (or one of its .bbappends)\nUse of PRINC is deprecated.  The PR server should be used to automatically increment the PR.  See: https://wiki.yoctoproject.org/wiki/PR_Service." % d.getVar("FILE", True))
         pr = d.getVar('PR', True)
         pr_prefix = re.search("\D+",pr)
         prval = re.search("\d+",pr)