glibc: ptest: Fix glibc-tests package issue

Message ID 20220415111159.120195-1-pgowda.cve@gmail.com
State Accepted, archived
Commit 5555e7cf935b047a3dc3228d26bf0fd52eb425e5
Headers show
Series glibc: ptest: Fix glibc-tests package issue | expand

Commit Message

Pgowda April 15, 2022, 11:11 a.m. UTC
The current default DISTRO_FEATURES does not support ptest.
Hence, the following error is generated during "bitbake glibc-tests".
ERROR: glibc-tests-2.35-r0 do_package: QA Issue: glibc-tests:
Files/directories were installed but not shipped in any package
The issue is not reproduced with "DISTRO = Yocto" as DISTRO_FEATURES
in Yocto supports ptest. However, when we run "glibc-tests" using
Open-embedded master sources; it generates the error as default
DISTRO is used.

Signed-off-by: pgowda <pgowda.cve@gmail.com>
---
 meta/conf/distro/include/default-distrovars.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Purdie April 15, 2022, 1:02 p.m. UTC | #1
On Fri, 2022-04-15 at 04:11 -0700, pgowda wrote:
> The current default DISTRO_FEATURES does not support ptest.
> Hence, the following error is generated during "bitbake glibc-tests".
> ERROR: glibc-tests-2.35-r0 do_package: QA Issue: glibc-tests:
> Files/directories were installed but not shipped in any package
> The issue is not reproduced with "DISTRO = Yocto" as DISTRO_FEATURES
> in Yocto supports ptest. However, when we run "glibc-tests" using
> Open-embedded master sources; it generates the error as default
> DISTRO is used.
> 
> Signed-off-by: pgowda <pgowda.cve@gmail.com>
> ---
>  meta/conf/distro/include/default-distrovars.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This isn't quite the right approach, we should probably skip parsing of glibc-
tests if ptests aren't in DISTRO_FEATURES?

Cheers,

Richard

Patch

diff --git a/meta/conf/distro/include/default-distrovars.inc b/meta/conf/distro/include/default-distrovars.inc
index 3edba1b6d0..d6060ad3ba 100644
--- a/meta/conf/distro/include/default-distrovars.inc
+++ b/meta/conf/distro/include/default-distrovars.inc
@@ -16,7 +16,7 @@  DISTRO_FEATURES_DEFAULT:remove:riscv32 = "seccomp"
 # seccomp is not yet ported to ARC
 DISTRO_FEATURES_DEFAULT:remove:arc = "seccomp"
 
-DISTRO_FEATURES_DEFAULT ?= "acl alsa argp bluetooth debuginfod ext2 ipv4 ipv6 largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g nfc x11 vfat seccomp"
+DISTRO_FEATURES_DEFAULT ?= "acl alsa argp bluetooth debuginfod ext2 ipv4 ipv6 largefile pcmcia usbgadget usbhost wifi xattr nfs zeroconf pci 3g nfc x11 vfat seccomp ptest"
 DISTRO_FEATURES ?= "${DISTRO_FEATURES_DEFAULT}"
 IMAGE_FEATURES ?= ""