Patchwork [meta-qt5,v4,2/2] packagegroup-qt5-toolchain-target: include all modules for development

login
register
mail settings
Submitter Jonathan Liu
Date March 2, 2014, 4:22 a.m.
Message ID <1393734165-15082-2-git-send-email-net147@gmail.com>
Download mbox | patch
Permalink /patch/67805/
State Superseded, archived
Delegated to: Otavio Salvador
Headers show

Comments

Jonathan Liu - March 2, 2014, 4:22 a.m.
This adds the necessary target packages for development with all of the
Qt 5 modules.

Signed-off-by: Jonathan Liu <net147@gmail.com>
---
 .../packagegroup-qt5-toolchain-target.bb           | 80 ++++++++++++++++++----
 1 file changed, 65 insertions(+), 15 deletions(-)
Otavio Salvador - March 3, 2014, 7:53 p.m.
On Sun, Mar 2, 2014 at 1:22 AM, Jonathan Liu <net147@gmail.com> wrote:
> This adds the necessary target packages for development with all of the
> Qt 5 modules.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>

Why are you adding qttools here? this is not need for toolchain use,
is it? It is need for host.
Jonathan Liu - March 4, 2014, 3:43 a.m.
On 4 March 2014 06:53, Otavio Salvador <otavio@ossystems.com.br> wrote:
> On Sun, Mar 2, 2014 at 1:22 AM, Jonathan Liu <net147@gmail.com> wrote:
>> This adds the necessary target packages for development with all of the
>> Qt 5 modules.
>>
>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>
> Why are you adding qttools here? this is not need for toolchain use,
> is it? It is need for host.

The QtTools module includes components that may be used by
applications - http://qt-project.org/doc/qt-5/qtmodules.html#qt-tools

Regards,
Jonathan
Otavio Salvador - March 4, 2014, 2:34 p.m.
On Tue, Mar 4, 2014 at 12:43 AM, Jonathan Liu <net147@gmail.com> wrote:
> On 4 March 2014 06:53, Otavio Salvador <otavio@ossystems.com.br> wrote:
>> On Sun, Mar 2, 2014 at 1:22 AM, Jonathan Liu <net147@gmail.com> wrote:
>>> This adds the necessary target packages for development with all of the
>>> Qt 5 modules.
>>>
>>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>>
>> Why are you adding qttools here? this is not need for toolchain use,
>> is it? It is need for host.
>
> The QtTools module includes components that may be used by
> applications - http://qt-project.org/doc/qt-5/qtmodules.html#qt-tools

From the doc it is not clear to me how it will be used in the target,
it seems something used in host.

Could you help me to understand your reasoning for it?
Denys Dmytriyenko - March 4, 2014, 8 p.m.
On Sun, Mar 02, 2014 at 03:22:45PM +1100, Jonathan Liu wrote:
> This adds the necessary target packages for development with all of the
> Qt 5 modules.
> 
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>  .../packagegroup-qt5-toolchain-target.bb           | 80 ++++++++++++++++++----
>  1 file changed, 65 insertions(+), 15 deletions(-)
> 
> diff --git a/recipes-qt/packagegroups/packagegroup-qt5-toolchain-target.bb b/recipes-qt/packagegroups/packagegroup-qt5-toolchain-target.bb
> index 997df18..25983dc 100644
> --- a/recipes-qt/packagegroups/packagegroup-qt5-toolchain-target.bb
> +++ b/recipes-qt/packagegroups/packagegroup-qt5-toolchain-target.bb
> @@ -9,32 +9,82 @@ PACKAGEGROUP_DISABLE_COMPLEMENTARY = "1"
>  
>  # Requires meta-ruby to work
>  USE_RUBY = " \
> -    qtwebkit-mkspecs \
>      qtwebkit-dev \
> +    qtwebkit-mkspecs \
> +    qtwebkit-qmlplugins \
> +"
> +
> +# Requires Wayland to work
> +USE_WAYLAND = " \
> +    qtwayland-dev \
> +    qtwayland-mkspecs \
> +    qtwayland-plugins \
> +    qtwayland-tools \
> +"
> +
> +# Requires X11 to work
> +USE_X11 = " \
> +    qtx11extras-dev \
> +    qtx11extras-mkspecs \
>  "
>  
>  RDEPENDS_${PN} += " \
>      packagegroup-core-standalone-sdk-target \
>      libsqlite3-dev \
> -    qtbase-mkspecs \
> -    qtscript-mkspecs \
> -    qtxmlpatterns-mkspecs \
> -    qtdeclarative-mkspecs \
> -    qtsensors-mkspecs \
> +    qt3d-dev \
>      qt3d-mkspecs \
> -    qtlocation-mkspecs \
> -    qtsvg-mkspecs \
> +    qt3d-qmlplugins \
>      qtbase-dev \
> +    qtbase-fonts \
> +    qtbase-mkspecs \
> +    qtbase-plugins \
> +    qtbase-staticdev \
> +    qtconnectivity-dev \
> +    qtconnectivity-mkspecs \
> +    qtconnectivity-qmlplugins \
>      qtdeclarative-dev \
> -    qtscript-dev \
> -    qt3d-dev \
> +    qtdeclarative-mkspecs \
> +    qtdeclarative-plugins \
> +    qtdeclarative-qmlplugins \
> +    qtdeclarative-staticdev \
> +    qtgraphicaleffects-qmlplugins \
> +    qtimageformats-dev \
> +    qtimageformats-plugins \
>      qtlocation-dev \
> +    qtlocation-mkspecs \
> +    qtlocation-plugins \
> +    qtlocation-qmlplugins \
> +    qtmultimedia-dev \
> +    qtmultimedia-mkspecs \
> +    qtmultimedia-plugins \
> +    qtmultimedia-qmlplugins \
> +    qtquick1-dev \
> +    qtquick1-mkspecs \
> +    qtquick1-plugins \
> +    qtquick1-qmlplugins \
> +    qtquickcontrols-qmlplugins \
> +    qtscript-dev \
> +    qtscript-mkspecs \
>      qtsensors-dev \
> +    qtsensors-mkspecs \
> +    qtsensors-plugins \
> +    qtsensors-qmlplugins \
> +    qtserialport-dev \
> +    qtserialport-mkspecs \
>      qtsvg-dev \
> -    qtxmlpatterns-dev \
> -    qtdeclarative-dev \
> -    qtdeclarative-plugins \
> -    qtdeclarative-qmlplugins \
> -    qtgraphicaleffects-dev \
> +    qtsvg-mkspecs \
> +    qtsvg-plugins \
> +    qtsystems-dev \
> +    qtsystems-mkspecs \
> +    qtsystems-qmlplugins \
> +    qttools-dev \
> +    qttools-mkspecs \
> +    qttools-plugins \
> +    qttools-staticdev \
> +    qttools-tools \
> +    ${@base_contains('DISTRO_FEATURES', 'wayland', '${USE_WAYLAND}', '', d)} \
>      ${@base_contains('BBFILE_COLLECTIONS', 'ruby-layer', '${USE_RUBY}', '', d)} \
> +    ${@base_contains('DISTRO_FEATURES', 'x11', '${USE_X11}', '', d)} \

Like I said in v2 comment - I like the conditionals here. Can we possibly make 
other modules as conditionals as well? I.e. qt3d or qtwebkit when they are not 
built for the target?
Jonathan Liu - March 11, 2014, 11:39 a.m.
On 5/03/2014 1:34 AM, Otavio Salvador wrote:
> On Tue, Mar 4, 2014 at 12:43 AM, Jonathan Liu <net147@gmail.com> wrote:
>> On 4 March 2014 06:53, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>> On Sun, Mar 2, 2014 at 1:22 AM, Jonathan Liu <net147@gmail.com> wrote:
>>>> This adds the necessary target packages for development with all of the
>>>> Qt 5 modules.
>>>>
>>>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>>> Why are you adding qttools here? this is not need for toolchain use,
>>> is it? It is need for host.
>> The QtTools module includes components that may be used by
>> applications - http://qt-project.org/doc/qt-5/qtmodules.html#qt-tools
>  From the doc it is not clear to me how it will be used in the target,
> it seems something used in host.
>
> Could you help me to understand your reasoning for it?
>
It includes Qt Help which is used to implement context-sensitive help to 
the user in Qt applications.

Regards,
Jonathan
Otavio Salvador - March 12, 2014, 6:42 p.m.
On Tue, Mar 11, 2014 at 8:39 AM, Jonathan Liu <net147@gmail.com> wrote:
> On 5/03/2014 1:34 AM, Otavio Salvador wrote:
>>
>> On Tue, Mar 4, 2014 at 12:43 AM, Jonathan Liu <net147@gmail.com> wrote:
>>>
>>> On 4 March 2014 06:53, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>>>
>>>> On Sun, Mar 2, 2014 at 1:22 AM, Jonathan Liu <net147@gmail.com> wrote:
>>>>>
>>>>> This adds the necessary target packages for development with all of the
>>>>> Qt 5 modules.
>>>>>
>>>>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>>>>
>>>> Why are you adding qttools here? this is not need for toolchain use,
>>>> is it? It is need for host.
>>>
>>> The QtTools module includes components that may be used by
>>> applications - http://qt-project.org/doc/qt-5/qtmodules.html#qt-tools
>>
>>  From the doc it is not clear to me how it will be used in the target,
>> it seems something used in host.
>>
>> Could you help me to understand your reasoning for it?
>>
> It includes Qt Help which is used to implement context-sensitive help to the
> user in Qt applications.

I am fine with it than; do you have any other change pending? please
let me know or I pick v2 of this.
Jonathan Liu - March 12, 2014, 9:03 p.m.
On 13/03/2014 5:42 AM, Otavio Salvador wrote:
> On Tue, Mar 11, 2014 at 8:39 AM, Jonathan Liu <net147@gmail.com> wrote:
>> On 5/03/2014 1:34 AM, Otavio Salvador wrote:
>>> On Tue, Mar 4, 2014 at 12:43 AM, Jonathan Liu <net147@gmail.com> wrote:
>>>> On 4 March 2014 06:53, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>>>> On Sun, Mar 2, 2014 at 1:22 AM, Jonathan Liu <net147@gmail.com> wrote:
>>>>>> This adds the necessary target packages for development with all of the
>>>>>> Qt 5 modules.
>>>>>>
>>>>>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>>>>> Why are you adding qttools here? this is not need for toolchain use,
>>>>> is it? It is need for host.
>>>> The QtTools module includes components that may be used by
>>>> applications - http://qt-project.org/doc/qt-5/qtmodules.html#qt-tools
>>>   From the doc it is not clear to me how it will be used in the target,
>>> it seems something used in host.
>>>
>>> Could you help me to understand your reasoning for it?
>>>
>> It includes Qt Help which is used to implement context-sensitive help to the
>> user in Qt applications.
> I am fine with it than; do you have any other change pending? please
> let me know or I pick v2 of this.
>
I don't have any update pending. Please use the latest patch series (v4).

Regards,
Jonathan
Otavio Salvador - March 12, 2014, 10:37 p.m.
Hello,

On Wed, Mar 12, 2014 at 6:03 PM, Jonathan Liu <net147@gmail.com> wrote:
> On 13/03/2014 5:42 AM, Otavio Salvador wrote:
>>
>> On Tue, Mar 11, 2014 at 8:39 AM, Jonathan Liu <net147@gmail.com> wrote:
>>>
>>> On 5/03/2014 1:34 AM, Otavio Salvador wrote:
>>>>
>>>> On Tue, Mar 4, 2014 at 12:43 AM, Jonathan Liu <net147@gmail.com> wrote:
>>>>>
>>>>> On 4 March 2014 06:53, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>>>>>
>>>>>> On Sun, Mar 2, 2014 at 1:22 AM, Jonathan Liu <net147@gmail.com> wrote:
>>>>>>>
>>>>>>> This adds the necessary target packages for development with all of
>>>>>>> the
>>>>>>> Qt 5 modules.
>>>>>>>
>>>>>>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>>>>>>
>>>>>> Why are you adding qttools here? this is not need for toolchain use,
>>>>>> is it? It is need for host.
>>>>>
>>>>> The QtTools module includes components that may be used by
>>>>> applications - http://qt-project.org/doc/qt-5/qtmodules.html#qt-tools
>>>>
>>>>   From the doc it is not clear to me how it will be used in the target,
>>>> it seems something used in host.
>>>>
>>>> Could you help me to understand your reasoning for it?
>>>>
>>> It includes Qt Help which is used to implement context-sensitive help to
>>> the
>>> user in Qt applications.
>>
>> I am fine with it than; do you have any other change pending? please
>> let me know or I pick v2 of this.
>>
> I don't have any update pending. Please use the latest patch series (v4).

NOTE: Runtime target 'qtquick1-dev' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['qtquick1-dev',
'qtwebkit', 'ruby-native']
NOTE: Runtime target 'packagegroup-qt5-toolchain-target' is
unbuildable, removing...
Missing or unbuildable dependency chain was:
['packagegroup-qt5-toolchain-target', 'qtquick1-dev', 'qtwebkit',
'ruby-native']

This failed to build with Ruby disabled :-)
Jonathan Liu - March 12, 2014, 10:47 p.m.
On 13/03/2014 9:37 AM, Otavio Salvador wrote:
> Hello,
>
> On Wed, Mar 12, 2014 at 6:03 PM, Jonathan Liu <net147@gmail.com> wrote:
>> On 13/03/2014 5:42 AM, Otavio Salvador wrote:
>>> On Tue, Mar 11, 2014 at 8:39 AM, Jonathan Liu <net147@gmail.com> wrote:
>>>> On 5/03/2014 1:34 AM, Otavio Salvador wrote:
>>>>> On Tue, Mar 4, 2014 at 12:43 AM, Jonathan Liu <net147@gmail.com> wrote:
>>>>>> On 4 March 2014 06:53, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>>>>>> On Sun, Mar 2, 2014 at 1:22 AM, Jonathan Liu <net147@gmail.com> wrote:
>>>>>>>> This adds the necessary target packages for development with all of
>>>>>>>> the
>>>>>>>> Qt 5 modules.
>>>>>>>>
>>>>>>>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>>>>>>> Why are you adding qttools here? this is not need for toolchain use,
>>>>>>> is it? It is need for host.
>>>>>> The QtTools module includes components that may be used by
>>>>>> applications - http://qt-project.org/doc/qt-5/qtmodules.html#qt-tools
>>>>>    From the doc it is not clear to me how it will be used in the target,
>>>>> it seems something used in host.
>>>>>
>>>>> Could you help me to understand your reasoning for it?
>>>>>
>>>> It includes Qt Help which is used to implement context-sensitive help to
>>>> the
>>>> user in Qt applications.
>>> I am fine with it than; do you have any other change pending? please
>>> let me know or I pick v2 of this.
>>>
>> I don't have any update pending. Please use the latest patch series (v4).
> NOTE: Runtime target 'qtquick1-dev' is unbuildable, removing...
> Missing or unbuildable dependency chain was: ['qtquick1-dev',
> 'qtwebkit', 'ruby-native']
> NOTE: Runtime target 'packagegroup-qt5-toolchain-target' is
> unbuildable, removing...
> Missing or unbuildable dependency chain was:
> ['packagegroup-qt5-toolchain-target', 'qtquick1-dev', 'qtwebkit',
> 'ruby-native']
>
> This failed to build with Ruby disabled :-)
>
Fixed with v5 patch series.

Regards,
Jonathan

Patch

diff --git a/recipes-qt/packagegroups/packagegroup-qt5-toolchain-target.bb b/recipes-qt/packagegroups/packagegroup-qt5-toolchain-target.bb
index 997df18..25983dc 100644
--- a/recipes-qt/packagegroups/packagegroup-qt5-toolchain-target.bb
+++ b/recipes-qt/packagegroups/packagegroup-qt5-toolchain-target.bb
@@ -9,32 +9,82 @@  PACKAGEGROUP_DISABLE_COMPLEMENTARY = "1"
 
 # Requires meta-ruby to work
 USE_RUBY = " \
-    qtwebkit-mkspecs \
     qtwebkit-dev \
+    qtwebkit-mkspecs \
+    qtwebkit-qmlplugins \
+"
+
+# Requires Wayland to work
+USE_WAYLAND = " \
+    qtwayland-dev \
+    qtwayland-mkspecs \
+    qtwayland-plugins \
+    qtwayland-tools \
+"
+
+# Requires X11 to work
+USE_X11 = " \
+    qtx11extras-dev \
+    qtx11extras-mkspecs \
 "
 
 RDEPENDS_${PN} += " \
     packagegroup-core-standalone-sdk-target \
     libsqlite3-dev \
-    qtbase-mkspecs \
-    qtscript-mkspecs \
-    qtxmlpatterns-mkspecs \
-    qtdeclarative-mkspecs \
-    qtsensors-mkspecs \
+    qt3d-dev \
     qt3d-mkspecs \
-    qtlocation-mkspecs \
-    qtsvg-mkspecs \
+    qt3d-qmlplugins \
     qtbase-dev \
+    qtbase-fonts \
+    qtbase-mkspecs \
+    qtbase-plugins \
+    qtbase-staticdev \
+    qtconnectivity-dev \
+    qtconnectivity-mkspecs \
+    qtconnectivity-qmlplugins \
     qtdeclarative-dev \
-    qtscript-dev \
-    qt3d-dev \
+    qtdeclarative-mkspecs \
+    qtdeclarative-plugins \
+    qtdeclarative-qmlplugins \
+    qtdeclarative-staticdev \
+    qtgraphicaleffects-qmlplugins \
+    qtimageformats-dev \
+    qtimageformats-plugins \
     qtlocation-dev \
+    qtlocation-mkspecs \
+    qtlocation-plugins \
+    qtlocation-qmlplugins \
+    qtmultimedia-dev \
+    qtmultimedia-mkspecs \
+    qtmultimedia-plugins \
+    qtmultimedia-qmlplugins \
+    qtquick1-dev \
+    qtquick1-mkspecs \
+    qtquick1-plugins \
+    qtquick1-qmlplugins \
+    qtquickcontrols-qmlplugins \
+    qtscript-dev \
+    qtscript-mkspecs \
     qtsensors-dev \
+    qtsensors-mkspecs \
+    qtsensors-plugins \
+    qtsensors-qmlplugins \
+    qtserialport-dev \
+    qtserialport-mkspecs \
     qtsvg-dev \
-    qtxmlpatterns-dev \
-    qtdeclarative-dev \
-    qtdeclarative-plugins \
-    qtdeclarative-qmlplugins \
-    qtgraphicaleffects-dev \
+    qtsvg-mkspecs \
+    qtsvg-plugins \
+    qtsystems-dev \
+    qtsystems-mkspecs \
+    qtsystems-qmlplugins \
+    qttools-dev \
+    qttools-mkspecs \
+    qttools-plugins \
+    qttools-staticdev \
+    qttools-tools \
+    ${@base_contains('DISTRO_FEATURES', 'wayland', '${USE_WAYLAND}', '', d)} \
     ${@base_contains('BBFILE_COLLECTIONS', 'ruby-layer', '${USE_RUBY}', '', d)} \
+    ${@base_contains('DISTRO_FEATURES', 'x11', '${USE_X11}', '', d)} \
+    qtxmlpatterns-dev \
+    qtxmlpatterns-mkspecs \
 "