Patchwork musicbrainz: Build with B=S

login
register
mail settings
Submitter mike.looijmans@topic.nl
Date March 1, 2014, 5:54 p.m.
Message ID <1393696487-30736-1-git-send-email-mike.looijmans@topic.nl>
Download mbox | patch
Permalink /patch/67781/
State Accepted, archived
Headers show

Comments

mike.looijmans@topic.nl - March 1, 2014, 5:54 p.m.
From: Mike Looijmans <milo-software@users.sourceforge.net>

This recipe doesn't work when B!=S, so force B=$S to fix the failure.

Signed-off-by: Mike Looijmans <milo-software@users.sourceforge.net>
---
 .../musicbrainz/libmusicbrainz_git.bb              |    3 +++
 1 file changed, 3 insertions(+)
Martin Jansa - March 5, 2014, 6:08 p.m.
On Sat, Mar 01, 2014 at 06:54:47PM +0100, mike.looijmans@topic.nl wrote:
> From: Mike Looijmans <milo-software@users.sourceforge.net>
> 
> This recipe doesn't work when B!=S, so force B=$S to fix the failure.
> 
> Signed-off-by: Mike Looijmans <milo-software@users.sourceforge.net>

What's the relation of this change to
http://patchwork.openembedded.org/patch/67597/
?

> ---
>  .../musicbrainz/libmusicbrainz_git.bb              |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
> index f6a8f53..4cc04b8 100644
> --- a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
> +++ b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
> @@ -37,3 +37,6 @@ do_configure_prepend() {
>  
>  EXTRA_OECMAKE = "-DLIB_INSTALL_DIR:PATH=${libdir} \
>                   -DIMPORT_EXECUTABLES=build-native/ImportExecutables.cmake"
> +
> +# out-of-tree building doesn't appear to work for this package.
> +B = "${S}"
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
mike.looijmans@topic.nl - March 5, 2014, 7:49 p.m.
On 5-3-2014 19:08, Martin Jansa wrote:
> On Sat, Mar 01, 2014 at 06:54:47PM +0100, mike.looijmans@topic.nl wrote:
>> From: Mike Looijmans <milo-software@users.sourceforge.net>
>>
>> This recipe doesn't work when B!=S, so force B=$S to fix the failure.
>>
>> Signed-off-by: Mike Looijmans <milo-software@users.sourceforge.net>
> What's the relation of this change to
> http://patchwork.openembedded.org/patch/67597/
> ?

I suspect they both accomplish the same: Make the project compile again. 
Mine is the simplistic approach I guess - I did the least I could 
possible get away with... "Theirs" looks more like they actually 
understand what's going on

Mike.


>> ---
>>   .../musicbrainz/libmusicbrainz_git.bb              |    3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
>> index f6a8f53..4cc04b8 100644
>> --- a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
>> +++ b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
>> @@ -37,3 +37,6 @@ do_configure_prepend() {
>>   
>>   EXTRA_OECMAKE = "-DLIB_INSTALL_DIR:PATH=${libdir} \
>>                    -DIMPORT_EXECUTABLES=build-native/ImportExecutables.cmake"
>> +
>> +# out-of-tree building doesn't appear to work for this package.
>> +B = "${S}"
>> -- 
>> 1.7.9.5
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Tim Orling - March 9, 2014, 4:54 a.m.
I may have gone extra steps to get to the bottom of the build error, but my
solution is not even slightly pretty. If it works to just set $B=$S that is
simpler than my do_configure hack. Otherwise we'd have to look into a
change in cmake class which I doubt is justified--or further patch
libmusicbrainz.
KISS.

--Tim


On Wed, Mar 5, 2014 at 11:49 AM, Mike Looijmans <mike.looijmans@topic.nl>wrote:

> On 5-3-2014 19:08, Martin Jansa wrote:
>
>> On Sat, Mar 01, 2014 at 06:54:47PM +0100, mike.looijmans@topic.nl wrote:
>>
>>> From: Mike Looijmans <milo-software@users.sourceforge.net>
>>>
>>> This recipe doesn't work when B!=S, so force B=$S to fix the failure.
>>>
>>> Signed-off-by: Mike Looijmans <milo-software@users.sourceforge.net>
>>>
>> What's the relation of this change to
>> http://patchwork.openembedded.org/patch/67597/
>> ?
>>
>
> I suspect they both accomplish the same: Make the project compile again.
> Mine is the simplistic approach I guess - I did the least I could possible
> get away with... "Theirs" looks more like they actually understand what's
> going on
>
> Mike.
>
>
>
>  ---
>>>   .../musicbrainz/libmusicbrainz_git.bb              |    3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/meta-multimedia/recipes-multimedia/musicbrainz/libmusi
>>> cbrainz_git.bb b/meta-multimedia/recipes-multimedia/musicbrainz/libmusi
>>> cbrainz_git.bb
>>> index f6a8f53..4cc04b8 100644
>>> --- a/meta-multimedia/recipes-multimedia/musicbrainz/libmusi
>>> cbrainz_git.bb
>>> +++ b/meta-multimedia/recipes-multimedia/musicbrainz/libmusi
>>> cbrainz_git.bb
>>> @@ -37,3 +37,6 @@ do_configure_prepend() {
>>>     EXTRA_OECMAKE = "-DLIB_INSTALL_DIR:PATH=${libdir} \
>>>                    -DIMPORT_EXECUTABLES=build-native/ImportExecutables.
>>> cmake"
>>> +
>>> +# out-of-tree building doesn't appear to work for this package.
>>> +B = "${S}"
>>> --
>>> 1.7.9.5
>>>
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>>
>>
>
> --
> Mike Looijmans
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Patch

diff --git a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
index f6a8f53..4cc04b8 100644
--- a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
+++ b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
@@ -37,3 +37,6 @@  do_configure_prepend() {
 
 EXTRA_OECMAKE = "-DLIB_INSTALL_DIR:PATH=${libdir} \
                  -DIMPORT_EXECUTABLES=build-native/ImportExecutables.cmake"
+
+# out-of-tree building doesn't appear to work for this package.
+B = "${S}"