Patchwork [meta-fsl-arm,1/4] u-boot-timesys: Add version 2011.12

login
register
mail settings
Submitter Tony Felice
Date Feb. 27, 2014, 6:47 p.m.
Message ID <1393526867-18490-2-git-send-email-tony.felice@timesys.com>
Download mbox | patch
Permalink /patch/67627/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Tony Felice - Feb. 27, 2014, 6:47 p.m.
Add some commits over u-boot 2011.12 with board support for the pcl052 and
pcm052 platforms, that include:

* Add NAND boot support
* Add FEC1 support
* Fix DDR3 settings for pcm052 1.1 silicon
* Fix SDHC issues
* New machine definitions (i.e. pcl052, pcm052)

and more, for a total of 25 commits. Included in these commits is also base
support for the Vybrid Tower platform.

Commits from the u-boot-cfi-flash fork from 2012-03-21 and earlier have also
been added, starting from commit 85c344e5f98: "cfi: fix the incomplete erased
status check in buffer write".

This version has been tested on the pcl052 and pcm052 platforms.

Signed-off-by: Anthony Felice <tony.felice@timesys.com>
---
 recipes-bsp/u-boot/u-boot-timesys_2011.12.bb | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 recipes-bsp/u-boot/u-boot-timesys_2011.12.bb
Daiane Angolini - Feb. 27, 2014, 7:37 p.m.
> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Anthony Felice
> Sent: Thursday, February 27, 2014 3:48 PM
> To: meta-freescale@yoctoproject.org
> Subject: [meta-freescale] [meta-fsl-arm][PATCH 1/4] u-boot-timesys: Add
> version 2011.12
> 
> Add some commits over u-boot 2011.12 with board support for the pcl052 and
> pcm052 platforms, that include:
> 
> * Add NAND boot support
> * Add FEC1 support
> * Fix DDR3 settings for pcm052 1.1 silicon
> * Fix SDHC issues
> * New machine definitions (i.e. pcl052, pcm052)
> 
> and more, for a total of 25 commits. Included in these commits is also base
> support for the Vybrid Tower platform.
> 
> Commits from the u-boot-cfi-flash fork from 2012-03-21 and earlier have
> also been added, starting from commit 85c344e5f98: "cfi: fix the incomplete
> erased status check in buffer write".
> 
> This version has been tested on the pcl052 and pcm052 platforms.

Great commit log!


> 
> Signed-off-by: Anthony Felice <tony.felice@timesys.com>
> ---
>  recipes-bsp/u-boot/u-boot-timesys_2011.12.bb | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 recipes-bsp/u-boot/u-boot-timesys_2011.12.bb
> 
> diff --git a/recipes-bsp/u-boot/u-boot-timesys_2011.12.bb b/recipes-bsp/u-
> boot/u-boot-timesys_2011.12.bb
> new file mode 100644
> index 0000000..4f103fd
> --- /dev/null
> +++ b/recipes-bsp/u-boot/u-boot-timesys_2011.12.bb
> @@ -0,0 +1,18 @@

Shouldn´t have a Copyright line here?

> +DESCRIPTION = "bootloader for Vybrid platforms"
> +require recipes-bsp/u-boot/u-boot.inc
> +
> +PROVIDES += "u-boot"
> +
> +LICENSE = "GPLv2+"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=1707d6db1d42237583f50183a5651ecb"
> +
> +SRCBRANCH = "2011.12-pcl052"
> +SRC_URI = "git://github.com/Timesys/u-boot-
> timesys.git;protocol=git;branch=${SRCBRANCH}"
> +SRCREV = "dca5026484c69628be9b9618e5795c635cefe110"
> +
> +S = "${WORKDIR}/git"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +COMPATIBLE_MACHINE = "(vf60)"
> +
> +PV = "v2011.12"

Any plan to use u-boot mainline?

I found nothing else to comment on your patch.

reviewed-by,
daiane
> --
> 1.9.0
> 
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
>
Otavio Salvador - Feb. 27, 2014, 8:34 p.m.
Hello Anthony,

On Thu, Feb 27, 2014 at 3:47 PM, Anthony Felice <tony.felice@timesys.com> wrote:
> Add some commits over u-boot 2011.12 with board support for the pcl052 and
> pcm052 platforms, that include:
>
> * Add NAND boot support
> * Add FEC1 support
> * Fix DDR3 settings for pcm052 1.1 silicon
> * Fix SDHC issues
> * New machine definitions (i.e. pcl052, pcm052)
>
> and more, for a total of 25 commits. Included in these commits is also base
> support for the Vybrid Tower platform.
>
> Commits from the u-boot-cfi-flash fork from 2012-03-21 and earlier have also
> been added, starting from commit 85c344e5f98: "cfi: fix the incomplete erased
> status check in buffer write".
>
> This version has been tested on the pcl052 and pcm052 platforms.
>
> Signed-off-by: Anthony Felice <tony.felice@timesys.com>

Your commit log is nice now; thanks!

The only remark I have is that Vybrid Tower platform is currently
using the mainline U-Boot (2013.01) so this recipe should go to
meta-fsl-arm-extra.

In the ideal World, it'd be nice if we could have those platforms
added there as well, so we reduce the amount of maintenance work we
have.

Patch

diff --git a/recipes-bsp/u-boot/u-boot-timesys_2011.12.bb b/recipes-bsp/u-boot/u-boot-timesys_2011.12.bb
new file mode 100644
index 0000000..4f103fd
--- /dev/null
+++ b/recipes-bsp/u-boot/u-boot-timesys_2011.12.bb
@@ -0,0 +1,18 @@ 
+DESCRIPTION = "bootloader for Vybrid platforms"
+require recipes-bsp/u-boot/u-boot.inc
+
+PROVIDES += "u-boot"
+
+LICENSE = "GPLv2+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=1707d6db1d42237583f50183a5651ecb"
+
+SRCBRANCH = "2011.12-pcl052"
+SRC_URI = "git://github.com/Timesys/u-boot-timesys.git;protocol=git;branch=${SRCBRANCH}"
+SRCREV = "dca5026484c69628be9b9618e5795c635cefe110"
+
+S = "${WORKDIR}/git"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+COMPATIBLE_MACHINE = "(vf60)"
+
+PV = "v2011.12"