Patchwork [meta-oe,v2] xterm: split out resize into a separate package

login
register
mail settings
Submitter Jonathan Liu
Date Feb. 27, 2014, 3:18 a.m.
Message ID <1393471102-14702-1-git-send-email-net147@gmail.com>
Download mbox | patch
Permalink /patch/67539/
State Changes Requested, archived
Headers show

Comments

Jonathan Liu - Feb. 27, 2014, 3:18 a.m.
The resize program is useful on its own without xterm. For example, it
may be used to resize a serial console.

Signed-off-by: Jonathan Liu <net147@gmail.com>
---
 meta-oe/recipes-graphics/xorg-app/xterm_293.bb | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
Khem Raj - Feb. 27, 2014, 4:11 a.m.
On Wed, Feb 26, 2014 at 7:18 PM, Jonathan Liu <net147@gmail.com> wrote:
> -FILES_${PN} += " /usr/lib/X11"
> +PACKAGES =+ "${PN}-resize ${PN}-resize-dbg ${PN}-resize-doc"
> +
> +FILES_${PN} += "${libdir}/X11"

Multilib case needs testing since libdir will change in that case
Martin Jansa - March 5, 2014, 6:06 p.m.
On Thu, Feb 27, 2014 at 02:18:22PM +1100, Jonathan Liu wrote:
> The resize program is useful on its own without xterm. For example, it
> may be used to resize a serial console.
> 
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>  meta-oe/recipes-graphics/xorg-app/xterm_293.bb | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-graphics/xorg-app/xterm_293.bb b/meta-oe/recipes-graphics/xorg-app/xterm_293.bb
> index 67853b9..61bf71e 100644
> --- a/meta-oe/recipes-graphics/xorg-app/xterm_293.bb
> +++ b/meta-oe/recipes-graphics/xorg-app/xterm_293.bb
> @@ -20,4 +20,13 @@ do_configure() {
>      oe_runconf
>  }
>  
> -FILES_${PN} += " /usr/lib/X11"
> +PACKAGES =+ "${PN}-resize ${PN}-resize-dbg ${PN}-resize-doc"

I don't remember the reason now, but IIRC there should be just one -dbg
package per recipe (not sure about -doc), please check oe-core ML.

> +
> +FILES_${PN} += "${libdir}/X11"
> +FILES_${PN}-resize += "${bindir}/resize"
> +FILES_${PN}-resize-dbg += "${bindir}/.debug/resize"
> +FILES_${PN}-resize-doc += "${mandir}/man1/resize.1"
> +
> +RRECOMMENDS_${PN} += "${PN}-resize"
> +RRECOMMENDS_${PN}-dbg += "${PN}-resize-dbg"
> +RRECOMMENDS_${PN}-doc += "${PN}-resize-doc"
> -- 
> 1.9.0
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-oe/recipes-graphics/xorg-app/xterm_293.bb b/meta-oe/recipes-graphics/xorg-app/xterm_293.bb
index 67853b9..61bf71e 100644
--- a/meta-oe/recipes-graphics/xorg-app/xterm_293.bb
+++ b/meta-oe/recipes-graphics/xorg-app/xterm_293.bb
@@ -20,4 +20,13 @@  do_configure() {
     oe_runconf
 }
 
-FILES_${PN} += " /usr/lib/X11"
+PACKAGES =+ "${PN}-resize ${PN}-resize-dbg ${PN}-resize-doc"
+
+FILES_${PN} += "${libdir}/X11"
+FILES_${PN}-resize += "${bindir}/resize"
+FILES_${PN}-resize-dbg += "${bindir}/.debug/resize"
+FILES_${PN}-resize-doc += "${mandir}/man1/resize.1"
+
+RRECOMMENDS_${PN} += "${PN}-resize"
+RRECOMMENDS_${PN}-dbg += "${PN}-resize-dbg"
+RRECOMMENDS_${PN}-doc += "${PN}-resize-doc"