Patchwork uboot-config.bbclass: Skip the package if no valid configuration is found

login
register
mail settings
Submitter Otavio Salvador
Date Feb. 26, 2014, 8:39 p.m.
Message ID <1393447171-28161-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/67495/
State New
Headers show

Comments

Otavio Salvador - Feb. 26, 2014, 8:39 p.m.
The ValidError case makes parsing fail even if the U-Boot variant is
not in use for the specific machine and this is not desired. So
instead of raising a parsing error we skip the package.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
This error has been found while debugging a patchset which
we are reviewing in meta-fsl-arm.

This fix cou?d be considered for backporting into Dora as it does
fix a design error done by me when coding the class.

 meta/classes/uboot-config.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/meta/classes/uboot-config.bbclass b/meta/classes/uboot-config.bbclass
index 5068f49..3e09f17 100644
--- a/meta/classes/uboot-config.bbclass
+++ b/meta/classes/uboot-config.bbclass
@@ -9,7 +9,7 @@ 
 #
 # UBOOT_MACHINE = "config"
 #
-# Copyright 2013 (C) O.S. Systems Software LTDA.
+# Copyright 2013, 2014 (C) O.S. Systems Software LTDA.
 
 python () {
     ubootmachine = d.getVar("UBOOT_MACHINE", True)
@@ -55,5 +55,5 @@  python () {
             # Go out as we found a match!
             break
     else:
-        raise ValueError("UBOOT_CONFIG %s is not supported" % ubootconfig)
+        raise bb.parse.SkipPackage("UBOOT_CONFIG %s is not supported" % ubootconfig)
 }