Patchwork [v3] packagegroup-qt-toolchain-target.inc: add libQtUiTools static library

login
register
mail settings
Submitter Diego Sueiro
Date Feb. 26, 2014, 12:57 p.m.
Message ID <1393419467-6018-1-git-send-email-diego.sueiro@gmail.com>
Download mbox | patch
Permalink /patch/67467/
State New
Headers show

Comments

Diego Sueiro - Feb. 26, 2014, 12:57 p.m.
libQtUiTools.a and libQtUiToolsE.a needs to be installed on meta-toolchain-qt
and meta-toolchain-qte respectively.
Whitout this static library, compiling qt apps which needs uitools will fail.

qt4[-embedded]-staticdev is the package that contains this library and is the
only file in it.

Since a static library is shipped, special attention regarding the lincese
should be taken.

Signed-off-by: Diego Sueiro <diego.sueiro@gmail.com>
---
 meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc |    1 +
 1 file changed, 1 insertion(+)
Paul Eggleton - Feb. 26, 2014, 2:42 p.m.
Hi Diego,

On Wednesday 26 February 2014 09:57:47 Diego Sueiro wrote:
> libQtUiTools.a and libQtUiToolsE.a needs to be installed on
> meta-toolchain-qt and meta-toolchain-qte respectively.
> Whitout this static library, compiling qt apps which needs uitools will
> fail.
> 
> qt4[-embedded]-staticdev is the package that contains this library and is
> the only file in it.
> 
> Since a static library is shipped, special attention regarding the lincese
> should be taken.
> 
> Signed-off-by: Diego Sueiro <diego.sueiro@gmail.com>
> ---
>  meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc |    1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git
> a/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
> b/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc index
> fc1ccba..b040182 100644
> --- a/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
> +++ b/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
> @@ -33,4 +33,5 @@ RDEPENDS_${PN} += " \
>          libqt${QTLIBPREFIX}xmlpatterns4-dev \
>          libsqlite3-dev \
>          expat-dev \
> +        qt4${QTLIBPREFIX}-staticdev \
>          "

I know there's already been a bit of discussion about this patch already, so I 
apologise if this has already been covered, but the commit message doesn't 
completely justify this addition. Most people don't statically link to Qt, 
which is why we haven't included any static libraries in the SDK (and as a 
rule we typically don't include any static libraries in our SDKs). Why is this 
individual library out of all of the libraries that Qt ships special?

Cheers,
Paul
Diego Sueiro - Feb. 26, 2014, 5:45 p.m.
Paul,
On Wed, Feb 26, 2014 at 11:42 AM, Paul Eggleton <
paul.eggleton@linux.intel.com> wrote:

> I know there's already been a bit of discussion about this patch already,
> so I
> apologise if this has already been covered, but the commit message doesn't
> completely justify this addition. Most people don't statically link to Qt,
> which is why we haven't included any static libraries in the SDK (and as a
> rule we typically don't include any static libraries in our SDKs). Why is
> this
> individual library out of all of the libraries that Qt ships special?
>
I did a research on internet and just found static library for uitools. I
could not found anything that explains the reasons for not generating a
shared library.
People will not be able to use uitools If this library is not shipped with
SDK.
I tried to explain this dependency on commit message:

> libQtUiTools.a and libQtUiToolsE.a needs to be installed on
> meta-toolchain-qt
> and meta-toolchain-qte respectively.
> Whitout this static library, compiling qt apps which needs uitools will
> fail.




Regards,

--
*dS
Diego Sueiro

Administrador do Embarcados
www.embarcados.com.br<http://www.embarcados.com.br/?utm_source=assinatura_diego&utm_medium=e-mail&utm_campaign=Assinatura%20Email%20Diego>

/*long live rock 'n roll*/
Paul Eggleton - Feb. 26, 2014, 6:03 p.m.
On Wednesday 26 February 2014 14:45:26 Diego Sueiro wrote:
> On Wed, Feb 26, 2014 at 11:42 AM, Paul Eggleton <
> paul.eggleton@linux.intel.com> wrote:
> > I know there's already been a bit of discussion about this patch already,
> > so I apologise if this has already been covered, but the commit message
> > doesn't completely justify this addition. Most people don't statically
> > link to Qt, which is why we haven't included any static libraries in the
> > SDK (and as a rule we typically don't include any static libraries in our
> > SDKs). Why is this individual library out of all of the libraries that Qt
> > ships special?
> 
> I did a research on internet and just found static library for uitools. I
> could not found anything that explains the reasons for not generating a
> shared library.
> People will not be able to use uitools If this library is not shipped with
> SDK.
> 
> I tried to explain this dependency on commit message:
> > libQtUiTools.a and libQtUiToolsE.a needs to be installed on
> > meta-toolchain-qt
> > and meta-toolchain-qte respectively.
> > Whitout this static library, compiling qt apps which needs uitools will
> > fail.

The missing part is that libQtUiTools is only built as a static library (by 
upstream intentionally). I did some quick checking and it does appear that is 
the case, but if you could add that to the commit message that would be great. 
(I can only assume that not many people need to use the uitools module, hence 
why this hasn't come up before.)

Thanks,
Paul
Diego Sueiro - Feb. 26, 2014, 6:12 p.m.
On Wed, Feb 26, 2014 at 3:03 PM, Paul Eggleton <
paul.eggleton@linux.intel.com> wrote:

> The missing part is that libQtUiTools is only built as a static library (by
> upstream intentionally). I did some quick checking and it does appear that
> is
> the case, but if you could add that to the commit message that would be
> great.
> (I can only assume that not many people need to use the uitools module,
> hence
> why this hasn't come up before.)
>

Ok Paul. No problem. Let's see if PATCH v4 will be accepted. :-D

Regards,

--
*dS
Diego Sueiro

Administrador do Embarcados
www.embarcados.com.br<http://www.embarcados.com.br/?utm_source=assinatura_diego&utm_medium=e-mail&utm_campaign=Assinatura%20Email%20Diego>

/*long live rock 'n roll*/

Patch

diff --git a/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc b/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
index fc1ccba..b040182 100644
--- a/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
+++ b/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
@@ -33,4 +33,5 @@  RDEPENDS_${PN} += " \
         libqt${QTLIBPREFIX}xmlpatterns4-dev \
         libsqlite3-dev \
         expat-dev \
+        qt4${QTLIBPREFIX}-staticdev \
         "