Patchwork ppp: 2.4.5 seems to be ready for oe-dev too

login
register
mail settings
Submitter Steffen Sledz
Date June 30, 2011, 10:22 a.m.
Message ID <1309429335-3762-1-git-send-email-sledz@dresearch-fe.de>
Download mbox | patch
Permalink /patch/6743/
State Superseded
Headers show

Comments

Steffen Sledz - June 30, 2011, 10:22 a.m.
Oe-core is using 2.4.5 and it works OK there.

Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
---
 recipes/ppp/ppp_2.4.5.bb |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Paul Menzel - June 30, 2011, 5:28 p.m.
Am Donnerstag, den 30.06.2011, 12:22 +0200 schrieb Steffen Sledz:

ppp_2.4.5: remove `DP = "-1"`

is a more appropriate and precise commit summary in my opinion.

> Oe-core is using 2.4.5 and it works OK there.
> 
> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
> ---
>  recipes/ppp/ppp_2.4.5.bb |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb
> index 2b6b6f7..86d5ae5 100644
> --- a/recipes/ppp/ppp_2.4.5.bb
> +++ b/recipes/ppp/ppp_2.4.5.bb
> @@ -4,8 +4,6 @@ HOMEPAGE = "http://samba.org/ppp/"
>  DEPENDS = "libpcap"
>  LICENSE = "BSD GPLv2"
>  PR = "r1"
> -# Not well tested
> -DEFAULT_PREFERENCE = "-1"
>  
>  PARALLEL_MAKE = ""

I am getting the following warning when building the recipe with
`minimal{,-uclibc}` which I do not get with PPP 2.4.3.

        NOTE: package ppp-2.4.5-r1: task do_qa_staging: Started
        WARNING: the following files were installed but not shipped in any package:
        WARNING:   /usr/lib/pppd/2.4.5/pppol2tp.so
        WARNING:   /usr/lib/pppd/2.4.5/openl2tp.so

Could you fix this in a separate patch before committing this patch?

With the points above fixed/done this patch is

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul
Steffen Sledz - July 1, 2011, 6:10 a.m.
On 30.06.2011 19:28, Paul Menzel wrote:
> ppp_2.4.5: remove `DP = "-1"`
> 
> is a more appropriate and precise commit summary in my opinion.

yepp

>> Oe-core is using 2.4.5 and it works OK there.
>>
>> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
>> ---
>>  recipes/ppp/ppp_2.4.5.bb |    2 --
>>  1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb
>> index 2b6b6f7..86d5ae5 100644
>> --- a/recipes/ppp/ppp_2.4.5.bb
>> +++ b/recipes/ppp/ppp_2.4.5.bb
>> @@ -4,8 +4,6 @@ HOMEPAGE = "http://samba.org/ppp/"
>>  DEPENDS = "libpcap"
>>  LICENSE = "BSD GPLv2"
>>  PR = "r1"
>> -# Not well tested
>> -DEFAULT_PREFERENCE = "-1"
>>  
>>  PARALLEL_MAKE = ""
> 
> I am getting the following warning when building the recipe with
> `minimal{,-uclibc}` which I do not get with PPP 2.4.3.
> 
>         NOTE: package ppp-2.4.5-r1: task do_qa_staging: Started
>         WARNING: the following files were installed but not shipped in any package:
>         WARNING:   /usr/lib/pppd/2.4.5/pppol2tp.so
>         WARNING:   /usr/lib/pppd/2.4.5/openl2tp.so
> 
> Could you fix this in a separate patch before committing this patch?

Can please someone of the oe-core guys check if the problem is fixed there? And cherry-pick the fix to oe-dev master in that case.

Thx,
Steffen

Patch

diff --git a/recipes/ppp/ppp_2.4.5.bb b/recipes/ppp/ppp_2.4.5.bb
index 2b6b6f7..86d5ae5 100644
--- a/recipes/ppp/ppp_2.4.5.bb
+++ b/recipes/ppp/ppp_2.4.5.bb
@@ -4,8 +4,6 @@  HOMEPAGE = "http://samba.org/ppp/"
 DEPENDS = "libpcap"
 LICENSE = "BSD GPLv2"
 PR = "r1"
-# Not well tested
-DEFAULT_PREFERENCE = "-1"
 
 PARALLEL_MAKE = ""