Patchwork [1/1] strongswan: fix building lib32-strongswan failed while systemd enabled

login
register
mail settings
Submitter Hongxu Jia
Date Feb. 25, 2014, 10:54 a.m.
Message ID <a1776d6a50c9a7fcd20a4fc7ce55931088872cfb.1393325556.git.hongxu.jia@windriver.com>
Download mbox | patch
Permalink /patch/67401/
State New, archived
Headers show

Comments

Hongxu Jia - Feb. 25, 2014, 10:54 a.m.
While systemd enabled, there was an error to build lib32-strongswan:
...
| ERROR: Function failed: SYSTEMD_SERVICE_lib32-strongswan value
lib32-strongswan.service does not exist
...

The name of the service file should be the hardcoded
'strongswan.service' rather than '${PN}.service', so
the 'strongswan.service' will be found while building
lib32-strongswan.

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta-networking/recipes-support/strongswan/strongswan_5.0.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Martin Jansa - Feb. 26, 2014, 11:11 p.m.
On Tue, Feb 25, 2014 at 06:54:16PM +0800, Hongxu Jia wrote:
> While systemd enabled, there was an error to build lib32-strongswan:
> ...
> | ERROR: Function failed: SYSTEMD_SERVICE_lib32-strongswan value
> lib32-strongswan.service does not exist
> ...

Please use [meta-networking] tag in subject so it's easier to filter 
them on patchwork to separate bundles.

> 
> The name of the service file should be the hardcoded
> 'strongswan.service' rather than '${PN}.service', so
> the 'strongswan.service' will be found while building
> lib32-strongswan.
> 
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  meta-networking/recipes-support/strongswan/strongswan_5.0.0.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-support/strongswan/strongswan_5.0.0.bb b/meta-networking/recipes-support/strongswan/strongswan_5.0.0.bb
> index eb49494..e45e81a 100644
> --- a/meta-networking/recipes-support/strongswan/strongswan_5.0.0.bb
> +++ b/meta-networking/recipes-support/strongswan/strongswan_5.0.0.bb
> @@ -33,4 +33,4 @@ INSANE_SKIP_${PN}-plugins = "staticdev"
>  RPROVIDES_${PN} += "${PN}-systemd"
>  RREPLACES_${PN} += "${PN}-systemd"
>  RCONFLICTS_${PN} += "${PN}-systemd"
> -SYSTEMD_SERVICE_${PN} = "${PN}.service"
> +SYSTEMD_SERVICE_${PN} = "strongswan.service"
> -- 
> 1.8.1.2
>
Hongxu Jia - Feb. 27, 2014, 1:46 a.m.
On 02/27/2014 07:11 AM, Martin Jansa wrote:
> On Tue, Feb 25, 2014 at 06:54:16PM +0800, Hongxu Jia wrote:
>> While systemd enabled, there was an error to build lib32-strongswan:
>> ...
>> | ERROR: Function failed: SYSTEMD_SERVICE_lib32-strongswan value
>> lib32-strongswan.service does not exist
>> ...
> Please use [meta-networking] tag in subject so it's easier to filter
> them on patchwork to separate bundles.

Sorry for the missing, should I resend them?

//Hongxu

>> The name of the service file should be the hardcoded
>> 'strongswan.service' rather than '${PN}.service', so
>> the 'strongswan.service' will be found while building
>> lib32-strongswan.
>>
>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>> ---
>>   meta-networking/recipes-support/strongswan/strongswan_5.0.0.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-networking/recipes-support/strongswan/strongswan_5.0.0.bb b/meta-networking/recipes-support/strongswan/strongswan_5.0.0.bb
>> index eb49494..e45e81a 100644
>> --- a/meta-networking/recipes-support/strongswan/strongswan_5.0.0.bb
>> +++ b/meta-networking/recipes-support/strongswan/strongswan_5.0.0.bb
>> @@ -33,4 +33,4 @@ INSANE_SKIP_${PN}-plugins = "staticdev"
>>   RPROVIDES_${PN} += "${PN}-systemd"
>>   RREPLACES_${PN} += "${PN}-systemd"
>>   RCONFLICTS_${PN} += "${PN}-systemd"
>> -SYSTEMD_SERVICE_${PN} = "${PN}.service"
>> +SYSTEMD_SERVICE_${PN} = "strongswan.service"
>> -- 
>> 1.8.1.2
>>

Patch

diff --git a/meta-networking/recipes-support/strongswan/strongswan_5.0.0.bb b/meta-networking/recipes-support/strongswan/strongswan_5.0.0.bb
index eb49494..e45e81a 100644
--- a/meta-networking/recipes-support/strongswan/strongswan_5.0.0.bb
+++ b/meta-networking/recipes-support/strongswan/strongswan_5.0.0.bb
@@ -33,4 +33,4 @@  INSANE_SKIP_${PN}-plugins = "staticdev"
 RPROVIDES_${PN} += "${PN}-systemd"
 RREPLACES_${PN} += "${PN}-systemd"
 RCONFLICTS_${PN} += "${PN}-systemd"
-SYSTEMD_SERVICE_${PN} = "${PN}.service"
+SYSTEMD_SERVICE_${PN} = "strongswan.service"