Patchwork [v2] packagegroup-qt-toolchain-target.inc: add libQtUiTools static library

login
register
mail settings
Submitter Diego Sueiro
Date Feb. 24, 2014, 10:29 p.m.
Message ID <1393280958-18379-1-git-send-email-diego.sueiro@gmail.com>
Download mbox | patch
Permalink /patch/67371/
State New
Headers show

Comments

Diego Sueiro - Feb. 24, 2014, 10:29 p.m.
libQtUiTools.a and libQtUiToolsE.a needs to be installed on meta-toolchain-qt
and meta-toolchain-qte respectively.
Whitout this static library, compiling qt apps which needs uitools will fail.

qt4[-embedded]-staticdev is the package that contains this library and is the
only file in it.

Since a static library is shipped, special attention regarding the lincese
should be taken.
Here is the main header (tools/designer/src/uitools/quiloader.h) license
notes for uitools.

/****************************************************************************
**
** Copyright (C) 2013 Digia Plc and/or its subsidiary(-ies).
** Contact: http://www.qt-project.org/legal
**
** This file is part of the Qt Designer of the Qt Toolkit.
**
** $QT_BEGIN_LICENSE:LGPL$
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and Digia.  For licensing terms and
** conditions see http://qt.digia.com/licensing.  For further information
** use the contact form at http://qt.digia.com/contact-us.
**
** GNU Lesser General Public License Usage
** Alternatively, this file may be used under the terms of the GNU Lesser
** General Public License version 2.1 as published by the Free Software
** Foundation and appearing in the file LICENSE.LGPL included in the
** packaging of this file.  Please review the following information to
** ensure the GNU Lesser General Public License version 2.1 requirements
** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
**
** In addition, as a special exception, Digia gives you certain additional
** rights.  These rights are described in the Digia Qt LGPL Exception
** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3.0 as published by the Free Software
** Foundation and appearing in the file LICENSE.GPL included in the
** packaging of this file.  Please review the following information to
** ensure the GNU General Public License version 3.0 requirements will be
** met: http://www.gnu.org/copyleft/gpl.html.
**
**
** $QT_END_LICENSE$

Signed-off-by: Diego Sueiro <diego.sueiro@gmail.com>
---
 meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc |    1 +
 1 file changed, 1 insertion(+)
Otavio Salvador - Feb. 25, 2014, 1:24 p.m.
On Mon, Feb 24, 2014 at 7:29 PM, Diego Sueiro <diego.sueiro@gmail.com> wrote:
> libQtUiTools.a and libQtUiToolsE.a needs to be installed on meta-toolchain-qt
> and meta-toolchain-qte respectively.
> Whitout this static library, compiling qt apps which needs uitools will fail.
>
> qt4[-embedded]-staticdev is the package that contains this library and is the
> only file in it.
>
> Since a static library is shipped, special attention regarding the lincese
> should be taken.
> Here is the main header (tools/designer/src/uitools/quiloader.h) license
> notes for uitools.
>
> /****************************************************************************
> **
> ** Copyright (C) 2013 Digia Plc and/or its subsidiary(-ies).
> ** Contact: http://www.qt-project.org/legal
> **
> ** This file is part of the Qt Designer of the Qt Toolkit.
> **
> ** $QT_BEGIN_LICENSE:LGPL$
> ** Commercial License Usage
> ** Licensees holding valid commercial Qt licenses may use this file in
> ** accordance with the commercial license agreement provided with the
> ** Software or, alternatively, in accordance with the terms contained in
> ** a written agreement between you and Digia.  For licensing terms and
> ** conditions see http://qt.digia.com/licensing.  For further information
> ** use the contact form at http://qt.digia.com/contact-us.
> **
> ** GNU Lesser General Public License Usage
> ** Alternatively, this file may be used under the terms of the GNU Lesser
> ** General Public License version 2.1 as published by the Free Software
> ** Foundation and appearing in the file LICENSE.LGPL included in the
> ** packaging of this file.  Please review the following information to
> ** ensure the GNU Lesser General Public License version 2.1 requirements
> ** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
> **
> ** In addition, as a special exception, Digia gives you certain additional
> ** rights.  These rights are described in the Digia Qt LGPL Exception
> ** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
> **
> ** GNU General Public License Usage
> ** Alternatively, this file may be used under the terms of the GNU
> ** General Public License version 3.0 as published by the Free Software
> ** Foundation and appearing in the file LICENSE.GPL included in the
> ** packaging of this file.  Please review the following information to
> ** ensure the GNU General Public License version 3.0 requirements will be
> ** met: http://www.gnu.org/copyleft/gpl.html.
> **
> **
> ** $QT_END_LICENSE$
>
> Signed-off-by: Diego Sueiro <diego.sueiro@gmail.com>

This license is the same of Qt itself so I don't think it needs to be
quoted here. Do you see any reason for it?
Diego Sueiro - Feb. 25, 2014, 1:35 p.m.
Hi Otavio,
On Tue, Feb 25, 2014 at 10:24 AM, Otavio Salvador
<otavio@ossystems.com.br>wrote:

> This license is the same of Qt itself so I don't think it needs to be
> quoted here. Do you see any reason for it?
>
I've just followed Khem's instructions:
http://lists.openembedded.org/pipermail/openembedded-core/2014-February/089888.html

Regards,

--
*dS
Diego Sueiro

Administrador do Embarcados
www.embarcados.com.br<http://www.embarcados.com.br/?utm_source=assinatura_diego&utm_medium=e-mail&utm_campaign=Assinatura%20Email%20Diego>

/*long live rock 'n roll*/
Otavio Salvador - Feb. 25, 2014, 1:50 p.m.
Hello Diego,

(adding Khem and Paul in Cc)

On Tue, Feb 25, 2014 at 10:35 AM, Diego Sueiro <diego.sueiro@gmail.com> wrote:
> On Tue, Feb 25, 2014 at 10:24 AM, Otavio Salvador <otavio@ossystems.com.br>
> wrote:
>>
>> This license is the same of Qt itself so I don't think it needs to be
>> quoted here. Do you see any reason for it?
>
> I've just followed Khem's instructions:
> http://lists.openembedded.org/pipermail/openembedded-core/2014-February/089888.html

I see; however this license is no different of rest of Qt so we can
assume the user of Qt knows the license (and has reviewed possible
impacts of it with their legal department).

What others think?
Paul Eggleton - Feb. 25, 2014, 2:32 p.m.
On Tuesday 25 February 2014 10:50:08 Otavio Salvador wrote:
> Hello Diego,
> 
> (adding Khem and Paul in Cc)
> 
> On Tue, Feb 25, 2014 at 10:35 AM, Diego Sueiro <diego.sueiro@gmail.com> 
wrote:
> > On Tue, Feb 25, 2014 at 10:24 AM, Otavio Salvador
> > <otavio@ossystems.com.br>
> > 
> > wrote:
> >> This license is the same of Qt itself so I don't think it needs to be
> >> quoted here. Do you see any reason for it?
> > 
> > I've just followed Khem's instructions:
> > http://lists.openembedded.org/pipermail/openembedded-core/2014-February/08
> > 9888.html
> I see; however this license is no different of rest of Qt so we can
> assume the user of Qt knows the license (and has reviewed possible
> impacts of it with their legal department).
> 
> What others think?

Are we talking about the license of the packagegroup? Technically, the 
packagegroup itself doesn't actually ship any files, so personally I've always 
considered the LICENSE value for packagegroup recipes to be irrelevant. I have 
a similar view on the LICENSE value for image and SDK recipes, since there 
it's not really practical to express all of the package licenses in a single 
field, so it's not worth trying - the license manifest should be used for that.

Cheers,
Paul
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
Khem Raj - Feb. 25, 2014, 4:41 p.m.
On Tue, Feb 25, 2014 at 5:50 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> Hello Diego,
>
> (adding Khem and Paul in Cc)
>
> On Tue, Feb 25, 2014 at 10:35 AM, Diego Sueiro <diego.sueiro@gmail.com> wrote:
>> On Tue, Feb 25, 2014 at 10:24 AM, Otavio Salvador <otavio@ossystems.com.br>
>> wrote:
>>>
>>> This license is the same of Qt itself so I don't think it needs to be
>>> quoted here. Do you see any reason for it?
>>
>> I've just followed Khem's instructions:
>> http://lists.openembedded.org/pipermail/openembedded-core/2014-February/089888.html
>
> I see; however this license is no different of rest of Qt so we can
> assume the user of Qt knows the license (and has reviewed possible
> impacts of it with their legal department).

ofcourse, however all I was suggesting to make it a little more
understood with some
comments.

>
> What others think?
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Diego Sueiro - Feb. 25, 2014, 6:18 p.m.
On Tue, Feb 25, 2014 at 1:41 PM, Khem Raj <raj.khem@gmail.com> wrote:

> ofcourse, however all I was suggesting to make it a little more
> understood with some
> comments.
>

So,
I can remove the header text from commit. What do you think?

Regards,

--
*dS
Diego Sueiro

Administrador do Embarcados
www.embarcados.com.br<http://www.embarcados.com.br/?utm_source=assinatura_diego&utm_medium=e-mail&utm_campaign=Assinatura%20Email%20Diego>

/*long live rock 'n roll*/

Patch

diff --git a/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc b/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
index fc1ccba..b040182 100644
--- a/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
+++ b/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
@@ -33,4 +33,5 @@  RDEPENDS_${PN} += " \
         libqt${QTLIBPREFIX}xmlpatterns4-dev \
         libsqlite3-dev \
         expat-dev \
+        qt4${QTLIBPREFIX}-staticdev \
         "