Patchwork [meta-fsl-arm,v4,06/13] xf86-video-imxfb-vivante: Fix HDMI preferred mode selection

login
register
mail settings
Submitter Otavio Salvador
Date Feb. 24, 2014, 6:46 p.m.
Message ID <1393267615-29009-7-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/67303/
State Accepted
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - Feb. 24, 2014, 6:46 p.m.
The 3.10.17-beta driver mode selection defaults to the lowest
resolution, which is not optimal. This patch changes it to use the
monitor/display preferred mode.

Thanks to Jon Nettleton <jon.nettleton@gmail.com> for the patch.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

Changes in v4:
- new patch

Changes in v3: None
Changes in v2: None

 .../fix-hdmi-preferred-mode.patch                  | 23 ++++++++++++++++++++++
 .../xf86-video-imxfb-vivante_3.10.17-1.0.0.bb      |  2 ++
 2 files changed, 25 insertions(+)
 create mode 100644 recipes-graphics/xorg-driver/xf86-video-imxfb-vivante/fix-hdmi-preferred-mode.patch
Eric Nelson - March 3, 2014, 4:33 p.m.
Thanks Jon and Otavio,

On 02/24/2014 11:46 AM, Otavio Salvador wrote:
> The 3.10.17-beta driver mode selection defaults to the lowest
> resolution, which is not optimal. This patch changes it to use the
> monitor/display preferred mode.
>
> Thanks to Jon Nettleton <jon.nettleton@gmail.com> for the patch.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>

Tested-By: Eric Nelson <eric.nelson@boundarydevices.com>

I tested on 'master-next' on a Nitrogen6X with
PREFERRED_VERSION_linux-boundary = "3.10.17"

Regards,


Eric

Patch

diff --git a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante/fix-hdmi-preferred-mode.patch b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante/fix-hdmi-preferred-mode.patch
new file mode 100644
index 0000000..2c2f564
--- /dev/null
+++ b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante/fix-hdmi-preferred-mode.patch
@@ -0,0 +1,23 @@ 
+Fix HDMI preferred mode choosing
+
+This fixes the HDMI setting to use the preferred mode instead of the
+lowest resolution by default.
+
+Upstream-Status: Pending
+
+Signed-off-by: Jon Nettleton <jon.nettleton@gmail.com>
+Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
+
+diff --git a/EXA/src/vivante_fbdev/imx_display.c b/EXA/src/vivante_fbdev/imx_display.c
+index af6dcfc..cf49003 100644
+--- a/EXA/src/vivante_fbdev/imx_display.c
++++ b/EXA/src/vivante_fbdev/imx_display.c
+@@ -879,6 +879,8 @@ imxDisplayGetModes(ScrnInfoPtr pScrn, const char* fbDeviceName)
+ 			(mode->HDisplay > 0) &&
+ 				(mode->VDisplay > 0)) {
+ 
++			mode->type = M_T_PREFERRED;
++
+ 			xf86PrintModeline(pScrn->scrnIndex, mode);
+ 			modesList = xf86ModesAdd(modesList, mode);
+ 		}
diff --git a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_3.10.17-1.0.0.bb b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_3.10.17-1.0.0.bb
index 31f2747..4887d26 100644
--- a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_3.10.17-1.0.0.bb
+++ b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_3.10.17-1.0.0.bb
@@ -15,6 +15,8 @@  SRC_URI = "${FSL_MIRROR}/xserver-xorg-video-imx-viv-${PV}_beta.tar.gz"
 SRC_URI[md5sum] = "fee0e4820fe3f89e5f36a0b343e4a33f"
 SRC_URI[sha256sum] = "b65aef86943cb0fcd2dd7ded01215038dcf2761779ce39186ab3c8c2d4b010b1"
 
+SRC_URI += "file://fix-hdmi-preferred-mode.patch"
+
 EXTRA_OEMAKE += "-C EXA/src -f makefile.linux prefix=${D}/usr \
                  sysroot=${STAGING_DIR_TARGET} \
                  BUSID_HAS_NUMBER=1 \