Patchwork [meta-fsl-arm,1/3] mqxboot: Rework recipe

login
register
mail settings
Submitter Otavio Salvador
Date Feb. 24, 2014, 12:09 p.m.
Message ID <1393243788-17579-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/67231/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - Feb. 24, 2014, 12:09 p.m.
- Use summary as the description was short
- Drop vendor from summary
- Put RDEPENDS after source fields
- Add empty line between S and CFLAGS
- Drop extra space in CFLAGS appending

Change-Id: I6adb237ffaae3b24ac2b28855d31ae93a3d019cb
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 recipes-bsp/mqxboot/mqxboot_1.0.bb | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
Daiane Angolini - Feb. 24, 2014, 1:38 p.m.
> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Otavio Salvador
> Sent: Monday, February 24, 2014 9:10 AM
> To: meta-freescale Mailing List
> Cc: Otavio Salvador
> Subject: [meta-freescale] [meta-fsl-arm][PATCH 1/3] mqxboot: Rework recipe
> 
> - Use summary as the description was short
> - Drop vendor from summary
> - Put RDEPENDS after source fields
> - Add empty line between S and CFLAGS
> - Drop extra space in CFLAGS appending

When you´re sending v2 for the other patch I just commented (libmcc)
could you, please, use the same advices for this one?


;-) 


Thanks in advance, 

Daiane
> 
> Change-Id: I6adb237ffaae3b24ac2b28855d31ae93a3d019cb
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  recipes-bsp/mqxboot/mqxboot_1.0.bb | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/recipes-bsp/mqxboot/mqxboot_1.0.bb b/recipes-
> bsp/mqxboot/mqxboot_1.0.bb
> index 707cfba..1293928 100644
> --- a/recipes-bsp/mqxboot/mqxboot_1.0.bb
> +++ b/recipes-bsp/mqxboot/mqxboot_1.0.bb
> @@ -1,11 +1,9 @@
>  # Copyright (C) 2013 Timesys Corporation -SUMMARY = "mqxboot"
> -DESCRIPTION = "Timesys MQX Image loader - starts an MQX image on the M4"
> +SUMMARY = "MQX Image loader - starts an MQX image on the M4"
>  LICENSE = "GPL-2.0"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=c49712341497d0b5f2e40c30dff2af9d"
> 
>  DEPENDS = "kernel-module-mcc"
> -RDEPENDS_${PN} = "kernel-module-mcc"
> 
>  inherit autotools
> 
> @@ -15,6 +13,9 @@ SRC_URI[md5sum] = "3de3c8b5f8cd6664870587d29c04c421"
>  SRC_URI[sha256sum] =
> "c2f66ae962fe2529578d5c007e3f91a36085b714a0ea276f47bc3aea90e69699"
> 
>  S = "${WORKDIR}/mqxboot-${PV}"
> -CFLAGS += " -I${STAGING_KERNEL_DIR}/include"
> +
> +CFLAGS += "-I${STAGING_KERNEL_DIR}/include"
> +
> +RDEPENDS_${PN} = "kernel-module-mcc"
> 
>  COMPATIBLE_MACHINE = "(vf60)"
> --
> 1.9.0
> 
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
>

Patch

diff --git a/recipes-bsp/mqxboot/mqxboot_1.0.bb b/recipes-bsp/mqxboot/mqxboot_1.0.bb
index 707cfba..1293928 100644
--- a/recipes-bsp/mqxboot/mqxboot_1.0.bb
+++ b/recipes-bsp/mqxboot/mqxboot_1.0.bb
@@ -1,11 +1,9 @@ 
 # Copyright (C) 2013 Timesys Corporation
-SUMMARY = "mqxboot"
-DESCRIPTION = "Timesys MQX Image loader - starts an MQX image on the M4"
+SUMMARY = "MQX Image loader - starts an MQX image on the M4"
 LICENSE = "GPL-2.0"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=c49712341497d0b5f2e40c30dff2af9d"
 
 DEPENDS = "kernel-module-mcc"
-RDEPENDS_${PN} = "kernel-module-mcc"
 
 inherit autotools
 
@@ -15,6 +13,9 @@  SRC_URI[md5sum] = "3de3c8b5f8cd6664870587d29c04c421"
 SRC_URI[sha256sum] = "c2f66ae962fe2529578d5c007e3f91a36085b714a0ea276f47bc3aea90e69699"
 
 S = "${WORKDIR}/mqxboot-${PV}"
-CFLAGS += " -I${STAGING_KERNEL_DIR}/include"
+
+CFLAGS += "-I${STAGING_KERNEL_DIR}/include"
+
+RDEPENDS_${PN} = "kernel-module-mcc"
 
 COMPATIBLE_MACHINE = "(vf60)"