Patchwork [1/1] weston: disable-egl when no wayland

login
register
mail settings
Submitter Robert Yang
Date Feb. 24, 2014, 9:26 a.m.
Message ID <641185084afb8d76865faa13879547f8e546e553.1393233958.git.liezhi.yang@windriver.com>
Download mbox | patch
Permalink /patch/67209/
State Accepted
Commit 617819a6bf723c87f776885152cfff8e98d9ffa1
Headers show

Comments

Robert Yang - Feb. 24, 2014, 9:26 a.m.
There was a configure error when build weston without wayland:

configure: error: Package requirements (egl >= 7.10 glesv2 wayland-client wayland-egl) were not met:

No package 'wayland-egl' found

[YOCTO #5867]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/recipes-graphics/wayland/weston_1.4.0.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Valentin Popa - Feb. 24, 2014, 2:44 p.m.
On 02/24/2014 11:26 AM, Robert Yang wrote:
> There was a configure error when build weston without wayland:
>
> configure: error: Package requirements (egl >= 7.10 glesv2 wayland-client wayland-egl) were not met:
>
> No package 'wayland-egl' found
>
> [YOCTO #5867]
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>   meta/recipes-graphics/wayland/weston_1.4.0.bb |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/wayland/weston_1.4.0.bb b/meta/recipes-graphics/wayland/weston_1.4.0.bb
> index 5c389a0..e0c354d 100644
> --- a/meta/recipes-graphics/wayland/weston_1.4.0.bb
> +++ b/meta/recipes-graphics/wayland/weston_1.4.0.bb
> @@ -39,7 +39,7 @@ PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'wayland', 'kms fbdev way
>   # Weston on KMS
>   PACKAGECONFIG[kms] = "--enable-drm-compositor,--disable-drm-compositor,drm udev virtual/mesa mtdev"
>   # Weston on Wayland (nested Weston)
> -PACKAGECONFIG[wayland] = "--enable-wayland-compositor,--disable-wayland-compositor,virtual/mesa"
> +PACKAGECONFIG[wayland] = "--enable-wayland-compositor,--disable-egl --disable-wayland-compositor,virtual/mesa"
>   # Weston on X11
>   PACKAGECONFIG[x11] = "--enable-x11-compositor,--disable-x11-compositor,virtual/libx11 libxcb libxcb libxcursor cairo"
>   # Headless Weston
How did you build weston without wayland?
Have you built wayland without libwayland-egl and then tried to build 
weston?
Valentin Popa - Feb. 24, 2014, 3:29 p.m.
On 02/24/2014 04:44 PM, Valentin Popa wrote:
> On 02/24/2014 11:26 AM, Robert Yang wrote:
>> There was a configure error when build weston without wayland:
>>
>> configure: error: Package requirements (egl >= 7.10 glesv2 
>> wayland-client wayland-egl) were not met:
>>
>> No package 'wayland-egl' found
>>
>> [YOCTO #5867]
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   meta/recipes-graphics/wayland/weston_1.4.0.bb |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-graphics/wayland/weston_1.4.0.bb 
>> b/meta/recipes-graphics/wayland/weston_1.4.0.bb
>> index 5c389a0..e0c354d 100644
>> --- a/meta/recipes-graphics/wayland/weston_1.4.0.bb
>> +++ b/meta/recipes-graphics/wayland/weston_1.4.0.bb
>> @@ -39,7 +39,7 @@ PACKAGECONFIG ??= 
>> "${@base_contains('DISTRO_FEATURES', 'wayland', 'kms fbdev way
>>   # Weston on KMS
>>   PACKAGECONFIG[kms] = 
>> "--enable-drm-compositor,--disable-drm-compositor,drm udev 
>> virtual/mesa mtdev"
>>   # Weston on Wayland (nested Weston)
>> -PACKAGECONFIG[wayland] = 
>> "--enable-wayland-compositor,--disable-wayland-compositor,virtual/mesa"
>> +PACKAGECONFIG[wayland] = "--enable-wayland-compositor,--disable-egl 
>> --disable-wayland-compositor,virtual/mesa"
>>   # Weston on X11
>>   PACKAGECONFIG[x11] = 
>> "--enable-x11-compositor,--disable-x11-compositor,virtual/libx11 
>> libxcb libxcb libxcursor cairo"
>>   # Headless Weston
> How did you build weston without wayland?
> Have you built wayland without libwayland-egl and then tried to build 
> weston?
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


I got it, so you are building with :
DISTRO_FEATURES_remove="wayland"
DISTRO_FEATURES_append = " x11"

and mesa doesn't build libwayland-egl, but weston checks for EGL.

Looks good to me, but the subject/message is not so clear. Can you 
please modify it and resend?

Thanks!
Martin Jansa - Feb. 24, 2014, 4:12 p.m.
On Mon, Feb 24, 2014 at 05:29:42PM +0200, Valentin Popa wrote:
> On 02/24/2014 04:44 PM, Valentin Popa wrote:
> > On 02/24/2014 11:26 AM, Robert Yang wrote:
> >> There was a configure error when build weston without wayland:
> >>
> >> configure: error: Package requirements (egl >= 7.10 glesv2 
> >> wayland-client wayland-egl) were not met:
> >>
> >> No package 'wayland-egl' found
> >>
> >> [YOCTO #5867]
> >>
> >> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> >> ---
> >>   meta/recipes-graphics/wayland/weston_1.4.0.bb |    2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-graphics/wayland/weston_1.4.0.bb 
> >> b/meta/recipes-graphics/wayland/weston_1.4.0.bb
> >> index 5c389a0..e0c354d 100644
> >> --- a/meta/recipes-graphics/wayland/weston_1.4.0.bb
> >> +++ b/meta/recipes-graphics/wayland/weston_1.4.0.bb
> >> @@ -39,7 +39,7 @@ PACKAGECONFIG ??= 
> >> "${@base_contains('DISTRO_FEATURES', 'wayland', 'kms fbdev way
> >>   # Weston on KMS
> >>   PACKAGECONFIG[kms] = 
> >> "--enable-drm-compositor,--disable-drm-compositor,drm udev 
> >> virtual/mesa mtdev"
> >>   # Weston on Wayland (nested Weston)
> >> -PACKAGECONFIG[wayland] = 
> >> "--enable-wayland-compositor,--disable-wayland-compositor,virtual/mesa"
> >> +PACKAGECONFIG[wayland] = "--enable-wayland-compositor,--disable-egl 
> >> --disable-wayland-compositor,virtual/mesa"
> >>   # Weston on X11
> >>   PACKAGECONFIG[x11] = 
> >> "--enable-x11-compositor,--disable-x11-compositor,virtual/libx11 
> >> libxcb libxcb libxcursor cairo"
> >>   # Headless Weston
> > How did you build weston without wayland?
> > Have you built wayland without libwayland-egl and then tried to build 
> > weston?
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> 
> I got it, so you are building with :
> DISTRO_FEATURES_remove="wayland"
> DISTRO_FEATURES_append = " x11"

BTW: This is the reason why weston was failing in:
http://www.openembedded.org/wiki/Bitbake_World_Status

> and mesa doesn't build libwayland-egl, but weston checks for EGL.
> 
> Looks good to me, but the subject/message is not so clear. Can you 
> please modify it and resend?
> 
> Thanks!
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Robert Yang - Feb. 25, 2014, 9:35 a.m.
On 02/24/2014 11:29 PM, Valentin Popa wrote:
> On 02/24/2014 04:44 PM, Valentin Popa wrote:
>> On 02/24/2014 11:26 AM, Robert Yang wrote:
>>> There was a configure error when build weston without wayland:
>>>
>>> configure: error: Package requirements (egl >= 7.10 glesv2 wayland-client
>>> wayland-egl) were not met:
>>>
>>> No package 'wayland-egl' found
>>>
>>> [YOCTO #5867]
>>>
>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>> ---
>>>   meta/recipes-graphics/wayland/weston_1.4.0.bb |    2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-graphics/wayland/weston_1.4.0.bb
>>> b/meta/recipes-graphics/wayland/weston_1.4.0.bb
>>> index 5c389a0..e0c354d 100644
>>> --- a/meta/recipes-graphics/wayland/weston_1.4.0.bb
>>> +++ b/meta/recipes-graphics/wayland/weston_1.4.0.bb
>>> @@ -39,7 +39,7 @@ PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES',
>>> 'wayland', 'kms fbdev way
>>>   # Weston on KMS
>>>   PACKAGECONFIG[kms] = "--enable-drm-compositor,--disable-drm-compositor,drm
>>> udev virtual/mesa mtdev"
>>>   # Weston on Wayland (nested Weston)
>>> -PACKAGECONFIG[wayland] =
>>> "--enable-wayland-compositor,--disable-wayland-compositor,virtual/mesa"
>>> +PACKAGECONFIG[wayland] = "--enable-wayland-compositor,--disable-egl
>>> --disable-wayland-compositor,virtual/mesa"
>>>   # Weston on X11
>>>   PACKAGECONFIG[x11] =
>>> "--enable-x11-compositor,--disable-x11-compositor,virtual/libx11 libxcb
>>> libxcb libxcursor cairo"
>>>   # Headless Weston
>> How did you build weston without wayland?
>> Have you built wayland without libwayland-egl and then tried to build weston?
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
> I got it, so you are building with :
> DISTRO_FEATURES_remove="wayland"
> DISTRO_FEATURES_append = " x11"
>
> and mesa doesn't build libwayland-egl, but weston checks for EGL.
>
> Looks good to me, but the subject/message is not so clear. Can you please modify
> it and resend?
>

Thanks, I updated the subject to:

weston: fix build without wayland in distro_features

And also updated the repo:

git://git.pokylinux.org/poky-contrib rbt/weston


// Robert

> Thanks!
>
>
>
>

Patch

diff --git a/meta/recipes-graphics/wayland/weston_1.4.0.bb b/meta/recipes-graphics/wayland/weston_1.4.0.bb
index 5c389a0..e0c354d 100644
--- a/meta/recipes-graphics/wayland/weston_1.4.0.bb
+++ b/meta/recipes-graphics/wayland/weston_1.4.0.bb
@@ -39,7 +39,7 @@  PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'wayland', 'kms fbdev way
 # Weston on KMS
 PACKAGECONFIG[kms] = "--enable-drm-compositor,--disable-drm-compositor,drm udev virtual/mesa mtdev"
 # Weston on Wayland (nested Weston)
-PACKAGECONFIG[wayland] = "--enable-wayland-compositor,--disable-wayland-compositor,virtual/mesa"
+PACKAGECONFIG[wayland] = "--enable-wayland-compositor,--disable-egl --disable-wayland-compositor,virtual/mesa"
 # Weston on X11
 PACKAGECONFIG[x11] = "--enable-x11-compositor,--disable-x11-compositor,virtual/libx11 libxcb libxcb libxcursor cairo"
 # Headless Weston