Patchwork [meta-fsl-arm] image_types_fsl.bbclass: Add fstype dependency

login
register
mail settings
Submitter Otavio Salvador
Date Feb. 21, 2014, 11:54 a.m.
Message ID <1392983662-25186-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/67113/
State Accepted
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - Feb. 21, 2014, 11:54 a.m.
The sdcard requires the rootfs filesystem to be built before using it
so we must to make this dependency explicit.

Change-Id: Ibacba4c2ff5250785b50d6a7bc7ddf77f6309bb6
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 classes/image_types_fsl.bbclass | 4 ++++
 1 file changed, 4 insertions(+)
Otavio Salvador - Feb. 21, 2014, 12:11 p.m.
On Fri, Feb 21, 2014 at 8:54 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> The sdcard requires the rootfs filesystem to be built before using it
> so we must to make this dependency explicit.
>
> Change-Id: Ibacba4c2ff5250785b50d6a7bc7ddf77f6309bb6
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

I am addicted to write 'must to'. Fixed locally ;-)
Daiane Angolini - Feb. 21, 2014, 12:11 p.m.
On Fri, Feb 21, 2014 at 8:54 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> The sdcard requires the rootfs filesystem to be built before using it
> so we must to make this dependency explicit.

... we must make this ...
>
> Change-Id: Ibacba4c2ff5250785b50d6a7bc7ddf77f6309bb6
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  classes/image_types_fsl.bbclass | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/classes/image_types_fsl.bbclass b/classes/image_types_fsl.bbclass
> index 3510452..42b6261 100644
> --- a/classes/image_types_fsl.bbclass
> +++ b/classes/image_types_fsl.bbclass
> @@ -297,3 +297,7 @@ IMAGE_CMD_sdcard () {
>
>         ${SDCARD_GENERATION_COMMAND}
>  }
> +
> +# The sdcard requires the rootfs filesystem to be built before using
> +# it so we must to make this dependency explicit.
> +IMAGE_TYPEDEP_sdcard = "${@d.getVar('SDCARD_ROOTFS', 1).split('.')[-1]}"


Thanks a lot, Otavio!

Only make the minor change in commitlog before merging.

It's an important fix, and I think you should merge it today, but
please, give it a 4 hour rest in mail list. So people could see the
patch before.


\o/


Daiane
> --
> 1.9.0
>
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
Otavio Salvador - Feb. 21, 2014, 12:14 p.m.
On Fri, Feb 21, 2014 at 9:11 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
> On Fri, Feb 21, 2014 at 8:54 AM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> The sdcard requires the rootfs filesystem to be built before using it
>> so we must to make this dependency explicit.
>
> ... we must make this ...
>>
>> Change-Id: Ibacba4c2ff5250785b50d6a7bc7ddf77f6309bb6
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>>  classes/image_types_fsl.bbclass | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/classes/image_types_fsl.bbclass b/classes/image_types_fsl.bbclass
>> index 3510452..42b6261 100644
>> --- a/classes/image_types_fsl.bbclass
>> +++ b/classes/image_types_fsl.bbclass
>> @@ -297,3 +297,7 @@ IMAGE_CMD_sdcard () {
>>
>>         ${SDCARD_GENERATION_COMMAND}
>>  }
>> +
>> +# The sdcard requires the rootfs filesystem to be built before using
>> +# it so we must to make this dependency explicit.
>> +IMAGE_TYPEDEP_sdcard = "${@d.getVar('SDCARD_ROOTFS', 1).split('.')[-1]}"
>
>
> Thanks a lot, Otavio!
>
> Only make the minor change in commitlog before merging.
>
> It's an important fix, and I think you should merge it today, but
> please, give it a 4 hour rest in mail list. So people could see the
> patch before.

Right; I am checking the other known failures to try to get master
working fine again.

Patch

diff --git a/classes/image_types_fsl.bbclass b/classes/image_types_fsl.bbclass
index 3510452..42b6261 100644
--- a/classes/image_types_fsl.bbclass
+++ b/classes/image_types_fsl.bbclass
@@ -297,3 +297,7 @@  IMAGE_CMD_sdcard () {
 
 	${SDCARD_GENERATION_COMMAND}
 }
+
+# The sdcard requires the rootfs filesystem to be built before using
+# it so we must to make this dependency explicit.
+IMAGE_TYPEDEP_sdcard = "${@d.getVar('SDCARD_ROOTFS', 1).split('.')[-1]}"