Patchwork [v1] packagegroup-qt-toolchain-target.inc: add libQtUiTools static library

login
register
mail settings
Submitter Diego Sueiro
Date Feb. 18, 2014, 5:49 p.m.
Message ID <1392745755-20315-1-git-send-email-diego.sueiro@gmail.com>
Download mbox | patch
Permalink /patch/66937/
State New
Headers show

Comments

Diego Sueiro - Feb. 18, 2014, 5:49 p.m.
libQtUiTools.a and libQtUiToolsE.a needs to be installed on meta-toolchain-qt
and meta-toolchain-qte respectively.
Whitout this static library, compiling qt apps which needs uitools will fail.

qt4[-embedded]-staticdev is the package that contains this library and is the
only file in it.

Signed-off-by: Diego Sueiro <diego.sueiro@gmail.com>
---
 meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc |    1 +
 1 file changed, 1 insertion(+)
Khem Raj - Feb. 18, 2014, 5:51 p.m.
On Tue, Feb 18, 2014 at 9:49 AM, Diego Sueiro <diego.sueiro@gmail.com> wrote:
> libQtUiTools.a and libQtUiToolsE.a needs to be installed on meta-toolchain-qt
> and meta-toolchain-qte respectively.
> Whitout this static library, compiling qt apps which needs uitools will fail.

can you also figure out what is the licensing terms of these static .a
archives please ?
and make a note of it in commit message or somewhere
Diego Sueiro - Feb. 18, 2014, 6:55 p.m.
Khem,
On Tue, Feb 18, 2014 at 2:51 PM, Khem Raj <raj.khem@gmail.com> wrote:

> can you also figure out what is the licensing terms of these static .a
> archives please ?
> and make a note of it in commit message or somewhere
>
Looking at the main library header (tools/designer/src/uitools/quiloader.h)
it mentions the Digia Commercial License, LGPL v2.1, LGPL Exception and
GPLv3.

I think it is not different from the other libraries and if you use this
library (in this case static library) in LGPL or GPL you should provide
your source code and follow the same license. Am I wrong?

Regards,

--
*dS
Diego Sueiro

Administrador do Embarcados
www.embarcados.com.br

/*long live rock 'n roll*/
Khem Raj - Feb. 18, 2014, 7:07 p.m.
On Tue, Feb 18, 2014 at 10:55 AM, Diego Sueiro <diego.sueiro@gmail.com> wrote:
> Khem,
>
> On Tue, Feb 18, 2014 at 2:51 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> can you also figure out what is the licensing terms of these static .a
>> archives please ?
>> and make a note of it in commit message or somewhere
>
> Looking at the main library header (tools/designer/src/uitools/quiloader.h)
> it mentions the Digia Commercial License, LGPL v2.1, LGPL Exception and
> GPLv3.

what would be the license of this given library is it all of above or
some combination
or choice ?

>
> I think it is not different from the other libraries and if you use this
> library (in this case static library) in LGPL or GPL you should provide your
> source code and follow the same license. Am I wrong?

static linking and dynamic linking has different implications,

>
> Regards,
>
> --
> *dS
> Diego Sueiro
>
> Administrador do Embarcados
> www.embarcados.com.br
>
> /*long live rock 'n roll*/
Diego Sueiro - Feb. 18, 2014, 7:16 p.m.
On Tue, Feb 18, 2014 at 4:07 PM, Khem Raj <raj.khem@gmail.com> wrote:

> > Looking at the main library header
> (tools/designer/src/uitools/quiloader.h)
> > it mentions the Digia Commercial License, LGPL v2.1, LGPL Exception and
> > GPLv3.
>
> what would be the license of this given library is it all of above or
> some combination
> or choice ?

I think is a choice.
This is what the header says:

/****************************************************************************
**
** Copyright (C) 2013 Digia Plc and/or its subsidiary(-ies).
** Contact: http://www.qt-project.org/legal
**
** This file is part of the Qt Designer of the Qt Toolkit.
**
** $QT_BEGIN_LICENSE:LGPL$
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and Digia.  For licensing terms and
** conditions see http://qt.digia.com/licensing.  For further information
** use the contact form at http://qt.digia.com/contact-us.
**
** GNU Lesser General Public License Usage
** Alternatively, this file may be used under the terms of the GNU Lesser
** General Public License version 2.1 as published by the Free Software
** Foundation and appearing in the file LICENSE.LGPL included in the
** packaging of this file.  Please review the following information to
** ensure the GNU Lesser General Public License version 2.1 requirements
** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
**
** In addition, as a special exception, Digia gives you certain additional
** rights.  These rights are described in the Digia Qt LGPL Exception
** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3.0 as published by the Free Software
** Foundation and appearing in the file LICENSE.GPL included in the
** packaging of this file.  Please review the following information to
** ensure the GNU General Public License version 3.0 requirements will be
** met: http://www.gnu.org/copyleft/gpl.html.
**
**
** $QT_END_LICENSE$


Regards,

--
*dS
Diego Sueiro

Administrador do Embarcados
www.embarcados.com.br

/*long live rock 'n roll*/
Diego Sueiro - Feb. 24, 2014, 10:33 a.m.
Khem,

On Tue, Feb 18, 2014 at 4:16 PM, Diego Sueiro <diego.sueiro@gmail.com>wrote:

> I think is a choice.
> This is what the header says:
>
>
> /****************************************************************************
> **
> ** Copyright (C) 2013 Digia Plc and/or its subsidiary(-ies).
> ** Contact: http://www.qt-project.org/legal
> **
> ** This file is part of the Qt Designer of the Qt Toolkit.
> **
> ** $QT_BEGIN_LICENSE:LGPL$
> ** Commercial License Usage
> ** Licensees holding valid commercial Qt licenses may use this file in
> ** accordance with the commercial license agreement provided with the
> ** Software or, alternatively, in accordance with the terms contained in
> ** a written agreement between you and Digia.  For licensing terms and
> ** conditions see http://qt.digia.com/licensing.  For further information
> ** use the contact form at http://qt.digia.com/contact-us.
> **
> ** GNU Lesser General Public License Usage
> ** Alternatively, this file may be used under the terms of the GNU Lesser
> ** General Public License version 2.1 as published by the Free Software
> ** Foundation and appearing in the file LICENSE.LGPL included in the
> ** packaging of this file.  Please review the following information to
> ** ensure the GNU Lesser General Public License version 2.1 requirements
> ** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
> **
> ** In addition, as a special exception, Digia gives you certain additional
> ** rights.  These rights are described in the Digia Qt LGPL Exception
> ** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
> **
> ** GNU General Public License Usage
> ** Alternatively, this file may be used under the terms of the GNU
> ** General Public License version 3.0 as published by the Free Software
> ** Foundation and appearing in the file LICENSE.GPL included in the
> ** packaging of this file.  Please review the following information to
> ** ensure the GNU General Public License version 3.0 requirements will be
> ** met: http://www.gnu.org/copyleft/gpl.html.
> **
> **
> ** $QT_END_LICENSE$
>

What is the verdict? Should I have to add any notes on commit message?



Regards,

--
*dS
Diego Sueiro

Administrador do Embarcados
www.embarcados.com.br<http://www.embarcados.com.br/?utm_source=assinatura_diego&utm_medium=e-mail&utm_campaign=Assinatura%20Email%20Diego>

/*long live rock 'n roll*/
Khem Raj - Feb. 24, 2014, 5:43 p.m.
On Monday, February 24, 2014 07:33:03 AM Diego Sueiro wrote:
> Khem,
> 
> On Tue, Feb 18, 2014 at 4:16 PM, Diego Sueiro <diego.sueiro@gmail.com>wrote:
> 
> > I think is a choice.
> > This is what the header says:
> >
> >
> > /****************************************************************************
> > **
> > ** Copyright (C) 2013 Digia Plc and/or its subsidiary(-ies).
> > ** Contact: http://www.qt-project.org/legal
> > **
> > ** This file is part of the Qt Designer of the Qt Toolkit.
> > **
> > ** $QT_BEGIN_LICENSE:LGPL$
> > ** Commercial License Usage
> > ** Licensees holding valid commercial Qt licenses may use this file in
> > ** accordance with the commercial license agreement provided with the
> > ** Software or, alternatively, in accordance with the terms contained in
> > ** a written agreement between you and Digia.  For licensing terms and
> > ** conditions see http://qt.digia.com/licensing.  For further information
> > ** use the contact form at http://qt.digia.com/contact-us.
> > **
> > ** GNU Lesser General Public License Usage
> > ** Alternatively, this file may be used under the terms of the GNU Lesser
> > ** General Public License version 2.1 as published by the Free Software
> > ** Foundation and appearing in the file LICENSE.LGPL included in the
> > ** packaging of this file.  Please review the following information to
> > ** ensure the GNU Lesser General Public License version 2.1 requirements
> > ** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
> > **
> > ** In addition, as a special exception, Digia gives you certain additional
> > ** rights.  These rights are described in the Digia Qt LGPL Exception
> > ** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
> > **
> > ** GNU General Public License Usage
> > ** Alternatively, this file may be used under the terms of the GNU
> > ** General Public License version 3.0 as published by the Free Software
> > ** Foundation and appearing in the file LICENSE.GPL included in the
> > ** packaging of this file.  Please review the following information to
> > ** ensure the GNU General Public License version 3.0 requirements will be
> > ** met: http://www.gnu.org/copyleft/gpl.html.
> > **
> > **
> > ** $QT_END_LICENSE$
> >
> 
> What is the verdict? Should I have to add any notes on commit message?
> 

Document the licensing in the commit, intent is to make it noticeable by and the consumers of QT SDK
so they are aware of compliance.

Patch

diff --git a/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc b/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
index fc1ccba..b040182 100644
--- a/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
+++ b/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
@@ -33,4 +33,5 @@  RDEPENDS_${PN} += " \
         libqt${QTLIBPREFIX}xmlpatterns4-dev \
         libsqlite3-dev \
         expat-dev \
+        qt4${QTLIBPREFIX}-staticdev \
         "