Patchwork [meta-openembedded] libao: Add PACKAGECONFIG for esound support

login
register
mail settings
Submitter Diego Sueiro
Date Feb. 18, 2014, 1:54 p.m.
Message ID <1392731681-6149-1-git-send-email-diego.sueiro@gmail.com>
Download mbox | patch
Permalink /patch/66929/
State Accepted, archived
Headers show

Comments

Diego Sueiro - Feb. 18, 2014, 1:54 p.m.
libao compiling is failing because of a dependency on esound.
Adding PACKAGECONFIG to fix the issue.

Signed-off-by: Diego Sueiro <diego.sueiro@gmail.com>
---
 meta-multimedia/recipes-multimedia/libao/libao_1.1.0.bb |    3 +++
 1 file changed, 3 insertions(+)
Ross Burton - Feb. 18, 2014, 2:10 p.m.
On 18 February 2014 13:54, Diego Sueiro <diego.sueiro@gmail.com> wrote:
> +PACKAGECONFIG ?= ""

Shouldn't that be "??=" ?

Ross
Diego Sueiro - Feb. 18, 2014, 2:28 p.m.
Ross,
On Tue, Feb 18, 2014 at 11:10 AM, Burton, Ross <ross.burton@intel.com>wrote:

> > +PACKAGECONFIG ?= ""
>
> Shouldn't that be "??=" ?
>

I've just followed Martin instructions:
http://lists.openembedded.org/pipermail/openembedded-devel/2014-February/094191.html


Regards,

--
*dS
Diego Sueiro

Administrador do Embarcados
www.embarcados.com.br

/*long live rock 'n roll*/
Diego Sueiro - Feb. 24, 2014, 10:32 a.m.
On Tue, Feb 18, 2014 at 11:28 AM, Diego Sueiro <diego.sueiro@gmail.com>wrote:

> Ross,
>
> On Tue, Feb 18, 2014 at 11:10 AM, Burton, Ross <ross.burton@intel.com>wrote:
>
>> > +PACKAGECONFIG ?= ""
>>
>> Shouldn't that be "??=" ?
>>
>
> I've just followed Martin instructions:
>
> http://lists.openembedded.org/pipermail/openembedded-devel/2014-February/094191.html
>

What is the verdict?

Regards,

--
*dS
Diego Sueiro

Administrador do Embarcados
www.embarcados.com.br<http://www.embarcados.com.br/?utm_source=assinatura_diego&utm_medium=e-mail&utm_campaign=Assinatura%20Email%20Diego>

/*long live rock 'n roll*/
Martin Jansa - Feb. 24, 2014, 10:37 a.m.
On Mon, Feb 24, 2014 at 07:32:07AM -0300, Diego Sueiro wrote:
> On Tue, Feb 18, 2014 at 11:28 AM, Diego Sueiro <diego.sueiro@gmail.com>wrote:
> 
> > Ross,
> >
> > On Tue, Feb 18, 2014 at 11:10 AM, Burton, Ross <ross.burton@intel.com>wrote:
> >
> >> > +PACKAGECONFIG ?= ""
> >>
> >> Shouldn't that be "??=" ?
> >>
> >
> > I've just followed Martin instructions:
> >
> > http://lists.openembedded.org/pipermail/openembedded-devel/2014-February/094191.html
> >
> 
> What is the verdict?

?= is correct (there was discussion about this on oe-core ML)

It was merged yesterday.
http://git.openembedded.org/meta-openembedded/commit/?id=bc6e6112e6c7082241c69fb3d8277b267dd5620a

> 
> Regards,
> 
> --
> *dS
> Diego Sueiro
> 
> Administrador do Embarcados
> www.embarcados.com.br<http://www.embarcados.com.br/?utm_source=assinatura_diego&utm_medium=e-mail&utm_campaign=Assinatura%20Email%20Diego>
> 
> /*long live rock 'n roll*/
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Diego Sueiro - Feb. 24, 2014, 10:52 a.m.
On Mon, Feb 24, 2014 at 7:37 AM, Martin Jansa <martin.jansa@gmail.com>wrote:

> ?= is correct (there was discussion about this on oe-core ML)
>
> It was merged yesterday.
>
> http://git.openembedded.org/meta-openembedded/commit/?id=bc6e6112e6c7082241c69fb3d8277b267dd5620a
>
Thanks Martin,
I didn't saw that it was already merged.


Regards,

--
*dS
Diego Sueiro

Administrador do Embarcados
www.embarcados.com.br<http://www.embarcados.com.br/?utm_source=assinatura_diego&utm_medium=e-mail&utm_campaign=Assinatura%20Email%20Diego>

/*long live rock 'n roll*/

Patch

diff --git a/meta-multimedia/recipes-multimedia/libao/libao_1.1.0.bb b/meta-multimedia/recipes-multimedia/libao/libao_1.1.0.bb
index efd5ec3..1ca140a 100644
--- a/meta-multimedia/recipes-multimedia/libao/libao_1.1.0.bb
+++ b/meta-multimedia/recipes-multimedia/libao/libao_1.1.0.bb
@@ -23,3 +23,6 @@  python populate_packages_prepend () {
     do_split_packages(d, rootdir, '^(.*)\.so$', output_pattern='${BPN}-plugin-%s', description='AO %s plugin')
     do_split_packages(d, rootdir_dbg, '^(.*)\.so$', output_pattern='${BPN}-plugin-%s-dbg', description='AO %s plugin debug data')
 }
+
+PACKAGECONFIG ?= ""
+PACKAGECONFIG[esound] = "--enable-esd,--disable-esd,esound"