Patchwork [RFC,v3,0/9] Linux 3.0 build support

login
register
mail settings
Submitter Anders Darander
Date June 29, 2011, 5:54 p.m.
Message ID <cover.1309370038.git.anders@chargestorm.se>
Download mbox
Permalink /patch/6687/
State Superseded
Headers show

Pull-request

git://github.com/darander/oe-core kernel-3.0

Comments

Anders Darander - June 29, 2011, 5:54 p.m.
v3: - task-base.bb: fix a problem that *pcmia26 couldn't be found.

v2: Probably some more patches could be squashed together. There might also
    be more places that should be addressed in these patches.

    - Whitespace fixes
    - Updated module-init-tools to 3.16. I'm not applying the ignore*.patch
    (it didn't apply).
    - Do not provide virtual/*/depmod-2.6; just provide virtual/*/depmod.
    - Do only install as depmod.
    - Rearrange the order of some patches.
    - Added patches to clean up (partly) task-base, distro_tracking_fields.

    A few of the patches might be ready to pull, but the majority will need
    to be revised.

===============
This work is unfinished and incomplete...
It is published in its current form both to get feedback, but also to aid
anyone else who is working on 3.0-support. If some of the patches are found to
be OK, it's fine to cherrypick them.

The kernel-related classes has been modified to build a 3.0 kernel. The
patches has been simplified by removing support for the 2.4-series. (The
latter was suggested in an older mail thread:
http://www.mail-archive.com/openembedded-core@lists.openembedded.org/msg02682.html
).

The patches has been tested on linux-yocto_2.6.37 and a hacked version using
the linux-yocto-dev repository (using a 3.0-rcX). The latest versions has only
been built for qemuarm, prior iterations has also been built for qemux86.

Finally, no work has been done on the libc-linux-headers classes and recipes.

/Anders

Please review the following changes for suitability for inclusion. If you have
any objections or suggestions for improvement, please respond to the patches. If
you agree with the changes, please provide your Acked-by.

The following changes since commit ff014d9634638457622f6019b163e75bafcefada:

  task-base: add 3G into DISTRO_FEATURE (2011-06-29 14:46:46 +0100)

are available in the git repository at:
  git://github.com/darander/oe-core kernel-3.0
  https://github.com/darander/oe-core/tree/kernel-3.0

Anders Darander (9):
  Remove support for building 2.4 kernels
  image¡kernel.bblass: do not use depmod-2.6
  modules-init-tools(-cross): update to 3.16
  module-init-tools-cross: do not install depmod as depmod-2.6
  kernel.bblass: remove get_kernelmajorversion
  modutils-initscripts: move recipe prior to modutils removal
  modutils: remove modutils
  task-base: remove modutils reference.
  distro_tracking_fields: remove modutils.

 meta/classes/image.bbclass                         |    2 +-
 meta/classes/kernel.bbclass                        |   22 ++----
 meta/classes/linux-kernel-base.bbclass             |    8 --
 meta/classes/module-base.bbclass                   |    2 +-
 .../conf/distro/include/distro_tracking_fields.inc |    8 +--
 meta/recipes-core/tasks/task-base.bb               |   24 +----
 .../{modutils => module-init-tools}/files/PD.patch |    0
 .../files/modutils.sh                              |    0
 .../module-init-tools-cross_3.12.bb                |   12 ---
 .../module-init-tools-cross_3.16.bb                |    8 ++
 .../module-init-tools/module-init-tools.inc        |    1 -
 ...nit-tools_3.12.bb => module-init-tools_3.16.bb} |    6 +-
 .../modutils-initscripts.bb                        |    0
 meta/recipes-kernel/modutils/files/armeb.patch     |   16 ----
 meta/recipes-kernel/modutils/files/configure.patch |   34 -------
 meta/recipes-kernel/modutils/files/gcc4.patch      |   93 --------------------
 meta/recipes-kernel/modutils/files/lex.l.diff      |   35 --------
 .../modutils/files/modutils-notest.patch           |   16 ----
 .../modutils/files/program_prefix.patch            |   71 ---------------
 .../recipes-kernel/modutils/modutils-collateral.bb |   21 -----
 .../modutils/modutils-cross/module.h.diff          |   35 --------
 .../modutils/modutils-cross_2.4.27.bb              |   20 ----
 meta/recipes-kernel/modutils/modutils_2.4.27.bb    |   93 --------------------
 23 files changed, 24 insertions(+), 503 deletions(-)
 rename meta/recipes-kernel/{modutils => module-init-tools}/files/PD.patch (100%)
 rename meta/recipes-kernel/{modutils => module-init-tools}/files/modutils.sh (100%)
 delete mode 100644 meta/recipes-kernel/module-init-tools/module-init-tools-cross_3.12.bb
 create mode 100644 meta/recipes-kernel/module-init-tools/module-init-tools-cross_3.16.bb
 rename meta/recipes-kernel/module-init-tools/{module-init-tools_3.12.bb => module-init-tools_3.16.bb} (87%)
 rename meta/recipes-kernel/{modutils => module-init-tools}/modutils-initscripts.bb (100%)
 delete mode 100644 meta/recipes-kernel/modutils/files/armeb.patch
 delete mode 100644 meta/recipes-kernel/modutils/files/configure.patch
 delete mode 100644 meta/recipes-kernel/modutils/files/gcc4.patch
 delete mode 100644 meta/recipes-kernel/modutils/files/lex.l.diff
 delete mode 100644 meta/recipes-kernel/modutils/files/modules
 delete mode 100644 meta/recipes-kernel/modutils/files/modules.conf
 delete mode 100644 meta/recipes-kernel/modutils/files/modutils-notest.patch
 delete mode 100644 meta/recipes-kernel/modutils/files/program_prefix.patch
 delete mode 100644 meta/recipes-kernel/modutils/modutils-collateral.bb
 delete mode 100644 meta/recipes-kernel/modutils/modutils-cross/module.h.diff
 delete mode 100644 meta/recipes-kernel/modutils/modutils-cross_2.4.27.bb
 delete mode 100644 meta/recipes-kernel/modutils/modutils_2.4.27.bb
Anders Darander - June 29, 2011, 5:54 p.m.
Signed-off-by: Anders Darander <anders@chargestorm.se>
---
 .../{modutils => module-init-tools}/files/PD.patch |    0
 .../files/modutils.sh                              |    0
 .../modutils-initscripts.bb                        |    0
 3 files changed, 0 insertions(+), 0 deletions(-)
 rename meta/recipes-kernel/{modutils => module-init-tools}/files/PD.patch (100%)
 rename meta/recipes-kernel/{modutils => module-init-tools}/files/modutils.sh (100%)
 rename meta/recipes-kernel/{modutils => module-init-tools}/modutils-initscripts.bb (100%)

diff --git a/meta/recipes-kernel/modutils/files/PD.patch b/meta/recipes-kernel/module-init-tools/files/PD.patch
similarity index 100%
rename from meta/recipes-kernel/modutils/files/PD.patch
rename to meta/recipes-kernel/module-init-tools/files/PD.patch
diff --git a/meta/recipes-kernel/modutils/files/modutils.sh b/meta/recipes-kernel/module-init-tools/files/modutils.sh
similarity index 100%
rename from meta/recipes-kernel/modutils/files/modutils.sh
rename to meta/recipes-kernel/module-init-tools/files/modutils.sh
diff --git a/meta/recipes-kernel/modutils/modutils-initscripts.bb b/meta/recipes-kernel/module-init-tools/modutils-initscripts.bb
similarity index 100%
rename from meta/recipes-kernel/modutils/modutils-initscripts.bb
rename to meta/recipes-kernel/module-init-tools/modutils-initscripts.bb
Anders Darander - June 29, 2011, 6:02 p.m.
On Wed, Jun 29, 2011 at 19:54, Anders Darander <anders@chargestorm.se> wrote:
>
> v3: - task-base.bb: fix a problem that *pcmia26 couldn't be found.

This third version fixes a bug introduced in v2. (task-base-pcmcia26
weren't found). The fix is incorporated in patch 0008 (task-base).

Sofar, I've only got positive feedback on v2. (some feedback off-list
(including some that probably should have been on-list if it hadn't
been for some gmane problems).

Unless I find some more problems, or get such reports, I plan to send
a pull request towards the end of this week.

Regards,
Anders
Richard Purdie - June 30, 2011, 8 a.m.
On Wed, 2011-06-29 at 20:02 +0200, Anders Darander wrote:
> On Wed, Jun 29, 2011 at 19:54, Anders Darander <anders@chargestorm.se> wrote:
> >
> > v3: - task-base.bb: fix a problem that *pcmia26 couldn't be found.
> 
> This third version fixes a bug introduced in v2. (task-base-pcmcia26
> weren't found). The fix is incorporated in patch 0008 (task-base).
> 
> Sofar, I've only got positive feedback on v2. (some feedback off-list
> (including some that probably should have been on-list if it hadn't
> been for some gmane problems).
> 
> Unless I find some more problems, or get such reports, I plan to send
> a pull request towards the end of this week.

It looks good to me apart from some ordering and PR bump type issues. 

Where you change the depmod dependency for example, we really need to
rebuild module-init-tools at the same time so the binary changes name at
the right point in the series. Patch 4 and patch 2 therefore probably
need to be together with a PR bump. I also wondered what the patch to
module-init-tools you're removing does (and why you just disabled rather
than deleted it).

Looks good though! I'm trying to resist merging some of the standalone
bits straight away :)

Cheers,

Richard
Anders Darander - June 30, 2011, 9:20 a.m.
On Thu, Jun 30, 2011 at 10:00, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Wed, 2011-06-29 at 20:02 +0200, Anders Darander wrote:
>> On Wed, Jun 29, 2011 at 19:54, Anders Darander <anders@chargestorm.se> wrote:
>> >
>> > v3: - task-base.bb: fix a problem that *pcmia26 couldn't be found.

>> Unless I find some more problems, or get such reports, I plan to send
>> a pull request towards the end of this week.
>
> It looks good to me apart from some ordering and PR bump type issues.
>
> Where you change the depmod dependency for example, we really need to
> rebuild module-init-tools at the same time so the binary changes name at
> the right point in the series. Patch 4 and patch 2 therefore probably
> need to be together with a PR bump.

You're right, of course there should have been a PR bump there. I'll fix it and
squash patch 4 into patch 2 before I'll send a pull request.

>  I also wondered what the patch to
> module-init-tools you're removing does (and why you just disabled rather
> than deleted it).

I left it in there of laziness, in case someone had objected to the disabling
of the patch. As I'm not really sure of the purpose of that patch, I'll delete
the patch before I send the pull request. Then we'll probably find out
if someone
had any need for that patch...

> Looks good though! I'm trying to resist merging some of the standalone
> bits straight away :)

Thanks!
If you get too eager to cherrypick a few bits, it's no problem.
Otherwise you can
count on getting a pull request tomorrow.

Cheers,
Anders