Patchwork [v2,1/1] am-benchmarks: Remove platform dependencies

login
register
mail settings
Submitter Jeff Lance
Date June 29, 2011, 4:33 p.m.
Message ID <1309365186-10742-1-git-send-email-j-lance1@ti.com>
Download mbox | patch
Permalink /patch/6685/
State Superseded
Headers show

Comments

Jeff Lance - June 29, 2011, 4:33 p.m.
* Remove platform dependencies and use architecture dependencies instead
* Use OE BASE_PACKAGE_ARCH to determine architecture
* Update the SRCREV to revision 66
* Update the recipe revision to 1.3
* Removed INSANE_SKIP
NOTE - architecture dependency can be removed once CFLAGS can be passed into CCSv5 project makefile

Signed-off-by: Jeff Lance <j-lance1@ti.com>
---
Updated in version 2:
  Removed INSANE_SKIP directive
  updated SRCREV from 65 to 66
  used find-copies-harder to show differences with previous recipe
--
 recipes/ti/am-benchmarks_1.3.bb |   33 +++++++++++++++++++++++++++++++++
 1 files changed, 33 insertions(+), 0 deletions(-)
 create mode 100644 recipes/ti/am-benchmarks_1.3.bb
Koen Kooi - June 30, 2011, 8:53 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 29-06-11 18:33, Jeff Lance wrote:
> * Remove platform dependencies and use architecture dependencies instead
> * Use OE BASE_PACKAGE_ARCH to determine architecture
> * Update the SRCREV to revision 66
> * Update the recipe revision to 1.3
> * Removed INSANE_SKIP
> NOTE - architecture dependency can be removed once CFLAGS can be passed into CCSv5 project makefile
> 
> Signed-off-by: Jeff Lance <j-lance1@ti.com>

Much better, thanks!

Acked-by: Koen Kooi <koen@dominion.thruhere.net>

> ---
> Updated in version 2:
>   Removed INSANE_SKIP directive
>   updated SRCREV from 65 to 66
>   used find-copies-harder to show differences with previous recipe
> --
>  recipes/ti/am-benchmarks_1.3.bb |   33 +++++++++++++++++++++++++++++++++
>  1 files changed, 33 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/ti/am-benchmarks_1.3.bb
> 
> diff --git a/recipes/ti/am-benchmarks_1.3.bb b/recipes/ti/am-benchmarks_1.3.bb
> new file mode 100644
> index 0000000..8ac9b74
> --- /dev/null
> +++ b/recipes/ti/am-benchmarks_1.3.bb
> @@ -0,0 +1,33 @@
> +#NOTE: This package is currently only supported for the Angstrom
> +#      distribution.  Other distributions and toolchains may or
> +#      may not work.
> +
> +DESCRIPTION = "AM Benchmarks"
> +HOMEPAGE = "https://gforge.ti.com/gf/project/am_benchmarks/"
> +LICENSE = "BSD"
> +SECTION = "system"
> +PRIORITY = "optional"
> +
> +SRCREV = "66"
> +PR = "r2+svnr${SRCPV}"
> +
> +SRC_URI = "svn://gforge.ti.com/svn/am_benchmarks/;module=trunk;proto=https;user=anonymous;pswd=''"
> +
> +S = "${WORKDIR}/trunk"
> +
> +do_configure() {
> +        sed -i -e 's|LIBS :=|LIBS := ${LDFLAGS} |' Release/objects.mk
> +}
> +
> +do_compile() {
> +	# don't build debug version
> +	touch debug
> +	export CROSS_COMPILE=${TARGET_PREFIX}
> +	export ARCH=${BASE_PACKAGE_ARCH}
> +	make release 
> +}
> +
> +do_install() {
> +	export ARCH=${BASE_PACKAGE_ARCH}
> +	make DESTDIR=${D} install
> +}

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFODDlvMkyGM64RGpERAkG8AJ4nj8TWYoY89u9XJHPiw13adfgeGACgp69I
UxVJuBlADDqibDEyEAUuBcE=
=yCEc
-----END PGP SIGNATURE-----
chase maupin - June 30, 2011, 11:51 a.m.
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> Koen Kooi
> Sent: Thursday, June 30, 2011 3:53 AM
> To: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [PATCH v2 1/1] am-benchmarks: Remove platform
> dependencies
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 29-06-11 18:33, Jeff Lance wrote:
> > * Remove platform dependencies and use architecture dependencies
> instead
> > * Use OE BASE_PACKAGE_ARCH to determine architecture
> > * Update the SRCREV to revision 66
> > * Update the recipe revision to 1.3
> > * Removed INSANE_SKIP
> > NOTE - architecture dependency can be removed once CFLAGS can be
> passed into CCSv5 project makefile
> >
> > Signed-off-by: Jeff Lance <j-lance1@ti.com>
> 
> Much better, thanks!
> 
> Acked-by: Koen Kooi <koen@dominion.thruhere.net>

NAK

My testing shows this sed command does not work the way it was intended.  I have given Jeff an updated command to submit another version of th patch.

> 
> > ---
> > Updated in version 2:
> >   Removed INSANE_SKIP directive
> >   updated SRCREV from 65 to 66
> >   used find-copies-harder to show differences with previous recipe
> > --
> >  recipes/ti/am-benchmarks_1.3.bb |   33
> +++++++++++++++++++++++++++++++++
> >  1 files changed, 33 insertions(+), 0 deletions(-)
> >  create mode 100644 recipes/ti/am-benchmarks_1.3.bb
> >
> > diff --git a/recipes/ti/am-benchmarks_1.3.bb b/recipes/ti/am-
> benchmarks_1.3.bb
> > new file mode 100644
> > index 0000000..8ac9b74
> > --- /dev/null
> > +++ b/recipes/ti/am-benchmarks_1.3.bb
> > @@ -0,0 +1,33 @@
> > +#NOTE: This package is currently only supported for the Angstrom
> > +#      distribution.  Other distributions and toolchains may or
> > +#      may not work.
> > +
> > +DESCRIPTION = "AM Benchmarks"
> > +HOMEPAGE = "https://gforge.ti.com/gf/project/am_benchmarks/"
> > +LICENSE = "BSD"
> > +SECTION = "system"
> > +PRIORITY = "optional"
> > +
> > +SRCREV = "66"
> > +PR = "r2+svnr${SRCPV}"
> > +
> > +SRC_URI =
> "svn://gforge.ti.com/svn/am_benchmarks/;module=trunk;proto=https;user=a
> nonymous;pswd=''"
> > +
> > +S = "${WORKDIR}/trunk"
> > +
> > +do_configure() {
> > +        sed -i -e 's|LIBS :=|LIBS := ${LDFLAGS} |'
> Release/objects.mk
> > +}
> > +
> > +do_compile() {
> > +	# don't build debug version
> > +	touch debug
> > +	export CROSS_COMPILE=${TARGET_PREFIX}
> > +	export ARCH=${BASE_PACKAGE_ARCH}
> > +	make release
> > +}
> > +
> > +do_install() {
> > +	export ARCH=${BASE_PACKAGE_ARCH}
> > +	make DESTDIR=${D} install
> > +}
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> 
> iD8DBQFODDlvMkyGM64RGpERAkG8AJ4nj8TWYoY89u9XJHPiw13adfgeGACgp69I
> UxVJuBlADDqibDEyEAUuBcE=
> =yCEc
> -----END PGP SIGNATURE-----
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Patch

diff --git a/recipes/ti/am-benchmarks_1.3.bb b/recipes/ti/am-benchmarks_1.3.bb
new file mode 100644
index 0000000..8ac9b74
--- /dev/null
+++ b/recipes/ti/am-benchmarks_1.3.bb
@@ -0,0 +1,33 @@ 
+#NOTE: This package is currently only supported for the Angstrom
+#      distribution.  Other distributions and toolchains may or
+#      may not work.
+
+DESCRIPTION = "AM Benchmarks"
+HOMEPAGE = "https://gforge.ti.com/gf/project/am_benchmarks/"
+LICENSE = "BSD"
+SECTION = "system"
+PRIORITY = "optional"
+
+SRCREV = "66"
+PR = "r2+svnr${SRCPV}"
+
+SRC_URI = "svn://gforge.ti.com/svn/am_benchmarks/;module=trunk;proto=https;user=anonymous;pswd=''"
+
+S = "${WORKDIR}/trunk"
+
+do_configure() {
+        sed -i -e 's|LIBS :=|LIBS := ${LDFLAGS} |' Release/objects.mk
+}
+
+do_compile() {
+	# don't build debug version
+	touch debug
+	export CROSS_COMPILE=${TARGET_PREFIX}
+	export ARCH=${BASE_PACKAGE_ARCH}
+	make release 
+}
+
+do_install() {
+	export ARCH=${BASE_PACKAGE_ARCH}
+	make DESTDIR=${D} install
+}