Patchwork pseudo-1.5.1: keep install command directory mode

login
register
mail settings
Submitter yanjun.zhu
Date Feb. 17, 2014, 10:17 a.m.
Message ID <1392632257-4669-1-git-send-email-yanjun.zhu@windriver.com>
Download mbox | patch
Permalink /patch/66829/
State New
Headers show

Comments

yanjun.zhu - Feb. 17, 2014, 10:17 a.m.
From: "yanjun.zhu" <yanjun.zhu@windriver.com>

CQID:LIN5-17788

when install command sets the created directory mode, pseudo will change
the mode of the directory to 0700 incorrectly.

Signed-off-by: yanjun.zhu <yanjun.zhu@windriver.com>
---
 .../pseudo-1.5.1-install-directory-mode.patch      |   10 ++++++++++
 meta/recipes-devtools/pseudo/pseudo_1.5.1.bb       |    3 ++-
 2 files changed, 12 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/pseudo/files/pseudo-1.5.1-install-directory-mode.patch
Saul Wold - Feb. 18, 2014, 7:08 p.m.
On 02/17/2014 02:17 AM, Zhu Yanjun wrote:
> From: "yanjun.zhu" <yanjun.zhu@windriver.com>
>
> CQID:LIN5-17788
>
> when install command sets the created directory mode, pseudo will change
> the mode of the directory to 0700 incorrectly.
>
> Signed-off-by: yanjun.zhu <yanjun.zhu@windriver.com>
> ---
>   .../pseudo-1.5.1-install-directory-mode.patch      |   10 ++++++++++
>   meta/recipes-devtools/pseudo/pseudo_1.5.1.bb       |    3 ++-
>   2 files changed, 12 insertions(+), 1 deletion(-)
>   create mode 100644 meta/recipes-devtools/pseudo/files/pseudo-1.5.1-install-directory-mode.patch
>
> diff --git a/meta/recipes-devtools/pseudo/files/pseudo-1.5.1-install-directory-mode.patch b/meta/recipes-devtools/pseudo/files/pseudo-1.5.1-install-directory-mode.patch
> new file mode 100644
> index 0000000..02e3da2

There is no patch header here, also have you checked with Peter S on 
this change?

> --- /dev/null
> +++ b/meta/recipes-devtools/pseudo/files/pseudo-1.5.1-install-directory-mode.patch
> @@ -0,0 +1,10 @@
> +--- a/ports/unix/guts/mkdirat.c
> ++++ b/ports/unix/guts/mkdirat.c
> +@@ -25,6 +25,7 @@
> + 		stat_rc = base_fstatat(dirfd, path, &buf, AT_SYMLINK_NOFOLLOW);
> + #endif
> + 		if (stat_rc != -1) {
> ++			buf.st_mode = PSEUDO_DB_MODE(buf.st_mode, mode);
> + 			pseudo_client_op(OP_MKDIR, 0, -1, dirfd, path, &buf);
> + 		} else {
> + 			pseudo_debug(1, "mkdir of %s succeeded, but stat failed: %s\n",
> diff --git a/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb b/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb
> index bc92856..64115ca 100644
> --- a/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb
> +++ b/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb
> @@ -1,11 +1,12 @@
>   require pseudo.inc
>
> -PR = "r4"
> +PR = "r5"
>
No PR Bumps needed any longer

Sau!


>   SRC_URI = " \
>       http://www.yoctoproject.org/downloads/${BPN}/${BPN}-${PV}.tar.bz2 \
>       file://0001-pseudo_has_unload-add-function.patch \
>       file://shutdownping.patch \
> +    file://pseudo-1.5.1-install-directory-mode.patch \
>   "
>
>   SRC_URI[md5sum] = "5ec67c7bff5fe68c56de500859c19172"
>
Peter Seebach - Feb. 18, 2014, 9:31 p.m.
On Tue, 18 Feb 2014 11:08:40 -0800
Saul Wold <sgw@linux.intel.com> wrote:

> There is no patch header here, also have you checked with Peter S on 
> this change?

The change originated with me, and is in my current 1.6 pseudo branch. The
backport was being submitted because I am on other projects actively enough
that I haven't got the time to finish the work for getting 1.6 ready to
submit.

-s
Saul Wold - Feb. 18, 2014, 10:31 p.m.
On 02/18/2014 01:31 PM, Peter Seebach wrote:
> On Tue, 18 Feb 2014 11:08:40 -0800
> Saul Wold <sgw@linux.intel.com> wrote:
>
>> There is no patch header here, also have you checked with Peter S on
>> this change?
>
> The change originated with me, and is in my current 1.6 pseudo branch. The
> backport was being submitted because I am on other projects actively enough
> that I haven't got the time to finish the work for getting 1.6 ready to
> submit.
>
Great, had the patch header been there, I would not have to second guess 
and loop you in again.

Sau!

> -s
>

Patch

diff --git a/meta/recipes-devtools/pseudo/files/pseudo-1.5.1-install-directory-mode.patch b/meta/recipes-devtools/pseudo/files/pseudo-1.5.1-install-directory-mode.patch
new file mode 100644
index 0000000..02e3da2
--- /dev/null
+++ b/meta/recipes-devtools/pseudo/files/pseudo-1.5.1-install-directory-mode.patch
@@ -0,0 +1,10 @@ 
+--- a/ports/unix/guts/mkdirat.c
++++ b/ports/unix/guts/mkdirat.c
+@@ -25,6 +25,7 @@
+ 		stat_rc = base_fstatat(dirfd, path, &buf, AT_SYMLINK_NOFOLLOW);
+ #endif
+ 		if (stat_rc != -1) {
++			buf.st_mode = PSEUDO_DB_MODE(buf.st_mode, mode);
+ 			pseudo_client_op(OP_MKDIR, 0, -1, dirfd, path, &buf);
+ 		} else {
+ 			pseudo_debug(1, "mkdir of %s succeeded, but stat failed: %s\n",
diff --git a/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb b/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb
index bc92856..64115ca 100644
--- a/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb
+++ b/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb
@@ -1,11 +1,12 @@ 
 require pseudo.inc
 
-PR = "r4"
+PR = "r5"
 
 SRC_URI = " \
     http://www.yoctoproject.org/downloads/${BPN}/${BPN}-${PV}.tar.bz2 \
     file://0001-pseudo_has_unload-add-function.patch \
     file://shutdownping.patch \
+    file://pseudo-1.5.1-install-directory-mode.patch \
 "
 
 SRC_URI[md5sum] = "5ec67c7bff5fe68c56de500859c19172"