Patchwork [meta-fsl-arm-extra] defconfig: CONFIG_DEVTMPFS=y CONFIG_DEVTMPFS_MOUNT=y linux-imx_3.0.35.bbappend: Correct the patch string.

login
register
mail settings
Submitter pavel.kopylov@gmail.com
Date Feb. 6, 2014, 1:05 p.m.
Message ID <1391691906-20980-1-git-send-email-pavel.kopylov@gmail.com>
Download mbox | patch
Permalink /patch/66369/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

pavel.kopylov@gmail.com - Feb. 6, 2014, 1:05 p.m.
From: pavel <pavel@pavel>


Signed-off-by: pavel <pavel@pavel>
---
 .../linux/linux-imx-3.0.35/cgtqmx6/defconfig       |    3 ++-
 recipes-kernel/linux/linux-imx_3.0.35.bbappend     |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
Gary Thomas - Feb. 6, 2014, 1:17 p.m.
On 2014-02-06 06:05, pavel.kopylov@gmail.com wrote:
> From: pavel <pavel@pavel>
> 
> 
> Signed-off-by: pavel <pavel@pavel>

What kind of useless address is this?  The 'Signed-off-by' is only
useful if it points to a real person (or entity) that can be contacted
about the patch.

> ---
>  .../linux/linux-imx-3.0.35/cgtqmx6/defconfig       |    3 ++-
>  recipes-kernel/linux/linux-imx_3.0.35.bbappend     |    2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes-kernel/linux/linux-imx-3.0.35/cgtqmx6/defconfig b/recipes-kernel/linux/linux-imx-3.0.35/cgtqmx6/defconfig
> index 05fd3b3..8030291 100644
> --- a/recipes-kernel/linux/linux-imx-3.0.35/cgtqmx6/defconfig
> +++ b/recipes-kernel/linux/linux-imx-3.0.35/cgtqmx6/defconfig
> @@ -691,7 +691,8 @@ CONFIG_RFKILL_INPUT=y
>  # Generic Driver Options
>  #
>  CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
> -# CONFIG_DEVTMPFS is not set
> +CONFIG_DEVTMPFS=y
> +CONFIG_DEVTMPFS_MOUNT=y
>  CONFIG_STANDALONE=y
>  CONFIG_PREVENT_FIRMWARE_BUILD=y
>  CONFIG_FW_LOADER=y
> diff --git a/recipes-kernel/linux/linux-imx_3.0.35.bbappend b/recipes-kernel/linux/linux-imx_3.0.35.bbappend
> index c3d50fc..9a8b2fb 100644
> --- a/recipes-kernel/linux/linux-imx_3.0.35.bbappend
> +++ b/recipes-kernel/linux/linux-imx_3.0.35.bbappend
> @@ -2,4 +2,4 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
>  
>  PRINC := "${@int(PRINC) + 5}"
>  
> -SRC_URI_append_cgtqmx6 = "file://cgtqmx6/0001-Add-linux-support-for-congatec-evaluation-board-qmx6q.patch"
> +SRC_URI_append_cgtqmx6 = " file://cgtqmx6/0001-Add-linux-support-for-congatec-evaluation-board-qmx6q.patch"
>
Otavio Salvador - Feb. 6, 2014, 8:18 p.m.
Hello Pavel,

On Thu, Feb 6, 2014 at 11:05 AM,  <pavel.kopylov@gmail.com> wrote:
> From: pavel <pavel@pavel>
>
>
> Signed-off-by: pavel <pavel@pavel>

Please put a proper Author name, e-mail address and commit log. We
cannot include things without authorship.

> ---
>  .../linux/linux-imx-3.0.35/cgtqmx6/defconfig       |    3 ++-
>  recipes-kernel/linux/linux-imx_3.0.35.bbappend     |    2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-kernel/linux/linux-imx-3.0.35/cgtqmx6/defconfig b/recipes-kernel/linux/linux-imx-3.0.35/cgtqmx6/defconfig
> index 05fd3b3..8030291 100644
> --- a/recipes-kernel/linux/linux-imx-3.0.35/cgtqmx6/defconfig
> +++ b/recipes-kernel/linux/linux-imx-3.0.35/cgtqmx6/defconfig
> @@ -691,7 +691,8 @@ CONFIG_RFKILL_INPUT=y
>  # Generic Driver Options
>  #
>  CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
> -# CONFIG_DEVTMPFS is not set
> +CONFIG_DEVTMPFS=y
> +CONFIG_DEVTMPFS_MOUNT=y
>  CONFIG_STANDALONE=y
>  CONFIG_PREVENT_FIRMWARE_BUILD=y
>  CONFIG_FW_LOADER=y

Fine.

> diff --git a/recipes-kernel/linux/linux-imx_3.0.35.bbappend b/recipes-kernel/linux/linux-imx_3.0.35.bbappend
> index c3d50fc..9a8b2fb 100644
> --- a/recipes-kernel/linux/linux-imx_3.0.35.bbappend
> +++ b/recipes-kernel/linux/linux-imx_3.0.35.bbappend
> @@ -2,4 +2,4 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
>
>  PRINC := "${@int(PRINC) + 5}"
>
> -SRC_URI_append_cgtqmx6 = "file://cgtqmx6/0001-Add-linux-support-for-congatec-evaluation-board-qmx6q.patch"
> +SRC_URI_append_cgtqmx6 = " file://cgtqmx6/0001-Add-linux-support-for-congatec-evaluation-board-qmx6q.patch"

This is needed just for Dora and I have did this in another patch in
my local branch which I will send when I get this one merged into
master and backported.

Please fix the patch so we can move further.

Patch

diff --git a/recipes-kernel/linux/linux-imx-3.0.35/cgtqmx6/defconfig b/recipes-kernel/linux/linux-imx-3.0.35/cgtqmx6/defconfig
index 05fd3b3..8030291 100644
--- a/recipes-kernel/linux/linux-imx-3.0.35/cgtqmx6/defconfig
+++ b/recipes-kernel/linux/linux-imx-3.0.35/cgtqmx6/defconfig
@@ -691,7 +691,8 @@  CONFIG_RFKILL_INPUT=y
 # Generic Driver Options
 #
 CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
-# CONFIG_DEVTMPFS is not set
+CONFIG_DEVTMPFS=y
+CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_STANDALONE=y
 CONFIG_PREVENT_FIRMWARE_BUILD=y
 CONFIG_FW_LOADER=y
diff --git a/recipes-kernel/linux/linux-imx_3.0.35.bbappend b/recipes-kernel/linux/linux-imx_3.0.35.bbappend
index c3d50fc..9a8b2fb 100644
--- a/recipes-kernel/linux/linux-imx_3.0.35.bbappend
+++ b/recipes-kernel/linux/linux-imx_3.0.35.bbappend
@@ -2,4 +2,4 @@  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
 
 PRINC := "${@int(PRINC) + 5}"
 
-SRC_URI_append_cgtqmx6 = "file://cgtqmx6/0001-Add-linux-support-for-congatec-evaluation-board-qmx6q.patch"
+SRC_URI_append_cgtqmx6 = " file://cgtqmx6/0001-Add-linux-support-for-congatec-evaluation-board-qmx6q.patch"