Patchwork [1/1] systemtap: add aarch64 support

login
register
mail settings
Submitter Fathi Boudra
Date Feb. 5, 2014, 3:10 p.m.
Message ID <1391613014-5792-1-git-send-email-fathi.boudra@linaro.org>
Download mbox | patch
Permalink /patch/66343/
State New
Headers show

Comments

Fathi Boudra - Feb. 5, 2014, 3:10 p.m.
bump SRCREV to include the relevant commits for aarch64 support
update COMPATIBLE_HOST to include aarch64
cleanup md5sum/sha256sum since we use git

Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
---
 meta/recipes-kernel/systemtap/systemtap_git.inc | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
Otavio Salvador - Feb. 12, 2014, 4:23 p.m.
Hello,

On Wed, Feb 5, 2014 at 1:10 PM, Fathi Boudra <fathi.boudra@linaro.org> wrote:
> bump SRCREV to include the relevant commits for aarch64 support
> update COMPATIBLE_HOST to include aarch64
> cleanup md5sum/sha256sum since we use git
>
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>

This broke master in our autobuilder:

 | .../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0r0/git/includes
-I./includes/sys -DSTAP_SDT_V2
-isystem.../build/tmp/sysroots/x86_64-linux/usr/include -Wall -Werror
 -isystem.../build/tmp/sysroots/x86_64-linux/usr/include -O2 -pipe
-fstack-protector-all -D_FORTIFY_SOURCE=2 -c -o stap-buildrun.o `test
-f 'buildrun.cxx' || echo
'.../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0/git/'`buildrun.cxx
 | .../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0/git/tapsets.cxx:
In function 'void validate_module_elf(Dwfl_Module*, const char*,
base_query*)':
 | .../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0/git/tapsets.cxx:1998:10:
error: 'EM_AARCH64' was not declared in this scope
 | .../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0/git/tapsets.cxx:
In constructor 'sdt_uprobe_var_expanding_visitor::sdt_uprobe_var_expanding_visitor(systemtap_session&,
int, const string&, const string&, const string&, stap_sdt_probe_type,
const string&, int)':
 | .../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0/git/tapsets.cxx:5613:31:
error: 'EM_AARCH64' was not declared in this scope
 | make[2]: *** [stap-tapsets.o] Error 1
 | make[2]: *** Waiting for unfinished jobs....
 | make[2]: Leaving directory
`.../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0/build'
 | make[1]: *** [all-recursive] Error 1
 | make[1]: Leaving directory
`.../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0/build'
 | make: *** [all] Error 2
 | ERROR: oe_runmake failed
 | WARNING: exit code 1 from a shell command.

Regards,
Fathi Boudra - Feb. 12, 2014, 9:06 p.m.
On 12 February 2014 18:23, Otavio Salvador <otavio@ossystems.com.br> wrote:
> Hello,
>
> On Wed, Feb 5, 2014 at 1:10 PM, Fathi Boudra <fathi.boudra@linaro.org> wrote:
>> bump SRCREV to include the relevant commits for aarch64 support
>> update COMPATIBLE_HOST to include aarch64
>> cleanup md5sum/sha256sum since we use git
>>
>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
>
> This broke master in our autobuilder:
>
>  | .../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0r0/git/includes
> -I./includes/sys -DSTAP_SDT_V2
> -isystem.../build/tmp/sysroots/x86_64-linux/usr/include -Wall -Werror
>  -isystem.../build/tmp/sysroots/x86_64-linux/usr/include -O2 -pipe
> -fstack-protector-all -D_FORTIFY_SOURCE=2 -c -o stap-buildrun.o `test
> -f 'buildrun.cxx' || echo
> '.../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0/git/'`buildrun.cxx
>  | .../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0/git/tapsets.cxx:
> In function 'void validate_module_elf(Dwfl_Module*, const char*,
> base_query*)':
>  | .../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0/git/tapsets.cxx:1998:10:
> error: 'EM_AARCH64' was not declared in this scope
>  | .../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0/git/tapsets.cxx:
> In constructor 'sdt_uprobe_var_expanding_visitor::sdt_uprobe_var_expanding_visitor(systemtap_session&,
> int, const string&, const string&, const string&, stap_sdt_probe_type,
> const string&, int)':
>  | .../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0/git/tapsets.cxx:5613:31:
> error: 'EM_AARCH64' was not declared in this scope
>  | make[2]: *** [stap-tapsets.o] Error 1
>  | make[2]: *** Waiting for unfinished jobs....
>  | make[2]: Leaving directory
> `.../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0/build'
>  | make[1]: *** [all-recursive] Error 1
>  | make[1]: Leaving directory
> `.../build/tmp/work/x86_64-linux/systemtap-native/2.4+gitAUTOINC+9190b3acfe-r0/build'
>  | make: *** [all] Error 2
>  | ERROR: oe_runmake failed
>  | WARNING: exit code 1 from a shell command.
>
> Regards,
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

It's fixed by a later commit: 508059f04842ed85d10bfbec8a9c688d57368860
https://sourceware.org/git/gitweb.cgi?p=systemtap.git;a=commitdiff;h=508059f04842ed85d10bfbec8a9c688d57368860

a patch is coming to bump the SRCREV.

Cheers,
Fathi

Patch

diff --git a/meta/recipes-kernel/systemtap/systemtap_git.inc b/meta/recipes-kernel/systemtap/systemtap_git.inc
index 9da5588..b87aa1a 100644
--- a/meta/recipes-kernel/systemtap/systemtap_git.inc
+++ b/meta/recipes-kernel/systemtap/systemtap_git.inc
@@ -1,7 +1,6 @@ 
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
-
-SRCREV = "aa7b1e00e6cb7058071ead0180de0541b1c6eccf"
+SRCREV = "9190b3acfe706d3bfd66dec18133d28f98443321"
 PV = "2.4+git${SRCPV}"
 
 SRC_URI = "git://sourceware.org/git/systemtap.git \
@@ -11,11 +10,8 @@  SRC_URI = "git://sourceware.org/git/systemtap.git \
 
 FILESPATH = "${FILE_DIRNAME}/systemtap"
 
-SRC_URI[md5sum]    = "cb202866ed704c44a876d041f788bdee"
-SRC_URI[sha256sum] = "8ffe35caec0d937bd23fd78a3a8d94b58907cc0de0330b35e38f9f764815c459"
-
 # systemtap doesn't support mips
-COMPATIBLE_HOST = '(x86_64.*|i.86.*|powerpc.*|arm.*)-linux'
+COMPATIBLE_HOST = '(x86_64|i.86|powerpc|arm|aarch64).*-linux'
 
 S = "${WORKDIR}/git"
 
@@ -29,4 +25,3 @@  def get_optimization(d):
     return selected_optimization
 
 SELECTED_OPTIMIZATION := "${@get_optimization(d)}"
-