Patchwork Busybox menuconfig on host without ncurse development package

login
register
mail settings
Submitter Jacob Kroon
Date Feb. 4, 2014, 8:58 p.m.
Message ID <CAPbeDCnW5vdTHK2os11UdsOPrAcXv_3eqCepTe_ND_TTkq2hSw@mail.gmail.com>
Download mbox | patch
Permalink /patch/66321/
State New
Headers show

Comments

Jacob Kroon - Feb. 4, 2014, 8:58 p.m.
Hi,

I ran into this problem since I didn't happen to have ncurses development
package installed on my host at the time. "bitbake -c menuconfig busybox"
and "make menuconfig" in a busybox devshell fails:

make -f scripts/Makefile.build obj=scripts/kconfig/lxdialog
  gcc -Wp,-MD,scripts/kconfig/lxdialog/.checklist.o.d  -Wall
-Wstrict-prototypes -O2 -fomit-frame-pointer   -DCURSES_LOC="<curses.h>"
-DLOCALE    -c -o scripts/kconfig/lxdialog/checklist.o
scripts/kconfig/lxdialog/checklist.c
In file included from scripts/kconfig/lxdialog/checklist.c:24:0:
scripts/kconfig/lxdialog/dialog.h:31:20: fatal error: curses.h: No such
file or directory
 #include CURSES_LOC
                    ^
compilation terminated.

The following change fixes the problem on my system:

But I'm no kconfig expert.. anyway, anyone have any comments on this ?

"make menuconfig" for the linux kernel works as expected.

  -- Jacob

Patch

--- busybox-1.22.1.orig/scripts/kconfig/lxdialog/Makefile
+++ busybox-1.22.1/scripts/kconfig/lxdialog/Makefile
@@ -5,8 +5,8 @@  check-lxdialog  := $(srctree)/$(src)/che

 # Use reursively expanded variables so we do not call gcc unless
 # we really need to do so. (Do not call gcc as part of make mrproper)
-HOST_EXTRACFLAGS = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ccflags)
-HOST_LOADLIBES   = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags
$(HOSTCC))
+HOST_EXTRACFLAGS += $(shell $(CONFIG_SHELL) $(check-lxdialog) -ccflags)
+HOST_LOADLIBES   += $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags
$(HOSTCC))