Patchwork [meta-perl,1/9] perl-module-metadata: add 1.000019

login
register
mail settings
Submitter Tim Orling
Date Jan. 31, 2014, 3:11 p.m.
Message ID <1391181100-32525-1-git-send-email-ticotimo@gmail.com>
Download mbox | patch
Permalink /patch/66131/
State Superseded, archived
Headers show

Comments

Tim Orling - Jan. 31, 2014, 3:11 p.m.
[Description from CPAN]
This module provides a standard way to gather metadata about a .pm file through (mostly) static analysis and (some) code execution. When determining the version of a module, the $VERSION assignment is "eval"ed, as is traditional in the CPAN toolchain.

Signed-off-by: Tim Orling <ticotimo@gmail.com>
---
 .../perl-module-metadata_1.000019.bb               |   32 ++++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 meta-perl/recipes-perl/module-metadata/perl-module-metadata_1.000019.bb
Olof Johansson - Jan. 31, 2014, 5:26 p.m.
On 14-01-31 16:11 +0100, Tim Orling wrote:
> This module provides a standard way to gather metadata about a
> .pm file through (mostly) static analysis and (some) code
> execution. When determining the version of a module, the
> $VERSION assignment is "eval"ed, as is traditional in the CPAN
> toolchain.

For me, it seems strange to skip out the first part of the module
name, just because it's part of the recipe perl-module- prefix. I
agree it's a bit ugly to call it perl-module-module-metadata, but
I think it would cause less confusion.

On the other hand, the naming convention within meta-perl seems
to be consistently lib<module name>-perl, like it is in Debian.
Same for oecore, except the core modules provided by the perl
recipe. This would make the proper name for this recipe be
libmodule-metadata-perl. Why use the perl-module- prefix?

Regards,
Tim Orling - Jan. 31, 2014, 7:05 p.m.
Koen made a similar comment via private email. I am happy to follow the
Debian convention. I will resubmit the entire series.

Thank you for the input.

Regards,

Tim


On Fri, Jan 31, 2014 at 9:26 AM, Olof Johansson <olof.johansson@axis.com>wrote:

> On 14-01-31 16:11 +0100, Tim Orling wrote:
> > This module provides a standard way to gather metadata about a
> > .pm file through (mostly) static analysis and (some) code
> > execution. When determining the version of a module, the
> > $VERSION assignment is "eval"ed, as is traditional in the CPAN
> > toolchain.
>
> For me, it seems strange to skip out the first part of the module
> name, just because it's part of the recipe perl-module- prefix. I
> agree it's a bit ugly to call it perl-module-module-metadata, but
> I think it would cause less confusion.
>
> On the other hand, the naming convention within meta-perl seems
> to be consistently lib<module name>-perl, like it is in Debian.
> Same for oecore, except the core modules provided by the perl
> recipe. This would make the proper name for this recipe be
> libmodule-metadata-perl. Why use the perl-module- prefix?
>
> Regards,
> --
> olofjn
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Patch

diff --git a/meta-perl/recipes-perl/module-metadata/perl-module-metadata_1.000019.bb b/meta-perl/recipes-perl/module-metadata/perl-module-metadata_1.000019.bb
new file mode 100644
index 0000000..974cc80
--- /dev/null
+++ b/meta-perl/recipes-perl/module-metadata/perl-module-metadata_1.000019.bb
@@ -0,0 +1,32 @@ 
+SUMMARY = "Module::Metadata - Gather package and POD information from perl module files"
+DESCRIPTION = "This module provides a standard way to gather metadata about \
+a .pm files through (mostly) static analysis and (some) code execution. When \
+determining the version of a module, the $VERSION assignment is eval-ed, as \
+is traditional in the CPAN toolchain."
+
+HOMEPAGE = "http://search.cpan.org/~ether/Module-Metadata/"
+
+LICENSE = "Artistic-1.0 | GPL-1.0+"
+LIC_FILES_CHKSUM = "file://README;beginline=185;endline=190;md5=e1b24eebe5d819b40bb68ad06b72d3ee"
+
+SRC_URI = "http://search.cpan.org/CPAN/authors/id/E/ET/ETHER/Module-Metadata-${PV}.tar.gz"
+SRC_URI[md5sum] = "838ecf97f7daff79e0f81e104a6be823"
+SRC_URI[sha256sum] = "5afca94dc0213608101ad519eb1b25133cdc9e44c2a053a45a5a59422c2ee554"
+
+S = "${WORKDIR}/Module-Metadata-${PV}"
+
+inherit cpan
+
+RDEPENDS_${PN} = " perl-module-io-file \
+                   perl-module-data-dumper \
+                   perl-module-extutils-makemaker \
+                   perl-module-file-spec \
+                   perl-module-version \
+                   perl-module-exporter \
+                   perl-module-carp \
+                   perl-module-test-more \
+                   perl-module-file-temp \
+                   perl-module-file-path \
+"
+
+BBCLASSEXTEND = "native"