Patchwork [meta-qt5,RFC] libconnman-qt5: libconnman-qt, Qt5 edition

login
register
mail settings
Submitter Andreas Oberritter
Date Jan. 28, 2014, 9:29 p.m.
Message ID <1390944553-6780-1-git-send-email-obi@opendreambox.org>
Download mbox | patch
Permalink /patch/65983/
State RFC
Headers show

Comments

Andreas Oberritter - Jan. 28, 2014, 9:29 p.m.
* Please, don't apply! ;-)

Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
---
Several questions arose regarding this recipe:

1.) Where to put it? It depends on both meta-openembedded and meta-qt5.

2.) Regarding OE_QMAKE_PATH_HEADERS: I stole this from maliit to fix a
    compiler error, but the same assignment is also present in qt5.inc.
    Shouldn't this rather be the default?

3.) libconnman-qt installs a qml plugin, resulting in:
    | WARNING: QA Issue: libconnman-qt5: Files/directories were installed but not shipped
    | [...]
    | ${STAGING_DIR_TARGET}/usr/lib/qt5/qml/MeeGo/Connman/libConnmanQtDeclarative.so

    How would I get rid of the STAGING_DIR_TARGET prefix? Is this an error in
    qmake5.bblass? This doesn't happen with Qt4/X11 or Qt4/Embedded.

 recipes-qt/libconnman-qt/libconnman-qt5_git.bb | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 recipes-qt/libconnman-qt/libconnman-qt5_git.bb
Martin Jansa - Jan. 28, 2014, 9:43 p.m.
On Tue, Jan 28, 2014 at 10:29:13PM +0100, Andreas Oberritter wrote:
> * Please, don't apply! ;-)
> 
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
> ---
> Several questions arose regarding this recipe:
> 
> 1.) Where to put it? It depends on both meta-openembedded and meta-qt5.

IIRC this would be the first requirement of meta-oe and I'm tempted to
say, put it in meta-qt5 but duplicate
recipes-qt/libconnman-qt/libconnman-qt.inc file as well :/

> 2.) Regarding OE_QMAKE_PATH_HEADERS: I stole this from maliit to fix a
>     compiler error, but the same assignment is also present in qt5.inc.
>     Shouldn't this rather be the default?

No, because not all qmake built components are using qt headers, see:
https://github.com/meta-qt5/meta-qt5/wiki/Building-with-OE#wiki-bad-include-paths-and-build-failing-to-find-qt5-headers

> 3.) libconnman-qt installs a qml plugin, resulting in:
>     | WARNING: QA Issue: libconnman-qt5: Files/directories were installed but not shipped
>     | [...]
>     | ${STAGING_DIR_TARGET}/usr/lib/qt5/qml/MeeGo/Connman/libConnmanQtDeclarative.so
> 
>     How would I get rid of the STAGING_DIR_TARGET prefix? Is this an error in
>     qmake5.bblass? This doesn't happen with Qt4/X11 or Qt4/Embedded.

I've seen such (or similar) issues before in some recipes, but don't
really remember the details, can you please check if it does the same
with 5.1.1?

>  recipes-qt/libconnman-qt/libconnman-qt5_git.bb | 7 +++++++
>  1 file changed, 7 insertions(+)
>  create mode 100644 recipes-qt/libconnman-qt/libconnman-qt5_git.bb
> 
> diff --git a/recipes-qt/libconnman-qt/libconnman-qt5_git.bb b/recipes-qt/libconnman-qt/libconnman-qt5_git.bb
> new file mode 100644
> index 0000000..bd91446
> --- /dev/null
> +++ b/recipes-qt/libconnman-qt/libconnman-qt5_git.bb
> @@ -0,0 +1,7 @@
> +inherit qmake5
> +
> +# Set path of qt5 headers as qmake5_base.bbclass sets this to just ${includedir}
> +# but actually it is ${includedir}/qt5
> +OE_QMAKE_PATH_HEADERS = "${OE_QMAKE_PATH_QT_HEADERS}"
> +
> +require recipes-qt/libconnman-qt/libconnman-qt.inc
> -- 
> 1.8.3.2
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Otavio Salvador - Jan. 28, 2014, 9:53 p.m.
On Tue, Jan 28, 2014 at 7:29 PM, Andreas Oberritter
<obi@opendreambox.org> wrote:
> * Please, don't apply! ;-)
>
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
> ---
> Several questions arose regarding this recipe:
>
> 1.) Where to put it? It depends on both meta-openembedded and meta-qt5.

We can add meta-openembedded inside meta-qt5 and make it to be parsed
if it is found in the collections. What people thing?

> 2.) Regarding OE_QMAKE_PATH_HEADERS: I stole this from maliit to fix a
>     compiler error, but the same assignment is also present in qt5.inc.
>     Shouldn't this rather be the default?

I agree.

> 3.) libconnman-qt installs a qml plugin, resulting in:
>     | WARNING: QA Issue: libconnman-qt5: Files/directories were installed but not shipped
>     | [...]
>     | ${STAGING_DIR_TARGET}/usr/lib/qt5/qml/MeeGo/Connman/libConnmanQtDeclarative.so
>
>     How would I get rid of the STAGING_DIR_TARGET prefix? Is this an error in
>     qmake5.bblass? This doesn't happen with Qt4/X11 or Qt4/Embedded.

No clue.
Otavio Salvador - Jan. 28, 2014, 9:54 p.m.
On Tue, Jan 28, 2014 at 7:53 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
...
>> 2.) Regarding OE_QMAKE_PATH_HEADERS: I stole this from maliit to fix a
>>     compiler error, but the same assignment is also present in qt5.inc.
>>     Shouldn't this rather be the default?
>
> I agree.

Martin point explains why we shouldn't do it.

Patch

diff --git a/recipes-qt/libconnman-qt/libconnman-qt5_git.bb b/recipes-qt/libconnman-qt/libconnman-qt5_git.bb
new file mode 100644
index 0000000..bd91446
--- /dev/null
+++ b/recipes-qt/libconnman-qt/libconnman-qt5_git.bb
@@ -0,0 +1,7 @@ 
+inherit qmake5
+
+# Set path of qt5 headers as qmake5_base.bbclass sets this to just ${includedir}
+# but actually it is ${includedir}/qt5
+OE_QMAKE_PATH_HEADERS = "${OE_QMAKE_PATH_QT_HEADERS}"
+
+require recipes-qt/libconnman-qt/libconnman-qt.inc