Patchwork [2/3] webkit-gtk: recommends glib-networking to access https web page

login
register
mail settings
Submitter Zhai, Edwin
Date June 28, 2011, 7:42 a.m.
Message ID <7bf8a7025dddd0b251ff9c37a55f28b7e099fad7.1309246787.git.edwin.zhai@intel.com>
Download mbox | patch
Permalink /patch/6595/
State New, archived
Headers show

Comments

Zhai, Edwin - June 28, 2011, 7:42 a.m.
From: Zhai Edwin <edwin.zhai@intel.com>

[YOCTO #1037] got fixed

Signed-off-by: Zhai Edwin <edwin.zhai@intel.com>
---
 meta/recipes-sato/webkit/webkit-gtk_svn.bb |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Koen Kooi - June 28, 2011, 8:01 a.m.
Op 28 jun 2011, om 09:42 heeft edwin.zhai@intel.com het volgende geschreven:

> From: Zhai Edwin <edwin.zhai@intel.com>
> 
> [YOCTO #1037] got fixed
> 
> Signed-off-by: Zhai Edwin <edwin.zhai@intel.com>
> ---
> meta/recipes-sato/webkit/webkit-gtk_svn.bb |    3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/recipes-sato/webkit/webkit-gtk_svn.bb b/meta/recipes-sato/webkit/webkit-gtk_svn.bb
> index 6d134ad..c9ded4e 100644
> --- a/meta/recipes-sato/webkit/webkit-gtk_svn.bb
> +++ b/meta/recipes-sato/webkit/webkit-gtk_svn.bb
> @@ -10,6 +10,9 @@ LIC_FILES_CHKSUM = "file://WebCore/rendering/RenderApplet.h;endline=22;md5=fb969
> DEPENDS = "enchant gnome-keyring libsoup-2.4 curl icu libxml2 cairo libxslt libxt libidn gnutls gtk+ gstreamer gst-plugins-base flex-native gperf-native perl-native-runtime sqlite3"
> DEPENDS_darwin8 = "curl icu libxml2 cairo libxslt libidn gnutls gtk+ gstreamer flex-native gperf-native perl-native-runtime sqlite3"
> 
> +# To access ssl web pages
> +RRECOMMENDS_${PN} += "glib-networking"

Since webkit uses soup and curl, wouldn't it be better to add the RRECOMMENDS to soup instead? Webkit knows nothing about GIO.

regards,

Koen
Zhai, Edwin - June 28, 2011, 8:13 a.m.
Koen Kooi wrote:
>
> Op 28 jun 2011, om 09:42 heeft edwin.zhai@intel.com het volgende 
> geschreven:
>
> > From: Zhai Edwin <edwin.zhai@intel.com>
> >
> > [YOCTO #1037] got fixed
> >
> > Signed-off-by: Zhai Edwin <edwin.zhai@intel.com>
> > ---
> > meta/recipes-sato/webkit/webkit-gtk_svn.bb |    3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/meta/recipes-sato/webkit/webkit-gtk_svn.bb 
> b/meta/recipes-sato/webkit/webkit-gtk_svn.bb
> > index 6d134ad..c9ded4e 100644
> > --- a/meta/recipes-sato/webkit/webkit-gtk_svn.bb
> > +++ b/meta/recipes-sato/webkit/webkit-gtk_svn.bb
> > @@ -10,6 +10,9 @@ LIC_FILES_CHKSUM = 
> "file://WebCore/rendering/RenderApplet.h;endline=22;md5=fb969
> > DEPENDS = "enchant gnome-keyring libsoup-2.4 curl icu libxml2 cairo 
> libxslt libxt libidn gnutls gtk+ gstreamer gst-plugins-base 
> flex-native gperf-native perl-native-runtime sqlite3"
>
> > DEPENDS_darwin8 = "curl icu libxml2 cairo libxslt libidn gnutls gtk+ 
> gstreamer flex-native gperf-native perl-native-runtime sqlite3"
>
> >
> > +# To access ssl web pages
> > +RRECOMMENDS_${PN} += "glib-networking"
>
> Since webkit uses soup and curl, wouldn't it be better to add the 
> RRECOMMENDS to soup instead? Webkit knows nothing about GIO.
>

I have considered it. But the drawback is that many other recipes depend 
on libsoup, so glib-networking will be built unnecessarily(webkit-gtk is 
not in core-image-sato). glib-netwoking just provides some plug-in style 
modules, so I think RRECOMMENDS from webkit-gtk should be okay( not 
RDEPENDS).

In future, other recipes besides webkit-gtk may ask for glib-networking, 
maybe we can change it that time?
What's your opinion?


> regards,
>
> Koen
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Koen Kooi - June 28, 2011, 8:36 a.m.
Op 28 jun 2011, om 10:13 heeft Zhai, Edwin het volgende geschreven:

> 
> 
> Koen Kooi wrote:
>> 
>> Op 28 jun 2011, om 09:42 heeft edwin.zhai@intel.com het volgende geschreven:
>> 
>> > From: Zhai Edwin <edwin.zhai@intel.com>
>> >
>> > [YOCTO #1037] got fixed
>> >
>> > Signed-off-by: Zhai Edwin <edwin.zhai@intel.com>
>> > ---
>> > meta/recipes-sato/webkit/webkit-gtk_svn.bb |    3 +++
>> > 1 files changed, 3 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/meta/recipes-sato/webkit/webkit-gtk_svn.bb b/meta/recipes-sato/webkit/webkit-gtk_svn.bb
>> > index 6d134ad..c9ded4e 100644
>> > --- a/meta/recipes-sato/webkit/webkit-gtk_svn.bb
>> > +++ b/meta/recipes-sato/webkit/webkit-gtk_svn.bb
>> > @@ -10,6 +10,9 @@ LIC_FILES_CHKSUM = "file://WebCore/rendering/RenderApplet.h;endline=22;md5=fb969
>> > DEPENDS = "enchant gnome-keyring libsoup-2.4 curl icu libxml2 cairo libxslt libxt libidn gnutls gtk+ gstreamer gst-plugins-base flex-native gperf-native perl-native-runtime sqlite3"
>> 
>> > DEPENDS_darwin8 = "curl icu libxml2 cairo libxslt libidn gnutls gtk+ gstreamer flex-native gperf-native perl-native-runtime sqlite3"
>> 
>> >
>> > +# To access ssl web pages
>> > +RRECOMMENDS_${PN} += "glib-networking"
>> 
>> Since webkit uses soup and curl, wouldn't it be better to add the RRECOMMENDS to soup instead? Webkit knows nothing about GIO.
>> 
> 
> I have considered it. But the drawback is that many other recipes depend on libsoup, so glib-networking will be built unnecessarily(webkit-gtk is not in core-image-sato). glib-netwoking just provides some plug-in style modules, so I think RRECOMMENDS from webkit-gtk should be okay( not RDEPENDS).
> 
> In future, other recipes besides webkit-gtk may ask for glib-networking, maybe we can change it that time?
> What's your opinion?

I'd either put it in the lib that uses it (soup) or the app that needs it (web-webkit), something in between is just confusing.

regards,

Koen
Zhai, Edwin - June 28, 2011, 12:08 p.m.
Koen Kooi wrote:
>
> Op 28 jun 2011, om 10:13 heeft Zhai, Edwin het volgende geschreven:
>
> >
> > In future, other recipes besides webkit-gtk may ask for 
> glib-networking, maybe we can change it that time?
> > What's your opinion?
>
> I'd either put it in the lib that uses it (soup) or the app that needs 
> it (web-webkit), something in between is just confusing.
>

Reasonable. I'd like to put it in libsoup.
Thanks,
edwin

> regards,
>
> Koen
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Richard Purdie - June 28, 2011, 12:37 p.m.
On Tue, 2011-06-28 at 20:08 +0800, Zhai, Edwin wrote:
> 
> Koen Kooi wrote:
> >
> > Op 28 jun 2011, om 10:13 heeft Zhai, Edwin het volgende geschreven:
> >
> > >
> > > In future, other recipes besides webkit-gtk may ask for 
> > glib-networking, maybe we can change it that time?
> > > What's your opinion?
> >
> > I'd either put it in the lib that uses it (soup) or the app that needs 
> > it (web-webkit), something in between is just confusing.
> >
> 
> Reasonable. I'd like to put it in libsoup.

Actually, I think this sounds like a strong case to put it in
web-webkit. My reasoning is that none of the other packages have the
dependency, its really the use webkit makes of the libraries that is the
requirement for the package...

Cheers,

Richard
Zhai, Edwin - June 28, 2011, 12:42 p.m.
Done. Commits @ same contrib tree.
  git://git.pokylinux.org/poky-contrib gzhai/master
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=gzhai/master


Thanks,
edwin


Zhai, Edwin wrote:
>
>
> Koen Kooi wrote:
> >
> > Op 28 jun 2011, om 10:13 heeft Zhai, Edwin het volgende geschreven:
> >
> > >
> > > In future, other recipes besides webkit-gtk may ask for
> > glib-networking, maybe we can change it that time?
> > > What's your opinion?
> >
> > I'd either put it in the lib that uses it (soup) or the app that needs
> > it (web-webkit), something in between is just confusing.
> >
>
> Reasonable. I'd like to put it in libsoup.
> Thanks,
> edwin
>
> > regards,
> >
> > Koen
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> >
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Zhai, Edwin - June 29, 2011, 1:18 a.m.
Richard Purdie wrote:
>
> On Tue, 2011-06-28 at 20:08 +0800, Zhai, Edwin wrote:
> >
> > Koen Kooi wrote:
> > >
> > > Op 28 jun 2011, om 10:13 heeft Zhai, Edwin het volgende geschreven:
> > >
> > > >
> > > > In future, other recipes besides webkit-gtk may ask for
> > > glib-networking, maybe we can change it that time?
> > > > What's your opinion?
> > >
> > > I'd either put it in the lib that uses it (soup) or the app that 
> needs
> > > it (web-webkit), something in between is just confusing.
> > >
> >
> > Reasonable. I'd like to put it in libsoup.
>
> Actually, I think this sounds like a strong case to put it in
> web-webkit. My reasoning is that none of the other packages have the
> dependency, its really the use webkit makes of the libraries that is the
> requirement for the package...
>

Yes, but other web browser may be used in future to introduce extra 
dependency. Anyway, this is just trade off, I'll re-send pull-request to 
put it under web-webkit,

Thanks,
edwin
>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-sato/webkit/webkit-gtk_svn.bb b/meta/recipes-sato/webkit/webkit-gtk_svn.bb
index 6d134ad..c9ded4e 100644
--- a/meta/recipes-sato/webkit/webkit-gtk_svn.bb
+++ b/meta/recipes-sato/webkit/webkit-gtk_svn.bb
@@ -10,6 +10,9 @@  LIC_FILES_CHKSUM = "file://WebCore/rendering/RenderApplet.h;endline=22;md5=fb969
 DEPENDS = "enchant gnome-keyring libsoup-2.4 curl icu libxml2 cairo libxslt libxt libidn gnutls gtk+ gstreamer gst-plugins-base flex-native gperf-native perl-native-runtime sqlite3"
 DEPENDS_darwin8 = "curl icu libxml2 cairo libxslt libidn gnutls gtk+ gstreamer flex-native gperf-native perl-native-runtime sqlite3"
 
+# To access ssl web pages
+RRECOMMENDS_${PN} += "glib-networking"
+
 SRCREV_FORMAT = "webcore-rwebkit"
 
 SRCREV = "72836"